Skip to content

Commit 753ef7f

Browse files
committed
add migration note
1 parent cd0e974 commit 753ef7f

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

docs/migration/v8-to-v9.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,15 @@ Sentry.init({
141141
- The `flatten` export has been removed. There is no replacement.
142142
- The `urlEncode` method has been removed. There is no replacement.
143143
- The `getDomElement` method has been removed. There is no replacement.
144-
- The `Request` type has been removed. Use `RequestEventData` type instead.
145144
- The `memoBuilder` method has been removed. There is no replacement.
146145

146+
#### Other/Internal Changes
147+
148+
The following changes are unlikely to affect users of the SDK. They are listed here only for completion sake, and to alert users that may be relying on internal behavior.
149+
150+
- `client._prepareEvent()` now requires a currentScope & isolationScope to be passed as last arugments
151+
- `client._processEvent()` is now private (was protected)
152+
147153
### `@sentry/browser`
148154

149155
- The `captureUserFeedback` method has been removed. Use `captureFeedback` instead and update the `comments` field to `message`.
@@ -207,6 +213,7 @@ This led to some duplication, where we had to keep an interface in `@sentry/type
207213
Since v9, the types have been merged into `@sentry/core`, which removed some of this duplication. This means that certain things that used to be a separate interface, will not expect an actual instance of the class/concrete implementation. This should not affect most users, unless you relied on passing things with a similar shape to internal methods. The following types are affected:
208214

209215
- `Scope` now always expects the `Scope` class
216+
- The `Request` type has been removed. Use `RequestEventData` type instead.
210217

211218
# No Version Support Timeline
212219

packages/core/src/baseclient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
764764
* @param currentScope A scope containing event metadata.
765765
* @returns A SyncPromise that resolves with the event or rejects in case event was/will not be send.
766766
*/
767-
protected _processEvent(
767+
private _processEvent(
768768
event: Event,
769769
hint: EventHint,
770770
currentScope: Scope,

0 commit comments

Comments
 (0)