Skip to content

Commit 7890130

Browse files
committed
build(ci): Ensure we run E2E tests when profiling node is skipped
1 parent 1a4b6e6 commit 7890130

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

.github/workflows/build.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -952,7 +952,13 @@ jobs:
952952
953953
job_e2e_prepare:
954954
name: Prepare E2E tests
955-
if:
955+
# We want to run this if:
956+
# - The build job was successful, not skipped
957+
# - AND if the profiling node bindings were either successful or skipped
958+
# AND if this is not a PR from a fork or dependabot
959+
if: |
960+
always() && needs.job_build.result == 'success' &&
961+
(needs.job_compile_bindings_profiling_node.result == 'success' || needs.job_compile_bindings_profiling_node.result == 'skipped') &&
956962
(github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) &&
957963
github.actor != 'dependabot[bot]'
958964
needs: [job_get_metadata, job_build, job_compile_bindings_profiling_node]
@@ -1014,7 +1020,10 @@ jobs:
10141020
name: E2E ${{ matrix.label || matrix.test-application }} Test
10151021
# We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
10161022
# Dependabot PRs sadly also don't have access to secrets, so we skip them as well
1023+
# We need to add the `always()` check here because the previous step has this as well :(
1024+
# See: https://github.com/actions/runner/issues/2205
10171025
if:
1026+
always() && needs.job_e2e_prepare.result == 'success' &&
10181027
(github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) &&
10191028
github.actor != 'dependabot[bot]'
10201029
needs: [job_get_metadata, job_build, job_e2e_prepare]

0 commit comments

Comments
 (0)