remove metrics summary

Author: AbhiPrasad

dev-packages/browser-integration-tests/suites/metrics/timing/test.ts

@@ -67,20 +67,6 @@ sentryTest('allows to wrap sync methods with a timing metric', async ({ getLocal
   expect(span.op).toEqual('metrics.timing');
   expect(span.description).toEqual('timingSync');
   expect(span.timestamp! - span.start_timestamp).toEqual(duration);
-  expect(span._metrics_summary).toEqual({
-    'd:timingSync@second': [
-      {
-        count: 1,
-        max: duration,
-        min: duration,
-        sum: duration,
-        tags: {
-          release: '1.0.0',
-          transaction: 'manual span',
-        },
-      },
-    ],
-  });
 });
 
 sentryTest('allows to wrap async methods with a timing metric', async ({ getLocalTestUrl, page }) => {
@@ -142,18 +128,4 @@ sentryTest('allows to wrap async methods with a timing metric', async ({ getLoca
   expect(span.op).toEqual('metrics.timing');
   expect(span.description).toEqual('timingAsync');
   expect(span.timestamp! - span.start_timestamp).toEqual(duration);
-  expect(span._metrics_summary).toEqual({
-    'd:timingAsync@second': [
-      {
-        count: 1,
-        max: duration,
-        min: duration,
-        sum: duration,
-        tags: {
-          release: '1.0.0',
-          transaction: 'manual span',
-        },
-      },
-    ],
-  });
 });

dev-packages/node-integration-tests/suites/tracing/metric-summaries/scenario.js

@@ -126,8 +126,6 @@ export function makeTerserPlugin() {
           '_sentryId',
           // Keeps the frozen DSC on a Sentry Span
           '_frozenDsc',
-          // This keeps metrics summary on spans
-          '_metrics_summary',
           // These are used to keep span & scope relationships
           '_sentryRootSpan',
           '_sentryChildSpans',

dev-packages/node-integration-tests/suites/tracing/metric-summaries/test.ts

@@ -110,7 +110,6 @@ export { profiler } from './profiling';
 // eslint-disable-next-line deprecation/deprecation
 export { metricsDefault } from './metrics/exports-default';
 export { BrowserMetricsAggregator } from './metrics/browser-aggregator';
-export { getMetricSummaryJsonForSpan } from './metrics/metric-summary';
 export {
   // eslint-disable-next-line deprecation/deprecation
   addTracingHeadersToFetchRequest,

dev-packages/rollup-utils/plugins/bundlePlugins.mjs

@@ -1,7 +1,6 @@
 import type { Client, MeasurementUnit, MetricsAggregator as MetricsAggregatorBase, Primitive } from '../types-hoist';
 import { timestampInSeconds } from '../utils-hoist/time';
-import { updateMetricSummaryOnActiveSpan } from '../utils/spanUtils';
-import { DEFAULT_FLUSH_INTERVAL, MAX_WEIGHT, SET_METRIC_TYPE } from './constants';
+import { DEFAULT_FLUSH_INTERVAL, MAX_WEIGHT } from './constants';
 import { captureAggregateMetrics } from './envelope';
 import { METRIC_MAP } from './instance';
 import type { MetricBucket, MetricType } from './types';
@@ -67,9 +66,6 @@ export class MetricsAggregator implements MetricsAggregatorBase {
     const bucketKey = getBucketKey(metricType, name, unit, tags);
 
     let bucketItem = this._buckets.get(bucketKey);
-    // If this is a set metric, we need to calculate the delta from the previous weight.
-    const previousWeight = bucketItem && metricType === SET_METRIC_TYPE ? bucketItem.metric.weight : 0;
-
     if (bucketItem) {
       bucketItem.metric.add(value);
       // TODO(abhi): Do we need this check?
@@ -89,10 +85,6 @@ export class MetricsAggregator implements MetricsAggregatorBase {
       this._buckets.set(bucketKey, bucketItem);
     }
 
-    // If value is a string, it's a set metric so calculate the delta from the previous weight.
-    const val = typeof value === 'string' ? bucketItem.metric.weight - previousWeight : value;
-    updateMetricSummaryOnActiveSpan(metricType, name, val, unit, unsanitizedTags, bucketKey);
-
     // We need to keep track of the total weight of the buckets so that we can
     // flush them when we exceed the max weight.
     this._bucketsTotalWeight += bucketItem.metric.weight;

packages/core/src/index.ts

@@ -1,7 +1,6 @@
 import type { Client, MeasurementUnit, MetricsAggregator, Primitive } from '../types-hoist';
 import { timestampInSeconds } from '../utils-hoist/time';
-import { updateMetricSummaryOnActiveSpan } from '../utils/spanUtils';
-import { DEFAULT_BROWSER_FLUSH_INTERVAL, SET_METRIC_TYPE } from './constants';
+import { DEFAULT_BROWSER_FLUSH_INTERVAL } from './constants';
 import { captureAggregateMetrics } from './envelope';
 import { METRIC_MAP } from './instance';
 import type { MetricBucket, MetricType } from './types';
@@ -44,9 +43,6 @@ export class BrowserMetricsAggregator implements MetricsAggregator {
     const bucketKey = getBucketKey(metricType, name, unit, tags);
 
     let bucketItem = this._buckets.get(bucketKey);
-    // If this is a set metric, we need to calculate the delta from the previous weight.
-    const previousWeight = bucketItem && metricType === SET_METRIC_TYPE ? bucketItem.metric.weight : 0;
-
     if (bucketItem) {
       bucketItem.metric.add(value);
       // TODO(abhi): Do we need this check?
@@ -65,10 +61,6 @@ export class BrowserMetricsAggregator implements MetricsAggregator {
       };
       this._buckets.set(bucketKey, bucketItem);
     }
-
-    // If value is a string, it's a set metric so calculate the delta from the previous weight.
-    const val = typeof value === 'string' ? bucketItem.metric.weight - previousWeight : value;
-    updateMetricSummaryOnActiveSpan(metricType, name, val, unit, unsanitizedTags, bucketKey);
   }
 
   /**

packages/core/src/metrics/aggregator.ts

@@ -1,7 +1,6 @@
 import { getClient, getCurrentScope } from '../currentScopes';
 import { DEBUG_BUILD } from '../debug-build';
 import { createSpanEnvelope } from '../envelope';
-import { getMetricSummaryJsonForSpan } from '../metrics/metric-summary';
 import {
   SEMANTIC_ATTRIBUTE_EXCLUSIVE_TIME,
   SEMANTIC_ATTRIBUTE_PROFILE_ID,
@@ -233,7 +232,6 @@ export class SentrySpan implements Span {
       timestamp: this._endTime,
       trace_id: this._traceId,
       origin: this._attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
-      _metrics_summary: getMetricSummaryJsonForSpan(this),
       profile_id: this._attributes[SEMANTIC_ATTRIBUTE_PROFILE_ID] as string | undefined,
       exclusive_time: this._attributes[SEMANTIC_ATTRIBUTE_EXCLUSIVE_TIME] as number | undefined,
       measurements: timedEventsToMeasurements(this._events),
@@ -385,7 +383,6 @@ export class SentrySpan implements Span {
           dynamicSamplingContext: getDynamicSamplingContextFromSpan(this),
         }),
       },
-      _metrics_summary: getMetricSummaryJsonForSpan(this),
       ...(source && {
         transaction_info: {
           source,

packages/core/src/metrics/browser-aggregator.ts

@@ -13,7 +13,7 @@ import type { RequestEventData } from './request';
 import type { CaptureContext, Scope } from './scope';
 import type { SdkInfo } from './sdkinfo';
 import type { SeverityLevel } from './severity';
-import type { MetricSummary, SpanJSON } from './span';
+import type { SpanJSON } from './span';
 import type { Thread } from './thread';
 import type { TransactionSource } from './transaction';
 import type { User } from './user';
@@ -82,7 +82,6 @@ export interface ErrorEvent extends Event {
 }
 export interface TransactionEvent extends Event {
   type: 'transaction';
-  _metrics_summary?: Record<string, Array<MetricSummary>>;
 }
 
 /** JSDoc */