Skip to content

Commit 7a5ab9c

Browse files
committed
make measurements undefined
1 parent 4d1d9a8 commit 7a5ab9c

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

packages/core/src/tracing/measurement.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@ export function setMeasurement(name: string, value: number, unit: MeasurementUni
2323
/**
2424
* Convert timed events to measurements.
2525
*/
26-
export function timedEventsToMeasurements(events: TimedEvent[]): Measurements {
26+
export function timedEventsToMeasurements(events: TimedEvent[]): Measurements | undefined {
27+
if (!events || events.length === 0) {
28+
return undefined;
29+
}
30+
2731
const measurements: Measurements = {};
2832
events.forEach(event => {
2933
const attributes = event.attributes || {};

packages/opentelemetry/src/spanExporter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ function maybeSend(spans: ReadableSpan[]): ReadableSpan[] {
143143
transactionEvent.spans = spans;
144144

145145
const measurements = timedEventsToMeasurements(span.events);
146-
if (Object.keys(measurements).length) {
146+
if (measurements && Object.keys(measurements).length) {
147147
transactionEvent.measurements = measurements;
148148
}
149149

packages/types/src/span.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export interface SpanJSON {
5757
_metrics_summary?: Record<string, Array<MetricSummary>>;
5858
profile_id?: string;
5959
exclusive_time?: number;
60-
measurements: Measurements;
60+
measurements?: Measurements;
6161
}
6262

6363
// These are aligned with OpenTelemetry trace flags

0 commit comments

Comments
 (0)