review comments; remove server code

Author: s1gr1d

packages/nuxt/package.json

@@ -24,7 +24,10 @@
         "import": "./build/esm/index.client.js",
         "require": "./build/cjs/index.client.js"
       },
-      "node": "./build/cjs/index.server.js"
+      "node": {
+        "import": "./build/esm/index.server.js",
+        "require": "./build/cjs/index.server.js"
+      }
     },
     "./module": {
       "types": "./build/module/types.d.ts",
@@ -51,7 +54,6 @@
   },
   "devDependencies": {
     "@nuxt/module-builder": "0.8.0",
-    "nitropack": "2.9.6",
     "nuxt": "^3.12.2"
   },
   "scripts": {

packages/nuxt/src/client/sdk.ts

@@ -1,6 +1,6 @@
+import { init as initBrowser } from '@sentry/browser';
 import { applySdkMetadata } from '@sentry/core';
 import type { Client } from '@sentry/types';
-import { init as initBrowser } from '@sentry/browser';
 import type { SentryVueOptions } from '../common/types';
 
 /**

packages/nuxt/src/common/snippets.ts

@@ -4,11 +4,9 @@ import * as path from 'path';
 // todo: tests
 /** Returns an import snippet */
 export function buildSdkInitFileImportSnippet(filePath: string): string {
-  const pathToPosix = (originalPath: string): string => {
-    return originalPath.split(path.sep).join(path.posix.sep);
-  };
+  const posixPath = filePath.split(path.sep).join(path.posix.sep);
 
-  return `import "${pathToPosix(filePath)}";`;
+  return `import "${posixPath}";`;
 }
 
 // todo: tests
@@ -30,10 +28,10 @@ export function addImportStatement(filePath: string, importStatement: string): v
       fs.writeFileSync(filePath, output, 'utf8');
     } catch (err) {
       // eslint-disable-next-line no-console
-      console.error(`Error writing file: ${err}`);
+      console.error(`[Sentry] Error writing file to ${filePath}: ${err}`);
     }
   } catch (err) {
     // eslint-disable-next-line no-console
-    console.error(`Error reading file: ${err}`);
+    console.error(`[Sentry] Error reading file at ${filePath}: ${err}`);
   }
 }

packages/nuxt/src/common/types.ts

@@ -1,3 +1,4 @@
 import type { init } from '@sentry/vue';
 
+// Omitting 'app' as the Nuxt SDK will add the app instance in the client plugin (users do not have to provide this)
 export type SentryVueOptions = Omit<Parameters<typeof init>[0] & object, 'app'>;

packages/nuxt/src/module.ts

@@ -1,6 +1,6 @@
 import * as fs from 'fs';
 import * as path from 'path';
-import { type Resolver, addPlugin, addServerPlugin, createResolver, defineNuxtModule } from '@nuxt/kit';
+import { type Resolver, addPlugin, createResolver, defineNuxtModule } from '@nuxt/kit';
 import { addImportStatement, buildSdkInitFileImportSnippet } from './common/snippets';
 import type { SentryVueOptions } from './common/types';
 
@@ -27,21 +27,20 @@ export default defineNuxtModule<ModuleOptions>({
             addImportStatement(nuxtApp.rootComponent, buildSdkInitFileImportSnippet(pathToClientInit));
           } catch (err) {
             // eslint-disable-next-line no-console
-            console.error(err);
+            console.error(`[Sentry] Could not add import statement to root component. ${err}`);
           }
         }
       });
     }
 
     if (resolver) {
       addPlugin(resolver.resolve('./runtime/plugins/sentry.client'));
-      addServerPlugin(resolver.resolve('./runtime/plugins/sentry.server'));
     }
   },
 });
 
-function findDefaultSdkInitFile(type: 'server' | 'client'): string | undefined {
-  const possibleFileExtensions = ['ts', 'js', 'mjs', 'cjs', 'mts'];
+function findDefaultSdkInitFile(type: /* 'server' | */ 'client'): string | undefined {
+  const possibleFileExtensions = ['ts', 'js', 'mjs', 'cjs', 'mts', 'cts'];
 
   const cwd = process.cwd();
   return possibleFileExtensions

packages/nuxt/src/runtime/plugins/sentry.server.ts

@@ -9467,6 +9467,7 @@
     "@types/unist" "*"
 
 "@types/history-4@npm:@types/[email protected]", "@types/history-5@npm:@types/[email protected]", "@types/history@*":
+  name "@types/history-4"
   version "4.7.8"
   resolved "https://registry.yarnpkg.com/@types/history/-/history-4.7.8.tgz#49348387983075705fe8f4e02fb67f7daaec4934"
   integrity sha512-S78QIYirQcUoo6UJZx9CSP0O2ix9IaeAXwQi26Rhr/+mg7qqPy8TzaxHSUut7eGjL8WmLccT7/MXf304WjqHcA==
@@ -25455,7 +25456,7 @@ nise@^5.1.4:
     just-extend "^4.0.2"
     path-to-regexp "^1.7.0"
 
-nitropack@2.9.6, nitropack@^2.9.6:
+nitropack@^2.9.6:
   version "2.9.6"
   resolved "https://registry.yarnpkg.com/nitropack/-/nitropack-2.9.6.tgz#90af114b796872f34e125e780e6148525149769f"
   integrity sha512-HP2PE0dREcDIBVkL8Zm6eVyrDd10/GI9hTL00PHvjUM8I9Y/2cv73wRDmxNyInfrx/CJKHATb2U/pQrqpzJyXA==
@@ -28960,6 +28961,7 @@ react-is@^18.0.0:
     "@remix-run/router" "1.0.2"
 
 "react-router-6@npm:[email protected]", [email protected]:
+  name react-router-6
   version "6.3.0"
   resolved "https://registry.yarnpkg.com/react-router/-/react-router-6.3.0.tgz#3970cc64b4cb4eae0c1ea5203a80334fdd175557"
   integrity sha512-7Wh1DzVQ+tlFjkeo+ujvjSqSJmkt1+8JO+T5xklPlgrh70y7ogx75ODRW0ThWhY7S+6yEDks8TYrtQe/aoboBQ==
@@ -31484,6 +31486,7 @@ string-template@~0.2.1:
   integrity sha1-QpMuWYo1LQH8IuwzZ9nYTuxsmt0=
 
 "string-width-cjs@npm:string-width@^4.2.0", string-width@^4.2.0, string-width@^4.2.2, string-width@^4.2.3:
+  name string-width-cjs
   version "4.2.3"
   resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010"
   integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g==
@@ -34719,6 +34722,7 @@ workerpool@^6.4.0:
   integrity sha512-i3KR1mQMNwY2wx20ozq2EjISGtQWDIfV56We+yGJ5yDs8jTwQiLLaqHlkBHITlCuJnYlVRmXegxFxZg7gqI++A==
 
 "wrap-ansi-cjs@npm:wrap-ansi@^7.0.0", wrap-ansi@^7.0.0:
+  name wrap-ansi-cjs
   version "7.0.0"
   resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43"
   integrity sha512-YVGIj2kamLSTxw6NsZjoBxfSwsn0ycdesmc4p+Q21c5zPuZ1pl+NfxVdxPtdHvmNVOQ6XSYG4AUtyt/Fi7D16Q==