ref: Use idleTimout if no activities occur in idle transaction

Author: AbhiPrasad

CHANGELOG.md

@@ -6,6 +6,7 @@
 - [react] feat: Export `createReduxEnhancer` to log redux actions as breadcrumbs, and attach state as an extra. (#2717)
 - [tracing] feat: `Add @sentry/tracing` (#2719)
 - [gatsby] fix: Make APM optional in gatsby package
+- [tracing] ref: Use idleTimout if no activities occur in idle transaction
 
 ## 5.19.2
 

packages/tracing/src/idletransaction.ts

@@ -70,6 +70,10 @@ export class IdleTransaction extends Transaction {
 
   private readonly _beforeFinishCallbacks: BeforeFinishCallback[] = [];
 
+  // If a transaction is created and no activities are added, we want to make sure that
+  // it times out properly. This is cleared and not used when activities are added.
+  private _initTimeout: any;
+
   public constructor(
     transactionContext: TransactionContext,
     private readonly _idleHub?: Hub,
@@ -188,6 +192,11 @@ export class IdleTransaction extends Transaction {
    * @param spanId The span id that represents the activity
    */
   private _pushActivity(spanId: string): void {
+    if (this._initTimeout) {
+      // tslint:disable-next-line: no-unsafe-any
+      clearTimeout(this._initTimeout);
+      this._initTimeout = undefined;
+    }
     logger.log(`[Tracing] pushActivity: ${spanId}`);
     this.activities[spanId] = true;
     logger.log('[Tracing] new activities count', Object.keys(this.activities).length);
@@ -235,12 +244,25 @@ export class IdleTransaction extends Transaction {
    */
   public initSpanRecorder(maxlen?: number): void {
     if (!this.spanRecorder) {
+      this._initTimeout = setTimeout(() => {
+        if (!this._finished) {
+          this.finish();
+        }
+      }, this._idleTimeout);
+
       const pushActivity = (id: string) => {
+        if (this._finished) {
+          return;
+        }
         this._pushActivity(id);
       };
       const popActivity = (id: string) => {
+        if (this._finished) {
+          return;
+        }
         this._popActivity(id);
       };
+
       this.spanRecorder = new IdleTransactionSpanRecorder(pushActivity, popActivity, this.spanId, maxlen);
 
       // Start heartbeat so that transactions do not run forever.

packages/tracing/test/idletransaction.test.ts

@@ -1,7 +1,7 @@
 import { BrowserClient } from '@sentry/browser';
 import { Hub } from '@sentry/hub';
 
-import { IdleTransaction, IdleTransactionSpanRecorder } from '../src/idletransaction';
+import { IdleTransaction, IdleTransactionSpanRecorder, DEFAULT_IDLE_TIMEOUT } from '../src/idletransaction';
 import { Span } from '../src/span';
 import { SpanStatus } from '../src/spanstatus';
 
@@ -145,6 +145,25 @@ describe('IdleTransaction', () => {
     }
   });
 
+  describe('_initTimeout', () => {
+    it('finishes if no activities are added to the transaction', () => {
+      const transaction = new IdleTransaction({ name: 'foo', startTimestamp: 1234 }, hub, 1000);
+      transaction.initSpanRecorder(10);
+
+      jest.runTimersToTime(DEFAULT_IDLE_TIMEOUT);
+      expect(transaction.endTimestamp).toBeDefined();
+    });
+
+    it('does not finish if a activity is started', () => {
+      const transaction = new IdleTransaction({ name: 'foo', startTimestamp: 1234 }, hub, 1000);
+      transaction.initSpanRecorder(10);
+      transaction.startChild({});
+
+      jest.runTimersToTime(DEFAULT_IDLE_TIMEOUT);
+      expect(transaction.endTimestamp).toBeUndefined();
+    });
+  });
+
   describe('heartbeat', () => {
     it('does not start heartbeat if there is no span recorder', () => {
       const transaction = new IdleTransaction({ name: 'foo' }, hub, 1000);
@@ -164,12 +183,14 @@ describe('IdleTransaction', () => {
       jest.runOnlyPendingTimers();
       expect(mockFinish).toHaveBeenCalledTimes(0);
     });
+
     it('finishes a transaction after 3 beats', () => {
       const transaction = new IdleTransaction({ name: 'foo' }, hub, 1000);
       const mockFinish = jest.spyOn(transaction, 'finish');
       transaction.initSpanRecorder(10);
 
       expect(mockFinish).toHaveBeenCalledTimes(0);
+      transaction.startChild({});
 
       // Beat 1
       jest.runOnlyPendingTimers();
@@ -190,6 +211,7 @@ describe('IdleTransaction', () => {
       transaction.initSpanRecorder(10);
 
       expect(mockFinish).toHaveBeenCalledTimes(0);
+      transaction.startChild({});
 
       // Beat 1
       jest.runOnlyPendingTimers();