Skip to content

Commit 80ee8f8

Browse files
committed
feat(perf-issues): Replace sentence style keys with snake case
Replaces old sentence style keys being used for browser spans with snake case equivalents.
1 parent f3bfe11 commit 80ee8f8

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

packages/replay/test/fixtures/transaction.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ export function Transaction(traceId?: string, obj?: Partial<Event>): any {
7474
},
7575
{
7676
data: {
77-
'Transfer Size': 1097,
78-
'Encoded Body Size': 797,
79-
'Decoded Body Size': 1885,
77+
'http.transfer_size': 1097,
78+
'http.response_content_length': 797,
79+
'http.decoded_response_content_length': 1885,
8080
'resource.render_blocking_status': 'non-blocking',
8181
},
8282
description: '/favicon.ico',

packages/tracing-internal/src/browser/metrics/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -402,13 +402,13 @@ export function _addResourceSpans(
402402
// eslint-disable-next-line @typescript-eslint/no-explicit-any
403403
const data: Record<string, any> = {};
404404
if ('transferSize' in entry) {
405-
data['Transfer Size'] = entry.transferSize;
405+
data['http.transfer_size'] = entry.transferSize;
406406
}
407407
if ('encodedBodySize' in entry) {
408-
data['Encoded Body Size'] = entry.encodedBodySize;
408+
data['http.response_content_length'] = entry.encodedBodySize;
409409
}
410410
if ('decodedBodySize' in entry) {
411-
data['Decoded Body Size'] = entry.decodedBodySize;
411+
data['http.decoded_response_content_length'] = entry.decodedBodySize;
412412
}
413413
if ('renderBlockingStatus' in entry) {
414414
data['resource.render_blocking_status'] = entry.renderBlockingStatus;

packages/tracing-internal/test/browser/metrics/index.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,9 @@ describe('_addResourceSpans', () => {
9090
// eslint-disable-next-line @typescript-eslint/unbound-method
9191
expect(transaction.startChild).toHaveBeenLastCalledWith({
9292
data: {
93-
['Decoded Body Size']: entry.decodedBodySize,
94-
['Encoded Body Size']: entry.encodedBodySize,
95-
['Transfer Size']: entry.transferSize,
93+
['http.decoded_response_content_length']: entry.decodedBodySize,
94+
['http.response_content_length']: entry.encodedBodySize,
95+
['http.transfer_size']: entry.transferSize,
9696
['resource.render_blocking_status']: entry.renderBlockingStatus,
9797
},
9898
description: '/assets/to/css',
@@ -158,9 +158,9 @@ describe('_addResourceSpans', () => {
158158
expect(transaction.startChild).toHaveBeenLastCalledWith(
159159
expect.objectContaining({
160160
data: {
161-
['Decoded Body Size']: entry.decodedBodySize,
162-
['Encoded Body Size']: entry.encodedBodySize,
163-
['Transfer Size']: entry.transferSize,
161+
['http.decoded_response_content_length']: entry.decodedBodySize,
162+
['http.response_content_length']: entry.encodedBodySize,
163+
['http.transfer_size']: entry.transferSize,
164164
['resource.render_blocking_status']: entry.renderBlockingStatus,
165165
},
166166
}),

0 commit comments

Comments
 (0)