rename internal startTransaction with leading underscore

lobsterkatie · lobsterkatie · commit 819270a6e720 · 2020-08-25T18:49:25.000-07:00
diff --git a/packages/tracing/src/hubextensions.ts b/packages/tracing/src/hubextensions.ts
@@ -122,7 +122,7 @@ function getDefaultSampleContext(): SampleContext {
  *
  * @see {@link Hub.startTransaction}
  */
-function startTransaction(this: Hub, context: TransactionContext, sampleContext?: SampleContext): Transaction {
+function _startTransaction(this: Hub, context: TransactionContext, sampleContext?: SampleContext): Transaction {
   const transaction = new Transaction(context, this);
   return sample(this, transaction, { ...getDefaultSampleContext(), ...sampleContext });
 }
@@ -149,7 +149,7 @@ export function _addTracingExtensions(): void {
   if (carrier.__SENTRY__) {
     carrier.__SENTRY__.extensions = carrier.__SENTRY__.extensions || {};
     if (!carrier.__SENTRY__.extensions.startTransaction) {
-      carrier.__SENTRY__.extensions.startTransaction = startTransaction;
+      carrier.__SENTRY__.extensions.startTransaction = _startTransaction;
     }
     if (!carrier.__SENTRY__.extensions.traceHeaders) {
       carrier.__SENTRY__.extensions.traceHeaders = traceHeaders;

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ function getDefaultSampleContext(): SampleContext {`
`122`	`122`	`*`
`123`	`123`	`* @see {@link Hub.startTransaction}`
`124`	`124`	`*/`
`125`		`-function startTransaction(this: Hub, context: TransactionContext, sampleContext?: SampleContext): Transaction {`
	`125`	`+function _startTransaction(this: Hub, context: TransactionContext, sampleContext?: SampleContext): Transaction {`
`126`	`126`	`const transaction = new Transaction(context, this);`
`127`	`127`	`return sample(this, transaction, { ...getDefaultSampleContext(), ...sampleContext });`
`128`	`128`	`}`
`@@ -149,7 +149,7 @@ export function _addTracingExtensions(): void {`
`149`	`149`	`if (carrier.__SENTRY__) {`
`150`	`150`	`carrier.__SENTRY__.extensions = carrier.__SENTRY__.extensions \|\| {};`
`151`	`151`	`if (!carrier.__SENTRY__.extensions.startTransaction) {`
`152`		`- carrier.__SENTRY__.extensions.startTransaction = startTransaction;`
	`152`	`+ carrier.__SENTRY__.extensions.startTransaction = _startTransaction;`
`153`	`153`	`}`
`154`	`154`	`if (!carrier.__SENTRY__.extensions.traceHeaders) {`
`155`	`155`	`carrier.__SENTRY__.extensions.traceHeaders = traceHeaders;`