Skip to content

Commit 81ed9bd

Browse files
committed
fix it??
1 parent 26cb98b commit 81ed9bd

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

packages/browser-integration-tests/suites/replay/eventBufferError/test.ts

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ import { expect } from '@playwright/test';
33
import { sentryTest } from '../../../utils/fixtures';
44
import { envelopeRequestParser } from '../../../utils/helpers';
55
import {
6+
getDecompressedRecordingEvents,
67
getReplaySnapshot,
78
isReplayEvent,
89
REPLAY_DEFAULT_FLUSH_MAX_DELAY,
910
shouldSkipReplayTest,
1011
waitForReplayRequest,
11-
replayEnvelopeParser,
1212
} from '../../../utils/replayHelpers';
1313

1414
sentryTest(
@@ -40,17 +40,11 @@ sentryTest(
4040

4141
// We only want to count replays here
4242
if (event && isReplayEvent(event)) {
43-
called++;
44-
}
45-
46-
// TODO FN: Just for debugging....
47-
if (called > 0) {
48-
// eslint-disable-next-line no-console
49-
console.log(event);
50-
51-
const recordingEvents = replayEnvelopeParser(route.request());
52-
// eslint-disable-next-line no-console
53-
console.log(JSON.stringify(recordingEvents, null, 2));
43+
const events = getDecompressedRecordingEvents(route.request());
44+
// this makes sure we ignore e.g. mouse move events which can otherwise lead to flakes
45+
if (events.length > 0) {
46+
called++;
47+
}
5448
}
5549

5650
return route.fulfill({

packages/browser-integration-tests/utils/replayHelpers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ function getOptionsEvents(replayRequest: Request): CustomRecordingEvent[] {
267267
return getAllCustomRrwebRecordingEvents(events).filter(data => data.tag === 'options');
268268
}
269269

270-
function getDecompressedRecordingEvents(resOrReq: Request | Response): RecordingSnapshot[] {
270+
export function getDecompressedRecordingEvents(resOrReq: Request | Response): RecordingSnapshot[] {
271271
const replayRequest = getRequest(resOrReq);
272272
return (
273273
(replayEnvelopeRequestParser(replayRequest, 5) as eventWithTime[])

0 commit comments

Comments
 (0)