move to constants

Author: mydea

packages/replay/src/constants.ts

@@ -31,3 +31,6 @@ export const RETRY_MAX_COUNT = 3;
 
 /* The max (uncompressed) size in bytes of a network body. Any body larger than this will be truncated. */
 export const NETWORK_BODY_MAX_SIZE = 150_000;
+
+/* The max size of a single console arg that is captured. Any arg larger than this will be truncated. */
+export const CONSOLE_ARG_MAX_SIZE = 5_000;

packages/replay/src/coreHandlers/handleScope.ts

@@ -1,15 +1,14 @@
 import type { Breadcrumb, Scope } from '@sentry/types';
 import { normalize } from '@sentry/utils';
 
+import { CONSOLE_ARG_MAX_SIZE } from '../constants';
 import type { ReplayContainer } from '../types';
 import { createBreadcrumb } from '../util/createBreadcrumb';
 import { fixJson } from '../util/truncateJson/fixJson';
 import { addBreadcrumbEvent } from './util/addBreadcrumbEvent';
 
 let _LAST_BREADCRUMB: null | Breadcrumb = null;
 
-export const CONSOLE_ARG_MAX_SIZE = 5_000;
-
 export const handleScopeListener: (replay: ReplayContainer) => (scope: Scope) => void =
   (replay: ReplayContainer) =>
   (scope: Scope): void => {

packages/replay/test/unit/coreHandlers/handleScope.test.ts

@@ -1,5 +1,6 @@
 import type { Breadcrumb, Scope } from '@sentry/types';
 
+import { CONSOLE_ARG_MAX_SIZE } from '../../../src/constants';
 import * as HandleScope from '../../../src/coreHandlers/handleScope';
 
 describe('Unit | coreHandlers | handleScope', () => {
@@ -97,10 +98,7 @@ describe('Unit | coreHandlers | handleScope', () => {
         category: 'console',
         message: 'test',
         data: {
-          arguments: [
-            'a'.repeat(HandleScope.CONSOLE_ARG_MAX_SIZE + 10),
-            'b'.repeat(HandleScope.CONSOLE_ARG_MAX_SIZE + 10),
-          ],
+          arguments: ['a'.repeat(CONSOLE_ARG_MAX_SIZE + 10), 'b'.repeat(CONSOLE_ARG_MAX_SIZE + 10)],
         },
       };
       const actual = HandleScope.normalizeConsoleBreadcrumb(breadcrumb);
@@ -109,10 +107,7 @@ describe('Unit | coreHandlers | handleScope', () => {
         category: 'console',
         message: 'test',
         data: {
-          arguments: [
-            `${'a'.repeat(HandleScope.CONSOLE_ARG_MAX_SIZE)}…`,
-            `${'b'.repeat(HandleScope.CONSOLE_ARG_MAX_SIZE)}…`,
-          ],
+          arguments: [`${'a'.repeat(CONSOLE_ARG_MAX_SIZE)}…`, `${'b'.repeat(CONSOLE_ARG_MAX_SIZE)}…`],
           _meta: { warnings: ['CONSOLE_ARG_TRUNCATED'] },
         },
       });
@@ -125,8 +120,8 @@ describe('Unit | coreHandlers | handleScope', () => {
         data: {
           arguments: [
             { aa: 'yes' },
-            { bb: 'b'.repeat(HandleScope.CONSOLE_ARG_MAX_SIZE + 10) },
-            { c: 'c'.repeat(HandleScope.CONSOLE_ARG_MAX_SIZE + 10) },
+            { bb: 'b'.repeat(CONSOLE_ARG_MAX_SIZE + 10) },
+            { c: 'c'.repeat(CONSOLE_ARG_MAX_SIZE + 10) },
           ],
         },
       };
@@ -138,8 +133,8 @@ describe('Unit | coreHandlers | handleScope', () => {
         data: {
           arguments: [
             { aa: 'yes' },
-            { bb: `${'b'.repeat(HandleScope.CONSOLE_ARG_MAX_SIZE - 7)}~~` },
-            { c: `${'c'.repeat(HandleScope.CONSOLE_ARG_MAX_SIZE - 6)}~~` },
+            { bb: `${'b'.repeat(CONSOLE_ARG_MAX_SIZE - 7)}~~` },
+            { c: `${'c'.repeat(CONSOLE_ARG_MAX_SIZE - 6)}~~` },
           ],
           _meta: { warnings: ['CONSOLE_ARG_TRUNCATED'] },
         },