fix type errors in browser tests

Author: lobsterkatie

packages/browser/test/unit/integrations/linkederrors.test.ts

@@ -1,8 +1,14 @@
-import { ExtendedError } from '@sentry/types';
+import { Event as SentryEvent, Exception, ExtendedError } from '@sentry/types';
 
 import { BrowserBackend } from '../../../src/backend';
 import * as LinkedErrorsModule from '../../../src/integrations/linkederrors';
 
+type EventWithException = SentryEvent & {
+  exception: {
+    values: Exception[];
+  };
+};
+
 describe('LinkedErrors', () => {
   describe('handler', () => {
     it('should bail out if event does not contain exception', () => {
@@ -38,7 +44,7 @@ describe('LinkedErrors', () => {
       return backend.eventFromException(originalException).then(event => {
         const result = LinkedErrorsModule._handler('cause', 5, event, {
           originalException,
-        });
+        }) as EventWithException;
 
         // It shouldn't include root exception, as it's already processed in the event by the main error handler
         expect(result.exception.values.length).toBe(3);
@@ -68,7 +74,7 @@ describe('LinkedErrors', () => {
       return backend.eventFromException(originalException).then(event => {
         const result = LinkedErrorsModule._handler('reason', 5, event, {
           originalException,
-        });
+        }) as EventWithException;
 
         expect(result.exception.values.length).toBe(3);
         expect(result.exception.values[0].type).toBe('SyntaxError');
@@ -95,7 +101,7 @@ describe('LinkedErrors', () => {
       return backend.eventFromException(originalException).then(event => {
         const result = LinkedErrorsModule._handler('cause', 2, event, {
           originalException,
-        });
+        }) as EventWithException;
 
         expect(result.exception.values.length).toBe(2);
         expect(result.exception.values[0].type).toBe('TypeError');

packages/browser/test/unit/mocks/simpletransport.ts

@@ -3,6 +3,7 @@ import { eventStatusFromHttpCode, resolvedSyncPromise } from '@sentry/utils';
 import { Event, Response } from '../../../src';
 import { BaseTransport } from '../../../src/transports';
 
+// @ts-ignore It's okay that we're not implementing the `_sendRequest()` method because we don't use it in our tests
 export class SimpleTransport extends BaseTransport {
   public sendEvent(_: Event): PromiseLike<Response> {
     return this._buffer.add(() =>

packages/browser/test/unit/transports/base.test.ts

@@ -3,6 +3,8 @@ import { BaseTransport } from '../../../src/transports/base';
 const testDsn = 'https://[email protected]/42';
 const envelopeEndpoint = 'https://sentry.io/api/42/envelope/?sentry_key=123&sentry_version=7';
 
+// @ts-ignore We're purposely not implementing the methods of the abstract `BaseTransport` class in order to be able to
+// assert on what the class provides and what it leaves to the concrete class to implement
 class SimpleTransport extends BaseTransport {}
 
 describe('BaseTransport', () => {
@@ -111,12 +113,12 @@ describe('BaseTransport', () => {
     });
   });
 
-  it('doesnt provide sendEvent() implementation', () => {
+  it('doesnt provide sendEvent() implementation', async () => {
     expect.assertions(1);
     const transport = new SimpleTransport({ dsn: testDsn });
 
     try {
-      void transport.sendEvent({});
+      await transport.sendEvent({});
     } catch (e) {
       expect(e).toBeDefined();
     }

packages/browser/test/unit/transports/new-xhr.test.ts

@@ -27,7 +27,7 @@ function createXHRMock() {
         case 'Retry-After':
           return '10';
         case `${retryAfterSeconds}`:
-          return;
+          return null;
         default:
           return `${retryAfterSeconds}:error:scope`;
       }
@@ -57,7 +57,7 @@ describe('NewXHRTransport', () => {
     expect(xhrMock.setRequestHeader).toHaveBeenCalledTimes(0);
     expect(xhrMock.send).toHaveBeenCalledTimes(0);
 
-    await Promise.all([transport.send(ERROR_ENVELOPE), (xhrMock as XMLHttpRequest).onreadystatechange(null)]);
+    await Promise.all([transport.send(ERROR_ENVELOPE), (xhrMock as XMLHttpRequest).onreadystatechange!({} as Event)]);
 
     expect(xhrMock.open).toHaveBeenCalledTimes(1);
     expect(xhrMock.open).toHaveBeenCalledWith('POST', DEFAULT_XHR_TRANSPORT_OPTIONS.url);
@@ -70,7 +70,7 @@ describe('NewXHRTransport', () => {
 
     const [res] = await Promise.all([
       transport.send(ERROR_ENVELOPE),
-      (xhrMock as XMLHttpRequest).onreadystatechange(null),
+      (xhrMock as XMLHttpRequest).onreadystatechange!({} as Event),
     ]);
 
     expect(res).toBeDefined();
@@ -80,7 +80,7 @@ describe('NewXHRTransport', () => {
   it('sets rate limit response headers', async () => {
     const transport = makeNewXHRTransport(DEFAULT_XHR_TRANSPORT_OPTIONS);
 
-    await Promise.all([transport.send(ERROR_ENVELOPE), (xhrMock as XMLHttpRequest).onreadystatechange(null)]);
+    await Promise.all([transport.send(ERROR_ENVELOPE), (xhrMock as XMLHttpRequest).onreadystatechange!({} as Event)]);
 
     expect(xhrMock.getResponseHeader).toHaveBeenCalledTimes(2);
     expect(xhrMock.getResponseHeader).toHaveBeenCalledWith('X-Sentry-Rate-Limits');
@@ -99,7 +99,7 @@ describe('NewXHRTransport', () => {
     };
 
     const transport = makeNewXHRTransport(options);
-    await Promise.all([transport.send(ERROR_ENVELOPE), (xhrMock as XMLHttpRequest).onreadystatechange(null)]);
+    await Promise.all([transport.send(ERROR_ENVELOPE), (xhrMock as XMLHttpRequest).onreadystatechange!({} as Event)]);
 
     expect(xhrMock.setRequestHeader).toHaveBeenCalledTimes(3);
     expect(xhrMock.setRequestHeader).toHaveBeenCalledWith('referrerPolicy', headers.referrerPolicy);