Skip to content

Commit 82e4572

Browse files
committed
modify rather than replacing events in mock beforeSend
1 parent 82f68f7 commit 82e4572

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

packages/core/test/lib/base.test.ts

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -902,7 +902,10 @@ describe('BaseClient', () => {
902902
test('calls `beforeSend` and uses the modified event', () => {
903903
expect.assertions(1);
904904

905-
const beforeSend = jest.fn(() => ({ message: 'changed1' }));
905+
const beforeSend = jest.fn(event => {
906+
event.message = 'changed1';
907+
return event;
908+
});
906909
const options = getDefaultTestClientOptions({ dsn: PUBLIC_DSN, beforeSend });
907910
const client = new TestClient(options);
908911

@@ -980,14 +983,14 @@ describe('BaseClient', () => {
980983
jest.useFakeTimers();
981984
expect.assertions(1);
982985

983-
const beforeSend = jest.fn(
984-
async () =>
985-
new Promise<Event>(resolve => {
986-
setTimeout(() => {
987-
resolve({ message: 'changed2' });
988-
}, 1);
989-
}),
990-
);
986+
const beforeSend = jest.fn(async event => {
987+
event.message = 'changed2';
988+
return new Promise<Event>(resolve => {
989+
setTimeout(() => {
990+
resolve(event);
991+
}, 1);
992+
});
993+
});
991994
const options = getDefaultTestClientOptions({ dsn: PUBLIC_DSN, beforeSend });
992995
const client = new TestClient(options);
993996

0 commit comments

Comments
 (0)