Skip to content

Commit 8376cf0

Browse files
committed
ref(core): Extract _ensureBeforeSendRv into func
1 parent f32cd36 commit 8376cf0

File tree

1 file changed

+22
-24
lines changed

1 file changed

+22
-24
lines changed

packages/core/src/baseclient.ts

Lines changed: 22 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
553553
}
554554

555555
const beforeSendResult = beforeSend(prepared, hint);
556-
return this._ensureBeforeSendRv(beforeSendResult);
556+
return _ensureBeforeSendRv(beforeSendResult);
557557
})
558558
.then(processedEvent => {
559559
if (processedEvent === null) {
@@ -602,29 +602,27 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
602602
},
603603
);
604604
}
605+
}
605606

606-
/**
607-
* Verifies that return value of configured `beforeSend` is of expected type.
608-
*/
609-
protected _ensureBeforeSendRv(
610-
rv: PromiseLike<Event | null> | Event | null,
611-
): PromiseLike<Event | null> | Event | null {
612-
const nullErr = '`beforeSend` method has to return `null` or a valid event.';
613-
if (isThenable(rv)) {
614-
return (rv as PromiseLike<Event | null>).then(
615-
event => {
616-
if (!(isPlainObject(event) || event === null)) {
617-
throw new SentryError(nullErr);
618-
}
619-
return event;
620-
},
621-
e => {
622-
throw new SentryError(`beforeSend rejected with ${e}`);
623-
},
624-
);
625-
} else if (!(isPlainObject(rv) || rv === null)) {
626-
throw new SentryError(nullErr);
627-
}
628-
return rv;
607+
/**
608+
* Verifies that return value of configured `beforeSend` is of expected type.
609+
*/
610+
function _ensureBeforeSendRv(rv: PromiseLike<Event | null> | Event | null): PromiseLike<Event | null> | Event | null {
611+
const nullErr = '`beforeSend` method has to return `null` or a valid event.';
612+
if (isThenable(rv)) {
613+
return (rv as PromiseLike<Event | null>).then(
614+
event => {
615+
if (!(isPlainObject(event) || event === null)) {
616+
throw new SentryError(nullErr);
617+
}
618+
return event;
619+
},
620+
e => {
621+
throw new SentryError(`beforeSend rejected with ${e}`);
622+
},
623+
);
624+
} else if (!(isPlainObject(rv) || rv === null)) {
625+
throw new SentryError(nullErr);
629626
}
627+
return rv;
630628
}

0 commit comments

Comments
 (0)