ref: Move ExtendedError to a types package

Author: kamilogorek

packages/browser/src/integrations/linkederrors.ts

@@ -1,18 +1,11 @@
 import { addGlobalEventProcessor, getCurrentHub } from '@sentry/core';
-import { Event, EventHint, Exception, Integration } from '@sentry/types';
+import { Event, EventHint, Exception, ExtendedError, Integration } from '@sentry/types';
 import { exceptionFromStacktrace } from '../parsers';
 import { computeStackTrace } from '../tracekit';
 
 const DEFAULT_KEY = 'cause';
 const DEFAULT_LIMIT = 5;
 
-/**
- * Just an Error object with arbitrary attributes attached to it.
- */
-interface ExtendedError extends Error {
-  [key: string]: any;
-}
-
 /** Adds SDK info to an event. */
 export class LinkedErrors implements Integration {
   /**

packages/browser/test/integrations/linkederrors.test.ts

@@ -2,13 +2,10 @@ import { expect } from 'chai';
 import { stub } from 'sinon';
 import { BrowserBackend } from '../../src/backend';
 import { LinkedErrors } from '../../src/integrations/linkederrors';
+import { ExtendedError } from '@sentry/types';
 
 let linkedErrors: LinkedErrors;
 
-interface ExtendedError extends Error {
-  [key: string]: any;
-}
-
 describe('LinkedErrors', () => {
   beforeEach(() => {
     linkedErrors = new LinkedErrors();

packages/core/src/integrations/extraerrordata.ts

@@ -1,15 +1,9 @@
 import { addGlobalEventProcessor, getCurrentHub } from '@sentry/hub';
-import { Event, EventHint, Integration } from '@sentry/types';
-import { isError, isString } from '@sentry/utils/is';
+import { Event, EventHint, ExtendedError, Integration } from '@sentry/types';
+import { isError, isPlainObject } from '@sentry/utils/is';
 import { logger } from '@sentry/utils/logger';
 import { safeNormalize } from '@sentry/utils/object';
 
-/**
- * Just an Error object with arbitrary attributes attached to it.
- */
-interface ExtendedError extends Error {
-  [key: string]: unknown;
-}
 
 /** Patch toString calls to return proper name for wrapped functions */
 export class ExtraErrorData implements Integration {

packages/core/test/lib/integrations/extraerrordata.test.ts

@@ -1,13 +1,6 @@
-import { SentryEvent } from '@sentry/types';
+import { ExtendedError, SentryEvent } from '@sentry/types';
 import { ExtraErrorData } from '../../../src/integrations/extraerrordata';
 
-/**
- * Just an Error object with arbitrary attributes attached to it.
- */
-interface ExtendedError extends Error {
-  [key: string]: any;
-}
-
 const extraErrorData = new ExtraErrorData();
 let event: SentryEvent;
 

packages/node/src/integrations/linkederrors.ts

@@ -1,18 +1,11 @@
 import { addGlobalEventProcessor, getCurrentHub } from '@sentry/core';
-import { Event, EventHint, Exception, Integration } from '@sentry/types';
+import { Event, EventHint, Exception, ExtendedError, Integration } from '@sentry/types';
 import { SyncPromise } from '@sentry/utils/syncpromise';
 import { getExceptionFromError } from '../parsers';
 
 const DEFAULT_KEY = 'cause';
 const DEFAULT_LIMIT = 5;
 
-/**
- * Just an Error object with arbitrary attributes attached to it.
- */
-interface ExtendedError extends Error {
-  [key: string]: any;
-}
-
 /** Adds SDK info to an event. */
 export class LinkedErrors implements Integration {
   /**

packages/node/src/parsers.ts

@@ -1,4 +1,4 @@
-import { Event, Exception, StackFrame } from '@sentry/types';
+import { Event, Exception, ExtendedError, StackFrame } from '@sentry/types';
 import { basename, dirname } from '@sentry/utils/path';
 import { snipLine } from '@sentry/utils/string';
 import { SyncPromise } from '@sentry/utils/syncpromise';
@@ -19,13 +19,6 @@ export function resetFileContentCache(): void {
   FILE_CONTENT_CACHE.clear();
 }
 
-/**
- * Just an Error object with arbitrary attributes attached to it.
- */
-interface ExtendedError extends Error {
-  [key: string]: any;
-}
-
 /** JSDoc */
 function getFunction(frame: stacktrace.StackFrame): string {
   try {

packages/node/test/integrations/linkederrors.test.ts

@@ -1,13 +1,10 @@
+import { ExtendedError } from '@sentry/types';
 import { Event } from '../../src';
 import { NodeBackend } from '../../src/backend';
 import { LinkedErrors } from '../../src/integrations/linkederrors';
 
 let linkedErrors: LinkedErrors;
 
-interface ExtendedError extends Error {
-  [key: string]: any;
-}
-
 describe('LinkedErrors', () => {
   beforeEach(() => {
     linkedErrors = new LinkedErrors();

packages/types/src/error.ts

@@ -0,0 +1,6 @@
+/**
+ * Just an Error object with arbitrary attributes attached to it.
+ */
+export interface ExtendedError extends Error {
+  [key: string]: any;
+}

packages/types/src/index.ts

@@ -1,6 +1,7 @@
 export { Breadcrumb, BreadcrumbHint } from './breadcrumb';
 export { Client } from './client';
 export { Dsn, DsnComponents, DsnLike, DsnProtocol } from './dsn';
+export { ExtendedError } from './error';
 export { Event, EventHint } from './event';
 export { EventProcessor } from './eventprocessor';
 export { Exception } from './exception';

packages/utils/src/object.ts

@@ -1,15 +1,8 @@
-import { WrappedFunction } from '@sentry/types';
+import { WrappedFunction, ExtendedError } from '@sentry/types';
 import { isArray, isNaN, isPlainObject, isPrimitive, isUndefined } from './is';
 import { Memo } from './memo';
 import { truncate } from './string';
 
-/**
- * Just an Error object with arbitrary attributes attached to it.
- */
-interface ExtendedError extends Error {
-  [key: string]: any;
-}
-
 /**
  * Serializes the given object into a string.
  * Like JSON.stringify, but doesn't throw on circular references.