Skip to content

Commit 8824558

Browse files
committed
update Ember tests for 4.x
In newer versions, built-in components are Glimmer components, which are not (yet) instrumented. So these will not show up in transaction spans.
1 parent d4d9ed2 commit 8824558

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

packages/ember/tests/acceptance/sentry-performance-test.js

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ function assertSentryCall(assert, callNumber, options) {
2323
}
2424
if (options.spans) {
2525
event.spans = event.spans.map(s => {
26-
// Normalize span descriptions for internal components so tests work on either side of updated Ember versions
27-
const normalizedDescription = s.description === 'component:-link-to' ? 'component:link-to' : s.description;
28-
return `${s.op} | ${normalizedDescription}`;
26+
return `${s.op} | ${s.description}`;
2927
});
3028

3129
// FIXME: For some reason, the last `afterRender` and `destroy` run queue event are not always called.
@@ -50,7 +48,7 @@ function assertSentryCall(assert, callNumber, options) {
5048
}
5149
}
5250

53-
module('Acceptance | Sentry Transactions', function (hooks) {
51+
module('Acceptance | Sentry Performance', function (hooks) {
5452
setupApplicationTest(hooks);
5553
setupSentryTest(hooks);
5654

@@ -61,8 +59,6 @@ module('Acceptance | Sentry Transactions', function (hooks) {
6159
assertSentryCall(assert, 0, {
6260
spans: [
6361
'ui.ember.transition | route:undefined -> route:tracing',
64-
'ui.ember.component.render | component:link-to',
65-
'ui.ember.component.render | component:link-to',
6662
'ui.ember.component.render | component:test-section',
6763
'ui.ember.runloop.actions | undefined',
6864
'ui.ember.runloop.routerTransitions | undefined',
@@ -88,8 +84,6 @@ module('Acceptance | Sentry Transactions', function (hooks) {
8884
assertSentryCall(assert, 1, {
8985
spans: [
9086
'ui.ember.transition | route:tracing -> route:slow-loading-route.index',
91-
'ui.ember.component.render | component:link-to',
92-
'ui.ember.component.render | component:link-to',
9387
'ui.ember.route.before_model | slow-loading-route',
9488
'ui.ember.runloop.actions | undefined',
9589
'ui.ember.runloop.routerTransitions | undefined',
@@ -105,8 +99,6 @@ module('Acceptance | Sentry Transactions', function (hooks) {
10599
'ui.ember.route.after_model | slow-loading-route',
106100
'ui.ember.runloop.actions | undefined',
107101
'ui.ember.runloop.routerTransitions | undefined',
108-
'ui.ember.component.render | component:link-to',
109-
'ui.ember.component.render | component:link-to',
110102
'ui.ember.runloop.render | undefined',
111103
'ui.ember.runloop.afterRender | undefined',
112104
'ui.ember.runloop.destroy | undefined',
@@ -127,8 +119,6 @@ module('Acceptance | Sentry Transactions', function (hooks) {
127119
'ui.ember.route.setup_controller | slow-loading-route',
128120
'ui.ember.route.setup_controller | slow-loading-route.index',
129121
'ui.ember.runloop.routerTransitions | undefined',
130-
'ui.ember.component.render | component:link-to',
131-
'ui.ember.component.render | component:link-to',
132122
'ui.ember.component.render | component:slow-loading-list',
133123
'ui.ember.component.render | component:slow-loading-list',
134124
'ui.ember.runloop.render | undefined',

0 commit comments

Comments
 (0)