Skip to content

Commit 88eee44

Browse files
committed
add more tests
1 parent c9a0e08 commit 88eee44

File tree

5 files changed

+79
-59
lines changed

5 files changed

+79
-59
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import * as Sentry from '@sentry/node';
2+
import { loggingTransport } from '@sentry-internal/node-integration-tests';
3+
4+
Sentry.init({
5+
dsn: 'https://[email protected]/1337',
6+
release: '1.0',
7+
tracesSampleRate: 1.0,
8+
transport: loggingTransport,
9+
});
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
import * as Sentry from '@sentry/node';
2+
import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
3+
import express from 'express';
4+
import http from 'http';
5+
6+
const app = express();
7+
8+
app.get('/test', (_req, res) => {
9+
http.get(`http://localhost:${app.port}/test2`, httpRes => {
10+
httpRes.on('data', () => {
11+
setTimeout(() => {
12+
res.send({ response: 'response 1' });
13+
}, 200);
14+
});
15+
});
16+
});
17+
18+
app.get('/test2', (_req, res) => {
19+
res.send({ response: 'response 2' });
20+
});
21+
22+
app.get('/test3', (_req, res) => {
23+
res.send({ response: 'response 3' });
24+
});
25+
26+
Sentry.setupExpressErrorHandler(app);
27+
28+
startExpressServerAndSendPortToRunner(app);
Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
import { afterAll, describe, test } from 'vitest';
2+
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';
3+
4+
describe('express with http import xxx', () => {
5+
afterAll(() => {
6+
cleanupChildProcesses();
7+
});
8+
9+
createEsmAndCjsTests(
10+
__dirname,
11+
'scenario.mjs',
12+
'instrument.mjs',
13+
createRunner => {
14+
test('it works when importing the http module', async () => {
15+
const runner = createRunner()
16+
.expect({
17+
transaction: {
18+
transaction: 'GET /test2',
19+
},
20+
})
21+
.expect({
22+
transaction: {
23+
transaction: 'GET /test',
24+
},
25+
})
26+
.expect({
27+
transaction: {
28+
transaction: 'GET /test3',
29+
},
30+
})
31+
.start();
32+
await runner.makeRequest('get', '/test');
33+
await runner.makeRequest('get', '/test3');
34+
await runner.completed();
35+
});
36+
// TODO: This is failing on ESM because importing http is triggering the http spans twice :(
37+
// We need to fix this!
38+
},
39+
{ skipEsm: true },
40+
);
41+
});

dev-packages/node-integration-tests/suites/tracing/ai/scenario.js

Lines changed: 0 additions & 58 deletions
This file was deleted.

dev-packages/node-integration-tests/suites/tracing/ai/test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { join } from 'node:path';
22
import { afterAll, describe, expect, test } from 'vitest';
3-
import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
3+
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';
44

55
// `ai` SDK only support Node 18+
66
describe('ai', () => {

0 commit comments

Comments
 (0)