Skip to content

Commit 89c9a47

Browse files
committed
remove fetch-depth from wrong step, add todo to other fetch-depth step
1 parent 626102f commit 89c9a47

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,10 @@ jobs:
213213
steps:
214214
- name: Check out current commit (${{ github.sha }})
215215
uses: actions/checkout@v2
216+
# TODO: removing `fetch-depth` below seems to have no effect, and the commit which added it had no description,
217+
# so it's not clear why it's necessary. That said, right now ember tests are xfail, so it's a little hard to
218+
# tell if it's safe to remove. Once ember tests are fixed, let's try again with it turned off, and if all goes
219+
# well, we can pull it out.
216220
with:
217221
fetch-depth: 0
218222
- name: Set up Node
@@ -223,7 +227,6 @@ jobs:
223227
# that. If it passes, newer versions of Node should also be fine. This saves us from having to run the Ember
224228
# tests in our Node matrix above.
225229
node-version: '10'
226-
fetch-depth: 0
227230
- name: Check dependency cache
228231
uses: actions/cache@v2
229232
with:

0 commit comments

Comments
 (0)