Merge remote-tracking branch 'origin/develop' into lforst-isolation-scope-propagation

Author: Luca Forstner

.github/workflows/build.yml

@@ -102,6 +102,7 @@ jobs:
               - 'packages/replay/**'
               - 'packages/replay-canvas/**'
               - 'packages/feedback/**'
+              - 'packages/wasm/**'
             browser_integration:
               - *shared
               - *browser
@@ -726,6 +727,32 @@ jobs:
           cd packages/utils
           yarn test:package
 
+  job_check_for_faulty_dts:
+    name: Check for faulty .d.ts files
+    needs: [job_get_metadata, job_build]
+    runs-on: ubuntu-20.04
+    timeout-minutes: 5
+    steps:
+      - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ env.HEAD_COMMIT }}
+      - name: Set up Node
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: 'package.json'
+      - name: Restore caches
+        uses: ./.github/actions/restore-cache
+        env:
+          DEPENDENCY_CACHE_KEY: ${{ needs.job_build.outputs.dependency_cache_key }}
+      - name: Check for dts files that reference stuff in the temporary build folder
+        run: |
+          if grep -r --include "*.d.ts" --exclude-dir ".nxcache" 'import("@sentry(-internal)?/[^/]*/build' .; then
+            echo "Found illegal TypeScript import statement."
+            exit 1
+          fi
+
+
   job_node_integration_tests:
     name:
       Node (${{ matrix.node }})${{ (matrix.typescript && format(' (TS {0})', matrix.typescript)) || '' }} Integration

CHANGELOG.md

@@ -4,6 +4,92 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 7.98.0
+
+This release primarily fixes some type declaration errors:
+
+- feat(core): Export `IntegrationIndex` type (#10337)
+- fix(nextjs): Fix Http integration type declaration (#10338)
+- fix(node): Fix type definitions (#10339)
+
+## 7.97.0
+
+Note: The 7.96.0 release was incomplete. This release is partially encompassing changes from `7.96.0`.
+
+- feat(react): Add `stripBasename` option for React Router 6 (#10314)
+
+## 7.96.0
+
+Note: This release was incomplete. Not all Sentry SDK packages were released for this version. Please upgrade to 7.97.0
+directly.
+
+### Important Changes
+
+#### Deprecations
+
+This release includes some deprecations for integrations in `@sentry/browser` and frontend framework SDKs
+(`@sentry/react`, `@sentry/vue`, etc.). Please take a look at our
+[migration guide](https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md) for more details.
+
+- feat(browser): Export functional integrations & deprecate classes (#10267)
+
+#### Web Vitals Fix for LCP and CLS
+
+This release fixes an issue with the Web Vitals integration where LCP and CLS were not being captured correctly,
+increasing capture rate by 10-30% for some apps. LCP and CLS capturing issues were introduced with version `7.75.0`.
+
+- fix(tracing): Ensure web vitals are correctly stopped/captured (#10323)
+
+### Other Changes
+
+- fix(node): Fix `node-cron` types and add test (#10315)
+- fix(node): Fix downleveled types entry point (#10321)
+- fix(node): LocalVariables integration should use setupOnce (#10307)
+- fix(replay): Fix type for options of replayIntegration (#10325)
+
+Work in this release contributed by @Shubhdeep12. Thank you for your contribution!
+
+## 7.95.0
+
+### Important Changes
+
+#### Deprecations
+
+This release includes some deprecations in preparation for v8.
+
+Most notably, it deprecates the `Replay` & `Feedback` classes in favor of a functional replacement:
+
+```js
+import * as Sentry from '@sentry/browser';
+
+Sentry.init({
+  integrations: [
+    // Instead of
+    new Sentry.Replay(),
+    new Sentry.Feedback(),
+    // Use the functional replacement:
+    Sentry.replayIntegration(),
+    Sentry.feedbackIntegration(),
+  ],
+});
+```
+
+- feat(core): Deprecate `Span.origin` in favor of `sentry.origin` attribute (#10260)
+- feat(core): Deprecate `Span.parentSpanId` (#10244)
+- feat(core): Expose `isInitialized()` to replace checking via `getClient` (#10296)
+- feat(replay): Deprecate `Replay`, `ReplayCanvas`, `Feedback` classes (#10270)
+- feat(wasm): Deprecate `Wasm` integration class (#10230)
+
+### Other Changes
+
+- feat: Make `parameterize` function available through browser and node API (#10085)
+- feat(feedback): Configure feedback border radius (#10289)
+- feat(sveltekit): Update default integration handling & deprecate `addOrUpdateIntegration` (#10263)
+- fix(replay-canvas): Add missing dependency on @sentry/utils (#10279)
+- fix(tracing): Don't send negative ttfb (#10286)
+
+Work in this release contributed by @AleshaOleg. Thank you for your contribution!
+
 ## 7.94.1
 
 This release fixes a publishing issue.

MIGRATION.md

@@ -10,6 +10,12 @@ npx @sentry/migr8@latest
 This will let you select which updates to run, and automatically update your code. Make sure to still review all code
 changes!
 
+## Deprecate using `getClient()` to check if the SDK was initialized
+
+In v8, `getClient()` will stop returning `undefined` if `Sentry.init()` was not called. For cases where this may be used
+to check if Sentry was actually initialized, using `getClient()` will thus not work anymore. Instead, you should use the
+new `Sentry.isInitialized()` utility to check this.
+
 ## Deprecate `getCurrentHub()`
 
 In v8, you will no longer have a Hub, only Scopes as a concept. This also means that `getCurrentHub()` will eventually
@@ -28,14 +34,31 @@ integrations from the `Integrations.XXX` hash, is deprecated in favor of using t
 
 The following list shows how integrations should be migrated:
 
-| Old                      | New                             | Packages                                                                                                |
-| ------------------------ | ------------------------------- | ------------------------------------------------------------------------------------------------------- |
-| `new InboundFilters()`   | `inboundFiltersIntegration()`   | `@sentry/core`, `@sentry/browser`, `@sentry/node`, `@sentry/deno`, `@sentry/bun`, `@sentry/vercel-edge` |
-| `new FunctionToString()` | `functionToStringIntegration()` | `@sentry/core`, `@sentry/browser`, `@sentry/node`, `@sentry/deno`, `@sentry/bun`, `@sentry/vercel-edge` |
-| `new LinkedErrors()`     | `linkedErrorsIntegration()`     | `@sentry/core`, `@sentry/browser`, `@sentry/node`, `@sentry/deno`, `@sentry/bun`, `@sentry/vercel-edge` |
-| `new ModuleMetadata()`   | `moduleMetadataIntegration()`   | `@sentry/core`, `@sentry/browser`                                                                       |
-| `new RequestData()`      | `requestDataIntegration()`      | `@sentry/core`, `@sentry/node`, `@sentry/deno`, `@sentry/bun`, `@sentry/vercel-edge`                    |
-| `new Wasm() `            | `wasmIntegration()`             | `@sentry/wasm`                                                                                          |
+| Old                       | New                              | Packages                                                                                                |
+| ------------------------- | -------------------------------- | ------------------------------------------------------------------------------------------------------- |
+| `new InboundFilters()`    | `inboundFiltersIntegration()`    | `@sentry/core`, `@sentry/browser`, `@sentry/node`, `@sentry/deno`, `@sentry/bun`, `@sentry/vercel-edge` |
+| `new FunctionToString()`  | `functionToStringIntegration()`  | `@sentry/core`, `@sentry/browser`, `@sentry/node`, `@sentry/deno`, `@sentry/bun`, `@sentry/vercel-edge` |
+| `new LinkedErrors()`      | `linkedErrorsIntegration()`      | `@sentry/core`, `@sentry/browser`, `@sentry/node`, `@sentry/deno`, `@sentry/bun`, `@sentry/vercel-edge` |
+| `new ModuleMetadata()`    | `moduleMetadataIntegration()`    | `@sentry/core`, `@sentry/browser`                                                                       |
+| `new RequestData()`       | `requestDataIntegration()`       | `@sentry/core`, `@sentry/node`, `@sentry/deno`, `@sentry/bun`, `@sentry/vercel-edge`                    |
+| `new Wasm() `             | `wasmIntegration()`              | `@sentry/wasm`                                                                                          |
+| `new Replay()`            | `replayIntegration()`            | `@sentry/browser`                                                                                       |
+| `new ReplayCanvas()`      | `replayCanvasIntegration()`      | `@sentry/browser`                                                                                       |
+| `new Feedback()`          | `feedbackIntegration()`          | `@sentry/browser`                                                                                       |
+| `new CaptureConsole()`    | `captureConsoleIntegration()`    | `@sentry/integrations`                                                                                  |
+| `new Debug()`             | `debugIntegration()`             | `@sentry/integrations`                                                                                  |
+| `new Dedupe()`            | `dedupeIntegration()`            | `@sentry/browser`, `@sentry/integrations`, `@sentry/deno`                                               |
+| `new ExtraErrorData()`    | `extraErrorDataIntegration()`    | `@sentry/integrations`                                                                                  |
+| `new ReportingObserver()` | `reportingObserverIntegration()` | `@sentry/integrations`                                                                                  |
+| `new RewriteFrames()`     | `rewriteFramesIntegration()`     | `@sentry/integrations`                                                                                  |
+| `new SessionTiming()`     | `sessionTimingIntegration()`     | `@sentry/integrations`                                                                                  |
+| `new HttpClient()`        | `httpClientIntegration()`        | `@sentry/integrations`                                                                                  |
+| `new ContextLines()`      | `contextLinesIntegration()`      | `@sentry/browser`                                                                                       |
+| `new Breadcrumbs()`       | `breadcrumbsIntegration()`       | `@sentry/browser`, `@sentry/deno`                                                                       |
+| `new GlobalHandlers()`    | `globalHandlersIntegration()`    | `@sentry/browser`                                                                                       |
+| `new HttpContext()`       | `httpContextIntegration()`       | `@sentry/browser`                                                                                       |
+| `new TryCatch()`          | `browserApiErrorsIntegration()`  | `@sentry/browser`, `@sentry/deno`                                                                       |
+| `new VueIntegration()`    | `vueIntegration()`               | `@sentry/vue`                                                                                           |
 
 ## Deprecate `hub.bindClient()` and `makeMain()`
 

dev-packages/browser-integration-tests/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/browser-integration-tests",
-  "version": "7.94.1",
+  "version": "7.98.0",
   "main": "index.js",
   "license": "MIT",
   "engines": {
@@ -9,13 +9,14 @@
   "private": true,
   "scripts": {
     "clean": "rimraf -g suites/**/dist loader-suites/**/dist tmp",
-    "install-browsers": "playwright install --with-deps",
+    "install-browsers": "npx playwright install --with-deps",
     "lint": "eslint . --format stylish",
     "fix": "eslint . --format stylish --fix",
     "type-check": "tsc",
+    "postinstall": "yarn install-browsers",
     "pretest": "yarn clean && yarn type-check",
-    "test": "playwright test ./suites --project='chromium'",
-    "test:all": "playwright test ./suites",
+    "test": "yarn test:all --project='chromium'",
+    "test:all": "npx playwright test -c playwright.browser.config.ts",
     "test:bundle:es5": "PW_BUNDLE=bundle_es5 yarn test",
     "test:bundle:es5:min": "PW_BUNDLE=bundle_es5_min yarn test",
     "test:bundle:es6": "PW_BUNDLE=bundle_es6 yarn test",
@@ -30,29 +31,28 @@
     "test:bundle:tracing:replay:es6:min": "PW_BUNDLE=bundle_tracing_replay_es6_min yarn test",
     "test:cjs": "PW_BUNDLE=cjs yarn test",
     "test:esm": "PW_BUNDLE=esm yarn test",
-    "test:loader": "playwright test ./loader-suites --project='chromium'",
+    "test:loader": "npx playwright test  -c playwright.loader.config.ts --project='chromium'",
     "test:loader:base": "PW_BUNDLE=loader_base yarn test:loader",
     "test:loader:eager": "PW_BUNDLE=loader_eager yarn test:loader",
     "test:loader:tracing": "PW_BUNDLE=loader_tracing yarn test:loader",
     "test:loader:replay": "PW_BUNDLE=loader_replay yarn test:loader",
     "test:loader:full": "PW_BUNDLE=loader_tracing_replay yarn test:loader",
     "test:loader:debug": "PW_BUNDLE=loader_debug yarn test:loader",
-    "test:ci": "playwright test ./suites --reporter='line'",
+    "test:ci": "yarn test:all --reporter='line'",
     "test:update-snapshots": "yarn test:all --update-snapshots",
     "test:detect-flaky": "ts-node scripts/detectFlakyTests.ts",
     "validate:es5": "es-check es5 'fixtures/loader.js'"
   },
   "dependencies": {
     "@babel/preset-typescript": "^7.16.7",
-    "@playwright/test": "^1.31.1",
+    "@playwright/test": "^1.40.1",
     "@sentry-internal/rrweb": "2.9.0",
-    "@sentry/browser": "7.94.1",
-    "@sentry/tracing": "7.94.1",
+    "@sentry/browser": "7.98.0",
+    "@sentry/tracing": "7.98.0",
     "axios": "1.6.0",
     "babel-loader": "^8.2.2",
     "html-webpack-plugin": "^5.5.0",
     "pako": "^2.1.0",
-    "playwright": "^1.31.1",
     "webpack": "^5.52.0"
   },
   "devDependencies": {

dev-packages/browser-integration-tests/playwright.browser.config.ts

@@ -0,0 +1,9 @@
+import type { PlaywrightTestConfig } from '@playwright/test';
+import CorePlaywrightConfig from './playwright.config';
+
+const config: PlaywrightTestConfig = {
+  ...CorePlaywrightConfig,
+  testDir: './suites',
+};
+
+export default config;

dev-packages/browser-integration-tests/playwright.config.ts

@@ -8,6 +8,7 @@ const config: PlaywrightTestConfig = {
   // Use 3 workers on CI, else use defaults (based on available CPU cores)
   // Note that 3 is a random number selected to work well with our CI setup
   workers: process.env.CI ? 3 : undefined,
+  testMatch: /test.ts/,
 
   projects: [
     {

dev-packages/browser-integration-tests/playwright.loader.config.ts

@@ -0,0 +1,9 @@
+import type { PlaywrightTestConfig } from '@playwright/test';
+import CorePlaywrightConfig from './playwright.config';
+
+const config: PlaywrightTestConfig = {
+  ...CorePlaywrightConfig,
+  testDir: './loader-suites',
+};
+
+export default config;

dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts

@@ -43,7 +43,7 @@ ${changedPaths.join('\n')}
   try {
     await new Promise<void>((resolve, reject) => {
       const cp = childProcess.spawn(
-        `yarn playwright test ${
+        `npx playwright test ${
           testPaths.length ? testPaths.join(' ') : './suites'
         } --reporter='line' --repeat-each ${runCount}`,
         { shell: true, cwd },