add tests but they no work :(

Lms24 · Lms24 · commit 8c39c5753bc6 · 2023-12-21T20:44:36.000+01:00
diff --git a/packages/browser-integration-tests/suites/public-api/startSpan/basic/subject.js b/packages/browser-integration-tests/suites/public-api/startSpan/basic/subject.js
@@ -0,0 +1,9 @@
+async function run() {
+  Sentry.startSpan({ name: 'parent_span' }, () => {
+    Sentry.startSpan({ name: 'child_span' }, () => {
+      // whatever a user would do here
+    });
+  });
+}
+
+run();
diff --git a/packages/browser-integration-tests/suites/public-api/startSpan/basic/test.ts b/packages/browser-integration-tests/suites/public-api/startSpan/basic/test.ts
@@ -0,0 +1,34 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';
+
+sentryTest('should send a transaction in an envelope', async ({ getLocalTestPath, page }) => {
+  if (shouldSkipTracingTest()) {
+    sentryTest.skip();
+  }
+
+  const url = await getLocalTestPath({ testDir: __dirname });
+  const transaction = await getFirstSentryEnvelopeRequest<Event>(page, url);
+
+  expect(transaction.transaction).toBe('parent_span');
+  expect(transaction.spans).toBeDefined();
+});
+
+sentryTest('should report finished spans as children of the root transaction', async ({ getLocalTestPath, page }) => {
+  if (shouldSkipTracingTest()) {
+    sentryTest.skip();
+  }
+
+  const url = await getLocalTestPath({ testDir: __dirname });
+  const transaction = await getFirstSentryEnvelopeRequest<Event>(page, url);
+
+  const rootSpanId = transaction?.contexts?.trace?.spanId;
+
+  expect(transaction.spans).toHaveLength(1);
+
+  const span_1 = transaction.spans?.[0];
+  expect(span_1?.description).toBe('child_span');
+  expect(span_1?.parentSpanId).toEqual(rootSpanId);
+});
diff --git a/packages/browser-integration-tests/suites/public-api/startSpan/error-async-reject/subject.js b/packages/browser-integration-tests/suites/public-api/startSpan/error-async-reject/subject.js
@@ -0,0 +1,10 @@
+async function run() {
+  await Sentry.startSpan({ name: 'parent_span' }, async () => {
+    Promise.reject('Async Promise Rejection');
+  });
+}
+
+const button = document.getElementById('button1');
+button.addEventListener('click', async () => {
+  await run();
+});
diff --git a/packages/browser-integration-tests/suites/public-api/startSpan/error-async-reject/template.html b/packages/browser-integration-tests/suites/public-api/startSpan/error-async-reject/template.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+    <title></title>
+  </head>
+  <body>
+    <button id="button1" type="button">Button 1</button>
+  </body>
+</html>
diff --git a/packages/browser-integration-tests/suites/public-api/startSpan/error-async-reject/test.ts b/packages/browser-integration-tests/suites/public-api/startSpan/error-async-reject/test.ts
@@ -0,0 +1,28 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getMultipleSentryEnvelopeRequests, shouldSkipTracingTest } from '../../../../utils/helpers';
+
+sentryTest(
+  'should capture a promise rejection within an async startSpan callback',
+  async ({ getLocalTestPath, page }) => {
+    if (shouldSkipTracingTest()) {
+      sentryTest.skip();
+    }
+
+    const url = await getLocalTestPath({ testDir: __dirname });
+    const envelopePromise = getMultipleSentryEnvelopeRequests<Event>(page, 2);
+
+    const gotoPromise = page.goto(url);
+    const clickPromise = page.getByText('Button 1').click();
+
+    const [_, events] = await Promise.all([gotoPromise, envelopePromise, clickPromise]);
+
+    const [txn, err] = events[0]?.type === 'transaction' ? [events[0], events[1]] : [events[1], events[0]];
+
+    expect(txn).toMatchObject({ transaction: 'parent_span' });
+
+    expect(err?.exception?.values?.[0]?.value).toBe('[object Promise]');
+  },
+);
diff --git a/packages/browser-integration-tests/suites/public-api/startSpan/error-async-throw/subject.js b/packages/browser-integration-tests/suites/public-api/startSpan/error-async-throw/subject.js
@@ -0,0 +1,10 @@
+async function run() {
+  await Sentry.startSpan({ name: 'parent_span' }, async () => {
+    throw new Error('Async Thrown Error');
+  });
+}
+
+const button = document.getElementById('button1');
+button.addEventListener('click', async () => {
+  await run();
+});
diff --git a/packages/browser-integration-tests/suites/public-api/startSpan/error-async-throw/template.html b/packages/browser-integration-tests/suites/public-api/startSpan/error-async-throw/template.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+    <title></title>
+  </head>
+  <body>
+    <button id="button1" type="button">Button 1</button>
+  </body>
+</html>
diff --git a/packages/browser-integration-tests/suites/public-api/startSpan/error-async-throw/test.ts b/packages/browser-integration-tests/suites/public-api/startSpan/error-async-throw/test.ts
@@ -0,0 +1,32 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getMultipleSentryEnvelopeRequests, shouldSkipTracingTest } from '../../../../utils/helpers';
+
+sentryTest('should capture a thrown error within an async startSpan callback', async ({ getLocalTestPath, page }) => {
+  if (shouldSkipTracingTest()) {
+    sentryTest.skip();
+  }
+
+  page.on('pageerror', err => console.log('pageerror', err));
+  page.on('console', msg => console.log('console', msg.text()));
+
+  const url = await getLocalTestPath({ testDir: __dirname });
+  const envelopePromise = getMultipleSentryEnvelopeRequests<Event>(page, 2);
+
+  const gotoPromise = page.goto(url);
+  const clickPromise = page.getByText('Button 1').click();
+
+  console.log('before wait');
+
+  const [_, events] = await Promise.all([gotoPromise, envelopePromise, clickPromise]);
+
+  console.log('after wait');
+
+  const [txn, err] = events[0]?.type === 'transaction' ? [events[0], events[1]] : [events[1], events[0]];
+
+  expect(txn).toMatchObject({ transaction: 'parent_span' });
+
+  expect(err?.exception?.values?.[0]?.value).toBe('[object Promise]');
+});
diff --git a/packages/browser-integration-tests/suites/public-api/startSpan/error-sync/subject.js b/packages/browser-integration-tests/suites/public-api/startSpan/error-sync/subject.js
@@ -0,0 +1,9 @@
+function run() {
+  Sentry.startSpan({ name: 'parent_span' }, () => {
+    throw new Error('Sync Error');
+  });
+}
+
+// using `setTimeout` here because otherwise the thrown error will be
+// thrown as a generic "Script Error." instead of the actual error".
+setTimeout(run);
diff --git a/packages/browser-integration-tests/suites/public-api/startSpan/error-sync/test.ts b/packages/browser-integration-tests/suites/public-api/startSpan/error-sync/test.ts
@@ -0,0 +1,22 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { getMultipleSentryEnvelopeRequests, shouldSkipTracingTest } from '../../../../utils/helpers';
+
+sentryTest('should capture an error within a sync startSpan callback', async ({ getLocalTestPath, page }) => {
+  if (shouldSkipTracingTest()) {
+    sentryTest.skip();
+  }
+
+  const url = await getLocalTestPath({ testDir: __dirname });
+  const gotoPromise = page.goto(url);
+  const envelopePromise = getMultipleSentryEnvelopeRequests<Event>(page, 2);
+
+  const [_, events] = await Promise.all([gotoPromise, envelopePromise]);
+
+  const [txn, err] = events[0]?.type === 'transaction' ? [events[0], events[1]] : [events[1], events[0]];
+
+  expect(txn).toMatchObject({ transaction: 'parent_span' });
+  expect(err?.exception?.values?.[0]?.value).toBe('Sync Error');
+});
diff --git a/packages/browser-integration-tests/suites/public-api/startSpan/init.js b/packages/browser-integration-tests/suites/public-api/startSpan/init.js
@@ -0,0 +1,12 @@
+import * as Sentry from '@sentry/browser';
+// eslint-disable-next-line no-unused-vars
+import * as _ from '@sentry/tracing';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+  tracesSampleRate: 1.0,
+  normalizeDepth: 10,
+  debug: true,
+});
