refactor(ember): Use @embroider/macros instead of runInDebug for @sentry/ember (#2873)

* Use @embroider/macros instead of runInDebug for @sentry/ember

This ensures that the debug code is actually stripped from production builds.

Author: mydea

packages/ember/addon/index.ts

@@ -1,9 +1,9 @@
 import * as Sentry from '@sentry/browser';
 import { addGlobalEventProcessor, SDK_VERSION, BrowserOptions } from '@sentry/browser';
 import environmentConfig from 'ember-get-config';
-
+import { macroCondition, isDevelopingApp } from '@embroider/macros';
 import { next } from '@ember/runloop';
-import { assert, warn, runInDebug } from '@ember/debug';
+import { assert, warn } from '@ember/debug';
 import Ember from 'ember';
 import { timestampWithMs } from '@sentry/utils';
 
@@ -22,7 +22,7 @@ export function InitSentryForEmber(_runtimeConfig: BrowserOptions | undefined) {
 
   Sentry.init(initConfig);
 
-  runInDebug(() => {
+  if (macroCondition(isDevelopingApp())) {
     if (config.ignoreEmberOnErrorWarning) {
       return;
     }
@@ -35,7 +35,7 @@ export function InitSentryForEmber(_runtimeConfig: BrowserOptions | undefined) {
         },
       );
     });
-  });
+  }
 }
 
 export const getActiveTransaction = () => {

packages/ember/addon/instance-initializers/sentry-performance.ts

@@ -7,14 +7,15 @@ import { Span, Transaction, Integration } from '@sentry/types';
 import { EmberRunQueues } from '@ember/runloop/-private/types';
 import { getActiveTransaction } from '..';
 import { timestampWithMs } from '@sentry/utils';
+import { macroCondition, isTesting } from '@embroider/macros';
 
 export function initialize(appInstance: ApplicationInstance): void {
   const config = environmentConfig['@sentry/ember'];
   if (config['disablePerformance']) {
     return;
   }
   const performancePromise = instrumentForPerformance(appInstance);
-  if (Ember.testing) {
+  if (macroCondition(isTesting())) {
     (<any>window)._sentryPerformanceLoad = performancePromise;
   }
 }
@@ -42,7 +43,7 @@ export function _instrumentEmberRouter(
 
   const url = location && location.getURL && location.getURL();
 
-  if (Ember.testing) {
+  if (macroCondition(isTesting())) {
     routerService._sentryInstrumented = true;
     routerService._startTransaction = startTransaction;
   }
@@ -329,7 +330,7 @@ export async function instrumentForPerformance(appInstance: ApplicationInstance)
     }),
   ];
 
-  if (Ember.testing && Sentry.getCurrentHub()?.getIntegration(tracing.Integrations.BrowserTracing)) {
+  if (isTesting() && Sentry.getCurrentHub()?.getIntegration(tracing.Integrations.BrowserTracing)) {
     // Initializers are called more than once in tests, causing the integrations to not be setup correctly.
     return;
   }

packages/ember/package.json

@@ -31,6 +31,7 @@
     "pack": "npm pack"
   },
   "dependencies": {
+    "@embroider/macros": ">=0.25.0",
     "@sentry/browser": "5.25.0",
     "@sentry/tracing": "5.25.0",
     "@sentry/types": "5.25.0",