Skip to content

Commit 90a6fd1

Browse files
committed
remove unused eslint-disable directives
1 parent 7d4f791 commit 90a6fd1

33 files changed

+3
-117
lines changed

dev-packages/e2e-tests/prepare.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable max-lines */
21
/* eslint-disable no-console */
32
import * as dotenv from 'dotenv';
43

dev-packages/e2e-tests/publish-packages.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable no-console */
21
import * as childProcess from 'child_process';
32
import * as path from 'path';
43
import * as glob from 'glob';

dev-packages/e2e-tests/run.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable max-lines */
21
/* eslint-disable no-console */
32
import { spawn } from 'child_process';
43
import { resolve } from 'path';

packages/bun/src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ export { bunServerIntegration } from './integrations/bunserver';
125125
const INTEGRATIONS = {
126126
// eslint-disable-next-line deprecation/deprecation
127127
...CoreIntegrations,
128-
// eslint-disable-next-line deprecation/deprecation
129128
...NodeIntegrations,
130129
BunServer,
131130
};

packages/core/src/baseclient.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
150150
/**
151151
* @inheritDoc
152152
*/
153-
// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
153+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
154154
public captureException(exception: any, hint?: EventHint, scope?: Scope): string | undefined {
155155
// ensure we haven't captured this very object before
156156
if (checkOrSetAlreadyCaught(exception)) {
@@ -857,7 +857,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
857857
/**
858858
* @inheritDoc
859859
*/
860-
// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
860+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
861861
public abstract eventFromException(_exception: any, _hint?: EventHint): PromiseLike<Event>;
862862

863863
/**

packages/core/src/integrations/inboundfilters.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ function _getPossibleEventMessages(event: Event): string[] {
173173
let lastException;
174174
try {
175175
// @ts-expect-error Try catching to save bundle size
176-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
177176
lastException = event.exception.values[event.exception.values.length - 1];
178177
} catch (e) {
179178
// try catching to save bundle size checking existence of variables
@@ -198,7 +197,6 @@ function _getPossibleEventMessages(event: Event): string[] {
198197
function _isSentryError(event: Event): boolean {
199198
try {
200199
// @ts-expect-error can't be a sentry error if undefined
201-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
202200
return event.exception.values[0].type === 'SentryError';
203201
} catch (e) {
204202
// ignore

packages/core/src/tracing/hubextensions.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ function _startTransaction(
5757
The transaction will not be sampled. Please use the ${configInstrumenter} instrumentation to start transactions.`,
5858
);
5959

60-
// eslint-disable-next-line deprecation/deprecation
6160
transactionContext.sampled = false;
6261
}
6362

packages/core/src/tracing/idletransaction.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable max-lines */
21
import type { Hub, SpanTimeInput, TransactionContext } from '@sentry/types';
32
import { logger, timestampInSeconds } from '@sentry/utils';
43

packages/core/src/tracing/sampling.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ export function sampleTransaction<T extends Transaction>(
105105
*/
106106
function isValidSampleRate(rate: unknown): boolean {
107107
// we need to check NaN explicitly because it's of type 'number' and therefore wouldn't get caught by this typecheck
108-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
109108
if (isNaN(rate) || !(typeof rate === 'number' || typeof rate === 'boolean')) {
110109
DEBUG_BUILD &&
111110
logger.warn(

packages/core/src/tracing/transaction.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ export class Transaction extends SentrySpan implements TransactionInterface {
8989
}
9090

9191
// This sadly conflicts with the getter/setter ordering :(
92-
/* eslint-disable @typescript-eslint/member-ordering */
9392

9493
/**
9594
* Get the metadata for this transaction.

packages/core/test/lib/api.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable deprecation/deprecation */
21
import type { ClientOptions, DsnComponents } from '@sentry/types';
32
import { makeDsn } from '@sentry/utils';
43

packages/core/test/lib/session.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable deprecation/deprecation */
2-
31
import type { SessionContext } from '@sentry/types';
42
import { timestampInSeconds } from '@sentry/utils';
53

packages/core/test/lib/sessionflusher.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable deprecation/deprecation */
2-
31
import type { Client } from '@sentry/types';
42

53
import { SessionFlusher } from '../../src/sessionflusher';

packages/core/test/lib/tracing/span.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { TRACE_FLAG_NONE, TRACE_FLAG_SAMPLED, spanToJSON } from '../../../src/ut
44

55
describe('span', () => {
66
describe('name', () => {
7-
/* eslint-disable deprecation/deprecation */
87
it('works with name', () => {
98
const span = new SentrySpan({ name: 'span name' });
109
expect(spanToJSON(span).description).toEqual('span name');

packages/core/test/mocks/client.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,11 @@ export class TestClient extends BaseClient<TestClientOptions> {
4949
TestClient.instance = this;
5050
}
5151

52-
// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
5352
public eventFromException(exception: any): PromiseLike<Event> {
5453
const event: Event = {
5554
exception: {
5655
values: [
5756
{
58-
/* eslint-disable @typescript-eslint/no-unsafe-member-access */
5957
type: exception.name,
6058
value: exception.message,
6159
/* eslint-enable @typescript-eslint/no-unsafe-member-access */
@@ -86,7 +84,6 @@ export class TestClient extends BaseClient<TestClientOptions> {
8684
super.sendEvent(event, hint);
8785
return;
8886
}
89-
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
9087
TestClient.sendEventCalled && TestClient.sendEventCalled(event);
9188
}
9289

packages/feedback/test/utils/TestClient.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ export class TestClient extends BaseClient<TestClientOptions> {
1414
exception: {
1515
values: [
1616
{
17-
/* eslint-disable @typescript-eslint/no-unsafe-member-access */
1817
type: exception.name,
1918
value: exception.message,
2019
/* eslint-enable @typescript-eslint/no-unsafe-member-access */

packages/profiling-node/src/cpu_profiler.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ export function importCppBindingsModule(): PrivateV8CpuProfilerBindings {
3434
return require(`${binaryPath}.node`);
3535
}
3636

37-
/* eslint-disable no-fallthrough */
3837
// We need the fallthrough so that in the end, we can fallback to the require dynamice require.
3938
// This is for cases where precompiled binaries were not provided, but may have been compiled from source.
4039
if (platform === 'darwin') {

packages/profiling-node/src/integration.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ export class ProfilingIntegration implements Integration {
5656
*/
5757
public setupOnce(addGlobalEventProcessor: (callback: EventProcessor) => void, getCurrentHub: () => Hub): void {
5858
this.getCurrentHub = getCurrentHub;
59-
// eslint-disable-next-line deprecation/deprecation
6059
const client = this.getCurrentHub().getClient() as NodeClient;
6160

6261
if (client && typeof client.on === 'function') {
@@ -137,7 +136,6 @@ export class ProfilingIntegration implements Integration {
137136

138137
// Remove the profile from the transaction context before sending, relay will take care of the rest.
139138
if (profileContext) {
140-
// eslint-disable-next-line @typescript-eslint/no-dynamic-delete
141139
delete profiledTransaction.contexts?.['profile'];
142140
}
143141

@@ -199,7 +197,6 @@ export class ProfilingIntegration implements Integration {
199197
// and forward it to the next event processor.
200198
const hub = this.getCurrentHub();
201199

202-
// eslint-disable-next-line deprecation/deprecation
203200
const client = hub.getClient();
204201

205202
if (!client) {

packages/profiling-node/src/utils.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import type { DebugImage } from './types';
2626

2727
// We require the file because if we import it, it will be included in the bundle.
2828
// I guess tsc does not check file contents when it's imported.
29-
// eslint-disable-next-line
3029
const THREAD_ID_STRING = String(threadId);
3130
const THREAD_NAME = isMainThread ? 'main' : 'worker';
3231
const FORMAT_VERSION = '1';
@@ -454,9 +453,7 @@ export function applyDebugMetadata(resource_paths: ReadonlyArray<string>): Debug
454453
return [];
455454
}
456455

457-
// eslint-disable-next-line deprecation/deprecation
458456
const hub = Sentry.getCurrentHub();
459-
// eslint-disable-next-line deprecation/deprecation
460457
const client = hub.getClient();
461458
const options = client && client.getOptions();
462459

0 commit comments

Comments
 (0)