Skip to content

Commit 90ddce8

Browse files
committed
wip - add ci matrix entries
1 parent b539b36 commit 90ddce8

File tree

3 files changed

+35
-6
lines changed

3 files changed

+35
-6
lines changed

.github/workflows/build.yml

Lines changed: 27 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,10 @@ jobs:
138138
is_develop: ${{ github.ref == 'refs/heads/develop' }}
139139
is_release: ${{ startsWith(github.ref, 'refs/heads/release/') }}
140140
is_gitflow_sync: ${{ github.head_ref == 'refs/heads/develop' || github.head_ref == 'refs/heads/master' }}
141-
has_gitflow_label: ${{ github.event_name == 'pull_request' && contains(steps.pr-labels.outputs.labels, ' Gitflow ') }}
142-
force_skip_cache: ${{ github.event_name == 'pull_request' && contains(steps.pr-labels.outputs.labels, ' ci-skip-cache ') }}
141+
has_gitflow_label:
142+
${{ github.event_name == 'pull_request' && contains(steps.pr-labels.outputs.labels, ' Gitflow ') }}
143+
force_skip_cache:
144+
${{ github.event_name == 'pull_request' && contains(steps.pr-labels.outputs.labels, ' ci-skip-cache ') }}
143145

144146
job_install_deps:
145147
name: Install Dependencies
@@ -172,7 +174,8 @@ jobs:
172174
key: ${{ steps.compute_lockfile_hash.outputs.hash }}
173175

174176
- name: Install dependencies
175-
if: steps.cache_dependencies.outputs.cache-hit == '' || needs.job_get_metadata.outputs.force_skip_cache == 'true'
177+
if:
178+
steps.cache_dependencies.outputs.cache-hit == '' || needs.job_get_metadata.outputs.force_skip_cache == 'true'
176179
run: yarn install --ignore-engines --frozen-lockfile
177180
outputs:
178181
dependency_cache_key: ${{ steps.compute_lockfile_hash.outputs.hash }}
@@ -215,7 +218,8 @@ jobs:
215218
path: node_modules/.cache/nx
216219
key: nx-Linux-${{ github.ref }}-${{ env.HEAD_COMMIT }}
217220
# On develop branch, we want to _store_ the cache (so it can be used by other branches), but never _restore_ from it
218-
restore-keys: ${{needs.job_get_metadata.outputs.is_develop == 'false' && env.NX_CACHE_RESTORE_KEYS || 'nx-never-restore'}}
221+
restore-keys:
222+
${{needs.job_get_metadata.outputs.is_develop == 'false' && env.NX_CACHE_RESTORE_KEYS || 'nx-never-restore'}}
219223

220224
- name: Build packages
221225
# Under normal circumstances, using the git SHA as a cache key, there shouldn't ever be a cache hit on the built
@@ -532,16 +536,31 @@ jobs:
532536
- bundle_es5_min
533537
- bundle_es6
534538
- bundle_es6_min
539+
- bundle_replay_es6
540+
- bundle_replay_es6_min
535541
tracing_only:
536542
- true
537543
- false
544+
replay:
545+
- true
546+
- false
538547
exclude:
539548
# `tracing_only` only makes a difference for bundles - tests of the esm and cjs builds always include the
540549
# tracing tests
541550
- bundle: esm
542551
tracing_only: false
543552
- bundle: cjs
544553
tracing_only: false
554+
# `replay` only makes a difference for bundles - tests of the esm and cjs builds always include replay
555+
- bundle: esm
556+
replay: false
557+
- bundle: cjs
558+
replay: false
559+
# Replay is es6-only, so we can't and don't need to test agains ES5 bundles.
560+
- bundle: bundle_es5
561+
replay: true
562+
- bundle: bundle_es5_min
563+
replay: true
545564
steps:
546565
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
547566
uses: actions/checkout@v3
@@ -583,6 +602,7 @@ jobs:
583602
env:
584603
PW_BUNDLE: ${{ matrix.bundle }}
585604
PW_TRACING_ONLY: ${{ matrix.tracing_only }}
605+
PW_REPLAY: ${{ matrix.replay }}
586606
run: |
587607
cd packages/integration-tests
588608
yarn test:ci
@@ -798,7 +818,9 @@ jobs:
798818
needs: [job_get_metadata, job_build]
799819
runs-on: ubuntu-20.04
800820
timeout-minutes: 30
801-
if: contains(github.event.pull_request.labels.*.name, 'ci-overhead-measurements') || needs.job_get_metadata.outputs.is_develop == 'true'
821+
if:
822+
contains(github.event.pull_request.labels.*.name, 'ci-overhead-measurements') ||
823+
needs.job_get_metadata.outputs.is_develop == 'true'
802824
steps:
803825
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
804826
uses: actions/checkout@v3

packages/integration-tests/utils/generatePlugin.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import type { Compiler } from 'webpack';
77
const PACKAGES_DIR = '../../packages';
88

99
const tracingOnly = process.env.PW_TRACING_ONLY === 'true';
10+
const useReplay = process.env.PW_REPLAY === 'true';
11+
1012
const bundleKey = process.env.PW_BUNDLE;
1113

1214
// `esm` and `cjs` builds are modules that can be imported / aliased by webpack
@@ -23,6 +25,8 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
2325
bundle_es5_min: 'build/bundles/bundle.es5.min.js',
2426
bundle_es6: 'build/bundles/bundle.js',
2527
bundle_es6_min: 'build/bundles/bundle.min.js',
28+
bundle_replay_es6: 'build/bundles/bundle.replay.js',
29+
bundle_replay_es6_min: 'build/bundles/bundle.replay.min.js',
2630
},
2731
tracing: {
2832
cjs: 'build/npm/cjs/index.js',
@@ -31,7 +35,10 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
3135
bundle_es5_min: 'build/bundles/bundle.tracing.es5.min.js',
3236
bundle_es6: 'build/bundles/bundle.tracing.js',
3337
bundle_es6_min: 'build/bundles/bundle.tracing.min.js',
38+
bundle_replay_es6: 'build/bundles/bundle.tracing.replay.js',
39+
bundle_replay_es6_min: 'build/bundles/bundle.tracing.replay.min.js',
3440
},
41+
errorsAndReplay: {},
3542
integrations: {
3643
cjs: 'build/npm/cjs/index.js',
3744
esm: 'build/npm/esm/index.js',

packages/replay/src/worker/worker.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)