Skip to content

Commit 92537b4

Browse files
committed
build: Switch @sentry/ember to using eslint
1 parent dc1e7a7 commit 92537b4

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

.eslintignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# THIS IS A TEMPORARY FILE
22
# THIS WILL BE REMOVED AFTER WE FINISH ESLINT UPGRADE
33

4-
packages/ember/**/*
54
packages/integrations/**/*
65
packages/node/**/*
76
packages/react/**/*

packages/ember/addon/index.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ import { next } from '@ember/runloop';
66
import { assert, warn, runInDebug } from '@ember/debug';
77
import Ember from 'ember';
88

9+
declare module '@ember/debug' {
10+
export function assert(desc: string, test: unknown): void;
11+
}
12+
913
export function InitSentryForEmber(_runtimeConfig: BrowserOptions | undefined) {
1014
const config = environmentConfig['@sentry/ember'];
1115
assert('Missing configuration', config);
@@ -21,7 +25,7 @@ export function InitSentryForEmber(_runtimeConfig: BrowserOptions | undefined) {
2125
if (config.ignoreEmberOnErrorWarning) {
2226
return;
2327
}
24-
next(null, function () {
28+
next(null, function() {
2529
warn(
2630
'Ember.onerror found. Using Ember.onerror can hide some errors (such as flushed runloop errors) from Sentry. Use Sentry.captureException to capture errors within Ember.onError or remove it to have errors caught by Sentry directly. This error can be silenced via addon configuration.',
2731
!Ember.onerror,
@@ -35,7 +39,7 @@ export function InitSentryForEmber(_runtimeConfig: BrowserOptions | undefined) {
3539

3640
function createEmberEventProcessor(): void {
3741
if (addGlobalEventProcessor) {
38-
addGlobalEventProcessor((event) => {
42+
addGlobalEventProcessor(event => {
3943
event.sdk = {
4044
...event.sdk,
4145
name: 'sentry.javascript.ember',

packages/ember/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"build": "ember build --environment=production",
1818
"lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*",
1919
"lint:hbs": "ember-template-lint .",
20-
"lint:js": "eslint .",
20+
"lint:js": "eslint . --cache --cache-location '../../eslintcache/'",
2121
"start": "ember serve",
2222
"test": "npm-run-all lint:* test:*",
2323
"test:ember": "ember test",

0 commit comments

Comments
 (0)