Skip to content

Commit 9316b99

Browse files
committed
build: Remove @sentry-internal/sdk/no-async-await rule
1 parent 38f49ca commit 9316b99

File tree

13 files changed

+0
-137
lines changed

13 files changed

+0
-137
lines changed

packages/eslint-config-sdk/src/index.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,6 @@ module.exports = {
143143
},
144144
],
145145

146-
// We want to prevent async await usage in our files to prevent uncessary bundle size. Turned off in tests.
147-
'@sentry-internal/sdk/no-async-await': 'error',
148-
149146
// JSDOC comments are required for classes and methods. As we have a public facing codebase, documentation,
150147
// even if it may seems excessive at times, is important to emphasize. Turned off in tests.
151148
'jsdoc/require-jsdoc': [
@@ -177,7 +174,6 @@ module.exports = {
177174
'@typescript-eslint/no-explicit-any': 'off',
178175
'@typescript-eslint/no-non-null-assertion': 'off',
179176
'@typescript-eslint/no-empty-function': 'off',
180-
'@sentry-internal/sdk/no-async-await': 'off',
181177
},
182178
},
183179
{

packages/eslint-plugin-sdk/src/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
module.exports = {
1212
rules: {
13-
'no-async-await': require('./rules/no-async-await'),
1413
'no-eq-empty': require('./rules/no-eq-empty'),
1514
},
1615
};

packages/eslint-plugin-sdk/src/rules/no-async-await.js

Lines changed: 0 additions & 57 deletions
This file was deleted.

packages/eslint-plugin-sdk/test/lib/rules/no-async-await.js

Lines changed: 0 additions & 50 deletions
This file was deleted.

packages/nextjs/.eslintrc.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ module.exports = {
88
},
99
ignorePatterns: ['test/integration/**'],
1010
extends: ['../../.eslintrc.js'],
11-
rules: {
12-
'@sentry-internal/sdk/no-async-await': 'off',
13-
},
1411
overrides: [
1512
{
1613
files: ['scripts/**/*.ts'],

packages/node/.eslintrc.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,4 @@ module.exports = {
33
node: true,
44
},
55
extends: ['../../.eslintrc.js'],
6-
rules: {
7-
'@sentry-internal/sdk/no-async-await': 'off',
8-
},
96
};

packages/opentelemetry-node/.eslintrc.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,4 @@ module.exports = {
33
node: true,
44
},
55
extends: ['../../.eslintrc.js'],
6-
rules: {
7-
'@sentry-internal/sdk/no-async-await': 'off',
8-
},
96
};

packages/remix/.eslintrc.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ module.exports = {
88
},
99
ignorePatterns: ['playwright.config.ts', 'test/integration/**'],
1010
extends: ['../../.eslintrc.js'],
11-
rules: {
12-
'@sentry-internal/sdk/no-async-await': 'off',
13-
},
1411
overrides: [
1512
{
1613
files: ['scripts/**/*.ts'],

packages/replay/.eslintrc.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,6 @@ module.exports = {
2020
sourceType: 'module',
2121
},
2222
},
23-
{
24-
files: ['*.ts', '*.tsx', '*.d.ts'],
25-
rules: {
26-
// Since we target only es6 here, we can leave this off
27-
'@sentry-internal/sdk/no-async-await': 'off',
28-
},
29-
},
3023
{
3124
files: ['jest.setup.ts', 'jest.config.ts'],
3225
parserOptions: {

packages/serverless/.eslintrc.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@ module.exports = {
33
node: true,
44
},
55
extends: ['../../.eslintrc.js'],
6-
rules: {
7-
'@sentry-internal/sdk/no-async-await': 'off',
8-
},
96
overrides: [
107
{
118
files: ['scripts/**/*.ts'],

packages/utils/src/buildPolyfills/_asyncNullishCoalesce.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import { _nullishCoalesce } from './_nullishCoalesce';
1515
* @param rhsFn A function returning the value of the expression to the right of the `??`
1616
* @returns The LHS value, unless it's `null` or `undefined`, in which case, the RHS value
1717
*/
18-
// eslint-disable-next-line @sentry-internal/sdk/no-async-await
1918
export async function _asyncNullishCoalesce(lhs: unknown, rhsFn: () => unknown): Promise<unknown> {
2019
return _nullishCoalesce(lhs, rhsFn);
2120
}

packages/utils/src/buildPolyfills/_asyncOptionalChain.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import type { GenericFunction } from './types';
1010
* @param ops Array result of expression conversion
1111
* @returns The value of the expression
1212
*/
13-
// eslint-disable-next-line @sentry-internal/sdk/no-async-await
1413
export async function _asyncOptionalChain(ops: unknown[]): Promise<unknown> {
1514
let lastAccessLHS: unknown = undefined;
1615
let value = ops[0];

packages/utils/src/buildPolyfills/_asyncOptionalChainDelete.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { _asyncOptionalChain } from './_asyncOptionalChain';
1212
* property (one which can't be deleted or turned into an accessor, and whose enumerability can't be changed), in which
1313
* case `false`.
1414
*/
15-
// eslint-disable-next-line @sentry-internal/sdk/no-async-await
1615
export async function _asyncOptionalChainDelete(ops: unknown[]): Promise<boolean> {
1716
const result = (await _asyncOptionalChain(ops)) as Promise<boolean | null>;
1817
// If `result` is `null`, it means we didn't get to the end of the chain and so nothing was deleted (in which case,

0 commit comments

Comments
 (0)