fix test?

Author: mydea

packages/integration-tests/suites/replay/sessionExpiry/test.ts

@@ -15,7 +15,7 @@ import {
 // Session should expire after 2s - keep in sync with init.js
 const SESSION_TIMEOUT = 2000;
 
-for (let i = 0; i < 100; i++) {
+for (let i = 0; i < 1; i++) {
   sentryTest(`handles an expired session RUN ${i}`, async ({ getLocalTestPath, page }) => {
     if (shouldSkipReplayTest()) {
       sentryTest.skip();

packages/integration-tests/suites/replay/sessionMaxAge/test.ts

@@ -19,7 +19,7 @@ const SESSION_MAX_AGE = 4000;
   The main difference between this and sessionExpiry test, is that here we wait for the overall time (4s)
   in multiple steps (2s, 2s) instead of waiting for the whole time at once (4s).
 */
-for (let i = 0; i < 1; i++) {
+for (let i = 0; i < 100; i++) {
   sentryTest(`handles session that exceeds max age RUN ${i}`, async ({ getLocalTestPath, page }) => {
     if (shouldSkipReplayTest()) {
       sentryTest.skip();
@@ -39,8 +39,13 @@ for (let i = 0; i < 1; i++) {
     const url = await getLocalTestPath({ testDir: __dirname });
 
     await page.goto(url);
+
+    const replay0 = await getReplaySnapshot(page);
+    // We use the `initialTimestamp` of the replay to do any time based calculations
+    // @ts-ignore this is fine
+    const startTimestamp = replay0._context.initialTimestamp;
+
     const req0 = await reqPromise0;
-    const startTimestamp = Date.now();
 
     const replayEvent0 = getReplayEvent(req0);
     expect(replayEvent0).toEqual(getExpectedReplayEvent({}));
@@ -54,6 +59,9 @@ for (let i = 0; i < 1; i++) {
     const reqPromise2 = waitForReplayRequest(page, 0);
 
     // Wait for an incremental snapshot
+    // Wait half of the session max age (after initial flush), but account for potentially slow runners
+    const timePassed1 = Date.now() - startTimestamp;
+    await new Promise(resolve => setTimeout(resolve, Math.max(SESSION_MAX_AGE / 2 - timePassed1, 0)));
     await page.click('#button1');
 
     const req1 = await reqPromise1;
@@ -86,11 +94,12 @@ for (let i = 0; i < 1; i++) {
       ]),
     );
 
-    const replay = await getReplaySnapshot(page);
-    const oldSessionId = replay.session?.id;
+    const replay1 = await getReplaySnapshot(page);
+    const oldSessionId = replay1.session?.id;
 
     // Wait for session to expire
-    await new Promise(resolve => setTimeout(resolve, SESSION_MAX_AGE - (Date.now() - startTimestamp)));
+    const timePassed2 = Date.now() - startTimestamp;
+    await new Promise(resolve => setTimeout(resolve, Math.max(SESSION_MAX_AGE - timePassed2, 0)));
     await page.click('#button2');
 
     const req2 = await reqPromise2;