Change _attachmentsFromScope return type

Author: timfish

packages/core/src/baseclient.ts

@@ -664,8 +664,8 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
   /**
    * Loads attachment items from scope
    */
-  protected _attachmentsFromScope(scope: Scope | undefined): AttachmentItem[] | undefined {
-    return scope?.getAttachments()?.map(a => createAttachmentEnvelopeItem(a));
+  protected _attachmentsFromScope(scope: Scope | undefined): AttachmentItem[] {
+    return scope?.getAttachments()?.map(a => createAttachmentEnvelopeItem(a)) || [];
   }
 
   /**

packages/node/src/client.ts

@@ -155,17 +155,19 @@ export class NodeClient extends BaseClient<NodeClientOptions> {
   /**
    * @inheritDoc
    */
-  protected _attachmentsFromScope(scope: Scope | undefined): AttachmentItem[] | undefined {
-    return scope?.getAttachments()?.map(attachment => {
-      let [pathOrData, options] = attachment;
-
-      if (typeof pathOrData === 'string' && existsSync(pathOrData)) {
-        options = options || {};
-        options.filename = basename(pathOrData);
-        pathOrData = readFileSync(pathOrData);
-      }
+  protected _attachmentsFromScope(scope: Scope | undefined): AttachmentItem[] {
+    return (
+      scope?.getAttachments()?.map(attachment => {
+        let [pathOrData, options] = attachment;
+
+        if (typeof pathOrData === 'string' && existsSync(pathOrData)) {
+          options = options || {};
+          options.filename = basename(pathOrData);
+          pathOrData = readFileSync(pathOrData);
+        }
 
-      return createAttachmentEnvelopeItem([pathOrData, options]);
-    });
+        return createAttachmentEnvelopeItem([pathOrData, options]);
+      }) || []
+    );
   }
 }