Skip to content

Commit 96a0c5d

Browse files
committed
Use @embroider/macros instead of runInDebug for @sentry/ember
This ensures that the debug code is actually stripped from production builds.
1 parent def5490 commit 96a0c5d

File tree

3 files changed

+229
-9
lines changed

3 files changed

+229
-9
lines changed

packages/ember/addon/index.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import * as Sentry from '@sentry/browser';
22
import { addGlobalEventProcessor, SDK_VERSION, BrowserOptions } from '@sentry/browser';
33
import environmentConfig from 'ember-get-config';
4-
4+
import { macroCondition, isDevelopingApp } from '@embroider/macros';
55
import { next } from '@ember/runloop';
6-
import { assert, warn, runInDebug } from '@ember/debug';
6+
import { assert, warn } from '@ember/debug';
77
import Ember from 'ember';
88

99
declare module '@ember/debug' {
@@ -21,7 +21,7 @@ export function InitSentryForEmber(_runtimeConfig: BrowserOptions | undefined) {
2121

2222
Sentry.init(initConfig);
2323

24-
runInDebug(() => {
24+
if (macroCondition(isDevelopingApp())) {
2525
if (config.ignoreEmberOnErrorWarning) {
2626
return;
2727
}
@@ -34,7 +34,7 @@ export function InitSentryForEmber(_runtimeConfig: BrowserOptions | undefined) {
3434
},
3535
);
3636
});
37-
});
37+
}
3838
}
3939

4040
function createEmberEventProcessor(): void {

packages/ember/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,11 @@
3030
"pack": "npm pack"
3131
},
3232
"dependencies": {
33+
"@embroider/macros": "^0.22.0",
3334
"@sentry/browser": "5.22.3",
3435
"@sentry/types": "5.22.3",
3536
"@sentry/utils": "5.22.3",
37+
"@types/babel__core": "^7.1.9",
3638
"ember-auto-import": "^1.6.0",
3739
"ember-cli-babel": "^7.20.5",
3840
"ember-cli-htmlbars": "^5.1.2",

0 commit comments

Comments
 (0)