Skip to content

Commit 97eec7a

Browse files
mydeamydea
committed
ref(replay): Make idle timeouts configurable & reusable
Also streamline that `SESSION_IDLE_DURATION` and `VISIBILITY_CHANGE_TIMEOUT` are the same thing (which they have already been).
1 parent a88a8bf commit 97eec7a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+3040
-18
lines changed

‎packages/integration-tests/suites/replay/sessionExpiry/init.js

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
import * as Sentry from '@sentry/browser';
2+
3+
window.Sentry = Sentry;
4+
window.Replay = new Sentry.Replay({
5+
flushMinDelay: 500,
6+
flushMaxDelay: 500,
7+
});
8+
9+
Sentry.init({
10+
dsn: 'https://[email protected]/1337',
11+
sampleRate: 0,
12+
replaysSessionSampleRate: 1.0,
13+
replaysOnErrorSampleRate: 0.0,
14+
debug: true,
15+
16+
integrations: [window.Replay],
17+
});
18+
19+
window.Replay._replay.timeouts = {
20+
sessionIdle: 2000, // this is usually 5min, but we want to test this with shorter times
21+
maxSessionLife: 3600000, // default: 60min
22+
};

‎packages/integration-tests/suites/replay/sessionExpiry/template.html

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<!DOCTYPE html>
2+
<html>
3+
<head>
4+
<meta charset="utf-8" />
5+
</head>
6+
<body>
7+
<button onclick="console.log('Test log 1')" id="button1">Click me</button>
8+
<button onclick="console.log('Test log 2')" id="button2">Click me</button>
9+
</body>
10+
</html>

‎packages/integration-tests/suites/replay/sessionExpiry/test.ts

Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
import { expect } from '@playwright/test';
2+
3+
import { sentryTest } from '../../../utils/fixtures';
4+
import { getExpectedReplayEvent } from '../../../utils/replayEventTemplates';
5+
import {
6+
getFullRecordingSnapshots,
7+
getIncrementalRecordingSnapshots,
8+
getReplayEvent,
9+
getReplaySnapshot,
10+
normalize,
11+
shouldSkipReplayTest,
12+
waitForReplayRequest,
13+
} from '../../../utils/replayHelpers';
14+
15+
// Session should expire after 2s - keep in sync with init.js
16+
const SESSION_TIMEOUT = 2000;
17+
18+
sentryTest('handles an expired session', async ({ getLocalTestPath, page }) => {
19+
if (shouldSkipReplayTest()) {
20+
sentryTest.skip();
21+
}
22+
23+
const reqPromise0 = waitForReplayRequest(page, 0);
24+
const reqPromise1 = waitForReplayRequest(page, 1);
25+
26+
await page.route('https://dsn.ingest.sentry.io/**/*', route => {
27+
return route.fulfill({
28+
status: 200,
29+
contentType: 'application/json',
30+
body: JSON.stringify({ id: 'test-id' }),
31+
});
32+
});
33+
34+
const url = await getLocalTestPath({ testDir: __dirname });
35+
36+
await page.goto(url);
37+
38+
const replayEvent0 = getReplayEvent(await reqPromise0);
39+
expect(replayEvent0).toEqual(getExpectedReplayEvent({}));
40+
41+
const fullSnapshots0 = getFullRecordingSnapshots(await reqPromise0);
42+
expect(fullSnapshots0.length).toEqual(1);
43+
const stringifiedSnapshot = normalize(fullSnapshots0[0]);
44+
expect(stringifiedSnapshot).toMatchSnapshot('snapshot-0.json');
45+
46+
// We wait for another segment 0
47+
const reqPromise2 = waitForReplayRequest(page, 0);
48+
49+
await page.click('#button1');
50+
const replayEvent1 = getReplayEvent(await reqPromise1);
51+
expect(replayEvent1).toEqual(getExpectedReplayEvent({ replay_start_timestamp: undefined, segment_id: 1, urls: [] }));
52+
53+
const fullSnapshots1 = getFullRecordingSnapshots(await reqPromise1);
54+
expect(fullSnapshots1.length).toEqual(0);
55+
56+
const incrementalSnapshots1 = getIncrementalRecordingSnapshots(await reqPromise1);
57+
// The number of incremental snapshots depends on the browser
58+
expect(incrementalSnapshots1.length).toBeGreaterThanOrEqual(4);
59+
60+
expect(incrementalSnapshots1).toEqual(
61+
expect.arrayContaining([
62+
{
63+
source: 1,
64+
positions: [
65+
{
66+
id: 9,
67+
timeOffset: expect.any(Number),
68+
x: expect.any(Number),
69+
y: expect.any(Number),
70+
},
71+
],
72+
},
73+
]),
74+
);
75+
76+
const replay = await getReplaySnapshot(page);
77+
const oldSessionId = replay.session?.id;
78+
79+
await new Promise(resolve => setTimeout(resolve, SESSION_TIMEOUT));
80+
81+
await page.click('#button2');
82+
83+
const replay2 = await getReplaySnapshot(page);
84+
85+
expect(replay2.session?.id).not.toEqual(oldSessionId);
86+
87+
const replayEvent2 = getReplayEvent(await reqPromise2);
88+
expect(replayEvent2).toEqual(getExpectedReplayEvent({}));
89+
90+
const fullSnapshots2 = getFullRecordingSnapshots(await reqPromise2);
91+
expect(fullSnapshots2.length).toEqual(1);
92+
const stringifiedSnapshot2 = normalize(fullSnapshots2[0]);
93+
expect(stringifiedSnapshot2).toMatchSnapshot('snapshot-2.json');
94+
});

‎packages/integration-tests/suites/replay/sessionExpiry/test.ts-snapshots/snapshot-0-chromium.json

Lines changed: 109 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,109 @@
1+
{
2+
"node": {
3+
"type": 0,
4+
"childNodes": [
5+
{
6+
"type": 1,
7+
"name": "html",
8+
"publicId": "",
9+
"systemId": "",
10+
"id": 2
11+
},
12+
{
13+
"type": 2,
14+
"tagName": "html",
15+
"attributes": {},
16+
"childNodes": [
17+
{
18+
"type": 2,
19+
"tagName": "head",
20+
"attributes": {},
21+
"childNodes": [
22+
{
23+
"type": 2,
24+
"tagName": "meta",
25+
"attributes": {
26+
"charset": "utf-8"
27+
},
28+
"childNodes": [],
29+
"id": 5
30+
}
31+
],
32+
"id": 4
33+
},
34+
{
35+
"type": 3,
36+
"textContent": "\n ",
37+
"id": 6
38+
},
39+
{
40+
"type": 2,
41+
"tagName": "body",
42+
"attributes": {},
43+
"childNodes": [
44+
{
45+
"type": 3,
46+
"textContent": "\n ",
47+
"id": 8
48+
},
49+
{
50+
"type": 2,
51+
"tagName": "button",
52+
"attributes": {
53+
"onclick": "console.log('Test log 1')",
54+
"id": "button1"
55+
},
56+
"childNodes": [
57+
{
58+
"type": 3,
59+
"textContent": "***** **",
60+
"id": 10
61+
}
62+
],
63+
"id": 9
64+
},
65+
{
66+
"type": 3,
67+
"textContent": "\n ",
68+
"id": 11
69+
},
70+
{
71+
"type": 2,
72+
"tagName": "button",
73+
"attributes": {
74+
"onclick": "console.log('Test log 2')",
75+
"id": "button2"
76+
},
77+
"childNodes": [
78+
{
79+
"type": 3,
80+
"textContent": "***** **",
81+
"id": 13
82+
}
83+
],
84+
"id": 12
85+
},
86+
{
87+
"type": 3,
88+
"textContent": "\n ",
89+
"id": 14
90+
},
91+
{
92+
"type": 3,
93+
"textContent": "\n\n",
94+
"id": 15
95+
}
96+
],
97+
"id": 7
98+
}
99+
],
100+
"id": 3
101+
}
102+
],
103+
"id": 1
104+
},
105+
"initialOffset": {
106+
"left": 0,
107+
"top": 0
108+
}
109+
}

‎packages/integration-tests/suites/replay/sessionExpiry/test.ts-snapshots/snapshot-0-firefox.json

Lines changed: 109 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,109 @@
1+
{
2+
"node": {
3+
"type": 0,
4+
"childNodes": [
5+
{
6+
"type": 1,
7+
"name": "html",
8+
"publicId": "",
9+
"systemId": "",
10+
"id": 2
11+
},
12+
{
13+
"type": 2,
14+
"tagName": "html",
15+
"attributes": {},
16+
"childNodes": [
17+
{
18+
"type": 2,
19+
"tagName": "head",
20+
"attributes": {},
21+
"childNodes": [
22+
{
23+
"type": 2,
24+
"tagName": "meta",
25+
"attributes": {
26+
"charset": "utf-8"
27+
},
28+
"childNodes": [],
29+
"id": 5
30+
}
31+
],
32+
"id": 4
33+
},
34+
{
35+
"type": 3,
36+
"textContent": "\n ",
37+
"id": 6
38+
},
39+
{
40+
"type": 2,
41+
"tagName": "body",
42+
"attributes": {},
43+
"childNodes": [
44+
{
45+
"type": 3,
46+
"textContent": "\n ",
47+
"id": 8
48+
},
49+
{
50+
"type": 2,
51+
"tagName": "button",
52+
"attributes": {
53+
"onclick": "console.log('Test log 1')",
54+
"id": "button1"
55+
},
56+
"childNodes": [
57+
{
58+
"type": 3,
59+
"textContent": "***** **",
60+
"id": 10
61+
}
62+
],
63+
"id": 9
64+
},
65+
{
66+
"type": 3,
67+
"textContent": "\n ",
68+
"id": 11
69+
},
70+
{
71+
"type": 2,
72+
"tagName": "button",
73+
"attributes": {
74+
"onclick": "console.log('Test log 2')",
75+
"id": "button2"
76+
},
77+
"childNodes": [
78+
{
79+
"type": 3,
80+
"textContent": "***** **",
81+
"id": 13
82+
}
83+
],
84+
"id": 12
85+
},
86+
{
87+
"type": 3,
88+
"textContent": "\n ",
89+
"id": 14
90+
},
91+
{
92+
"type": 3,
93+
"textContent": "\n\n",
94+
"id": 15
95+
}
96+
],
97+
"id": 7
98+
}
99+
],
100+
"id": 3
101+
}
102+
],
103+
"id": 1
104+
},
105+
"initialOffset": {
106+
"left": 0,
107+
"top": 0
108+
}
109+
}

0 commit comments

Comments
 (0)