Skip to content

Commit 99efe25

Browse files
mydeamydea
committed
remove unneeded attribute
1 parent 1ef80cd commit 99efe25

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

‎packages/vue/src/router.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ export function vueRouterInstrumentation(
7070
name: WINDOW.location.pathname,
7171
op: 'pageload',
7272
attributes: {
73-
'routing.instrumentation': 'vue-router',
7473
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.vue',
7574
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
7675
},
@@ -116,7 +115,6 @@ export function instrumentVueRouter(
116115

117116
const attributes: SpanAttributes = {
118117
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.vue',
119-
'routing.instrumentation': 'vue-router',
120118
};
121119

122120
for (const key of Object.keys(to.params)) {

‎packages/vue/test/router.test.ts

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as SentryBrowser from '@sentry/browser';
22
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE } from '@sentry/core';
33
import type { SpanAttributes, Transaction } from '@sentry/types';
44

5-
import type { Route} from '../src/router';
5+
import type { Route } from '../src/router';
66
import { instrumentVueRouter, vueRouterInstrumentation } from '../src/router';
77
import * as vueTracing from '../src/tracing';
88

@@ -104,7 +104,6 @@ describe('vueRouterInstrumentation()', () => {
104104
expect(mockStartTransaction).toHaveBeenCalledWith({
105105
name: transactionName,
106106
attributes: {
107-
'routing.instrumentation': 'vue-router',
108107
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.vue',
109108
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: transactionSource,
110109
...getAttributesForRoute(to),
@@ -146,7 +145,6 @@ describe('vueRouterInstrumentation()', () => {
146145
expect(customMockStartTxn).toHaveBeenCalledWith({
147146
name: '/',
148147
attributes: {
149-
'routing.instrumentation': 'vue-router',
150148
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.vue',
151149
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
152150
},
@@ -165,7 +163,6 @@ describe('vueRouterInstrumentation()', () => {
165163
expect(mockedTxn.setAttribute).toHaveBeenCalledWith(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, transactionSource);
166164
expect(mockedTxn.setAttributes).toHaveBeenCalledWith({
167165
...getAttributesForRoute(to),
168-
'routing.instrumentation': 'vue-router',
169166
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.vue',
170167
});
171168

@@ -191,7 +188,6 @@ describe('vueRouterInstrumentation()', () => {
191188
expect(mockStartTransaction).toHaveBeenLastCalledWith({
192189
name: '/login',
193190
attributes: {
194-
'routing.instrumentation': 'vue-router',
195191
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
196192
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.vue',
197193
...getAttributesForRoute(to),
@@ -218,7 +214,6 @@ describe('vueRouterInstrumentation()', () => {
218214
expect(mockStartTransaction).toHaveBeenLastCalledWith({
219215
name: 'login-screen',
220216
attributes: {
221-
'routing.instrumentation': 'vue-router',
222217
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'custom',
223218
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.vue',
224219
...getAttributesForRoute(to),
@@ -256,7 +251,6 @@ describe('vueRouterInstrumentation()', () => {
256251
expect(customMockStartTxn).toHaveBeenCalledWith({
257252
name: '/',
258253
attributes: {
259-
'routing.instrumentation': 'vue-router',
260254
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
261255
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.vue',
262256
},
@@ -283,7 +277,6 @@ describe('vueRouterInstrumentation()', () => {
283277
expect(mockedTxn.updateName).not.toHaveBeenCalled();
284278
expect(mockedTxn.setAttribute).not.toHaveBeenCalled();
285279
expect(mockedTxn.setAttributes).toHaveBeenCalledWith({
286-
'routing.instrumentation': 'vue-router',
287280
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.vue',
288281
...getAttributesForRoute(to),
289282
});
@@ -349,7 +342,6 @@ describe('vueRouterInstrumentation()', () => {
349342
expect(mockStartTransaction).toHaveBeenLastCalledWith({
350343
name: '/login',
351344
attributes: {
352-
'routing.instrumentation': 'vue-router',
353345
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
354346
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.vue',
355347
...getAttributesForRoute(to),
@@ -411,7 +403,6 @@ describe('instrumentVueRouter()', () => {
411403
expect(mockStartSpan).toHaveBeenCalledWith({
412404
name: transactionName,
413405
attributes: {
414-
'routing.instrumentation': 'vue-router',
415406
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.vue',
416407
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: transactionSource,
417408
...getAttributesForRoute(to),
@@ -463,7 +454,6 @@ describe('instrumentVueRouter()', () => {
463454
expect(mockedTxn.updateName).toHaveBeenCalledWith(transactionName);
464455
expect(mockedTxn.setAttribute).toHaveBeenCalledWith(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, transactionSource);
465456
expect(mockedTxn.setAttributes).toHaveBeenCalledWith({
466-
'routing.instrumentation': 'vue-router',
467457
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.vue',
468458
...getAttributesForRoute(to),
469459
});
@@ -491,7 +481,6 @@ describe('instrumentVueRouter()', () => {
491481
expect(mockStartSpan).toHaveBeenLastCalledWith({
492482
name: '/login',
493483
attributes: {
494-
'routing.instrumentation': 'vue-router',
495484
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.vue',
496485
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
497486
...getAttributesForRoute(to),
@@ -519,7 +508,6 @@ describe('instrumentVueRouter()', () => {
519508
expect(mockStartSpan).toHaveBeenLastCalledWith({
520509
name: 'login-screen',
521510
attributes: {
522-
'routing.instrumentation': 'vue-router',
523511
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.vue',
524512
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'custom',
525513
...getAttributesForRoute(to),
@@ -576,7 +564,6 @@ describe('instrumentVueRouter()', () => {
576564
expect(mockedTxn.updateName).not.toHaveBeenCalled();
577565
expect(mockedTxn.setAttribute).not.toHaveBeenCalled();
578566
expect(mockedTxn.setAttributes).toHaveBeenCalledWith({
579-
'routing.instrumentation': 'vue-router',
580567
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.vue',
581568
...getAttributesForRoute(to),
582569
});
@@ -662,7 +649,6 @@ describe('instrumentVueRouter()', () => {
662649
expect(mockStartSpan).toHaveBeenLastCalledWith({
663650
name: '/login',
664651
attributes: {
665-
'routing.instrumentation': 'vue-router',
666652
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.vue',
667653
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
668654
...getAttributesForRoute(to),

0 commit comments

Comments
 (0)