PR feedback

Author: mydea

packages/replay/src/coreHandlers/handleFetch.ts

@@ -1,7 +1,7 @@
 import type { HandlerDataFetch } from '@sentry/types';
 
 import type { ReplayContainer, ReplayPerformanceEntry } from '../types';
-import { addPerformanceEntryBreadcrumb } from './handleNetworkBreadcrumbs';
+import { addNetworkBreadcrumb } from './handleNetworkBreadcrumbs';
 
 /** only exported for tests */
 export function handleFetch(handlerData: HandlerDataFetch): null | ReplayPerformanceEntry {
@@ -38,6 +38,6 @@ export function handleFetchSpanListener(replay: ReplayContainer): (handlerData:
 
     const result = handleFetch(handlerData);
 
-    addPerformanceEntryBreadcrumb(replay, result);
+    addNetworkBreadcrumb(replay, result);
   };
 }

packages/replay/src/coreHandlers/handleNetworkBreadcrumbs.ts

@@ -84,7 +84,7 @@ export function handleNetworkBreadcrumb(
 
       // Create a replay performance entry from this breadcrumb
       const result = _makeReplayBreadcrumb('resource.xhr', breadcrumb, hint);
-      addPerformanceEntryBreadcrumb(options.replay, result);
+      addNetworkBreadcrumb(options.replay, result);
     }
 
     if (_isFetchBreadcrumb(breadcrumb) && _isFetchHint(hint)) {
@@ -93,7 +93,7 @@ export function handleNetworkBreadcrumb(
 
       // Create a replay performance entry from this breadcrumb
       const result = _makeReplayBreadcrumb('resource.fetch', breadcrumb, hint);
-      addPerformanceEntryBreadcrumb(options.replay, result);
+      addNetworkBreadcrumb(options.replay, result);
     }
   } catch (e) {
     __DEBUG_BUILD__ && logger.warn('Error when enriching network breadcrumb');
@@ -245,7 +245,7 @@ function getFetchBody(fetchArgs: unknown[] = []): RequestInit['body'] | undefine
 }
 
 /** Add a performance entry breadcrumb */
-export function addPerformanceEntryBreadcrumb(replay: ReplayContainer, result: ReplayPerformanceEntry | null): void {
+export function addNetworkBreadcrumb(replay: ReplayContainer, result: ReplayPerformanceEntry | null): void {
   if (!replay.isEnabled()) {
     return;
   }

packages/replay/src/coreHandlers/handleXhr.ts

@@ -1,7 +1,7 @@
 import type { HandlerDataXhr } from '@sentry/types';
 
 import type { ReplayContainer, ReplayPerformanceEntry } from '../types';
-import { addPerformanceEntryBreadcrumb } from './handleNetworkBreadcrumbs';
+import { addNetworkBreadcrumb } from './handleNetworkBreadcrumbs';
 
 /** only exported for tests */
 export function handleXhr(handlerData: HandlerDataXhr): ReplayPerformanceEntry | null {
@@ -48,6 +48,6 @@ export function handleXhrSpanListener(replay: ReplayContainer): (handlerData: Ha
 
     const result = handleXhr(handlerData);
 
-    addPerformanceEntryBreadcrumb(replay, result);
+    addNetworkBreadcrumb(replay, result);
   };
 }

packages/replay/src/util/addGlobalListeners.ts

@@ -23,6 +23,7 @@ export function addGlobalListeners(replay: ReplayContainer): void {
   }
   addInstrumentationHandler('dom', handleDomListener(replay));
   addInstrumentationHandler('history', handleHistorySpanListener(replay));
+  handleNetworkBreadcrumbs(replay);
 
   // If a custom client has no hooks yet, we continue to use the "old" implementation
   const hasHooks = !!(client && client.on);
@@ -35,6 +36,4 @@ export function addGlobalListeners(replay: ReplayContainer): void {
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     (client as BaseClient<any>).on('afterSendEvent', handleAfterSendEvent(replay));
   }
-
-  handleNetworkBreadcrumbs(replay);
 }