move around replay snapshots

Author: billyvg

dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseHeaders/test.ts

@@ -37,15 +37,14 @@ sentryTest('handles empty headers', async ({ getLocalTestPath, page, browserName
   const url = await getLocalTestPath({ testDir: __dirname });
   await page.goto(url);
 
-  const [, request, { replayRecordingSnapshots }] = await Promise.all([
+  const [, request] = await Promise.all([
     page.evaluate(() => {
       fetch('http://localhost:7654/foo').then(() => {
         // @ts-expect-error Sentry is a global
         Sentry.captureException('test error');
       });
     }),
     requestPromise,
-    replayRequestPromise,
   ]);
 
   const eventData = envelopeRequestParser(request);
@@ -64,6 +63,7 @@ sentryTest('handles empty headers', async ({ getLocalTestPath, page, browserName
     },
   });
 
+  const { replayRecordingSnapshots } = await replayRequestPromise;
   expect(getReplayPerformanceSpans(replayRecordingSnapshots).filter(span => span.op === 'resource.fetch')).toEqual([
     {
       data: {
@@ -113,15 +113,14 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
   const url = await getLocalTestPath({ testDir: __dirname });
   await page.goto(url);
 
-  const [, request, { replayRecordingSnapshots }] = await Promise.all([
+  const [, request] = await Promise.all([
     page.evaluate(() => {
       fetch('http://localhost:7654/foo').then(() => {
         // @ts-expect-error Sentry is a global
         Sentry.captureException('test error');
       });
     }),
     requestPromise,
-    replayRequestPromise,
   ]);
 
   const eventData = envelopeRequestParser(request);
@@ -140,6 +139,7 @@ sentryTest('captures response headers', async ({ getLocalTestPath, page }) => {
     },
   });
 
+  const { replayRecordingSnapshots } = await replayRequestPromise;
   expect(getReplayPerformanceSpans(replayRecordingSnapshots).filter(span => span.op === 'resource.fetch')).toEqual([
     {
       data: {
@@ -195,15 +195,14 @@ sentryTest('does not capture response headers if URL does not match', async ({ g
   const url = await getLocalTestPath({ testDir: __dirname });
   await page.goto(url);
 
-  const [, request, { replayRecordingSnapshots }] = await Promise.all([
+  const [, request] = await Promise.all([
     page.evaluate(() => {
       fetch('http://localhost:7654/bar').then(() => {
         // @ts-expect-error Sentry is a global
         Sentry.captureException('test error');
       });
     }),
     requestPromise,
-    replayRequestPromise,
   ]);
 
   const eventData = envelopeRequestParser(request);
@@ -222,6 +221,7 @@ sentryTest('does not capture response headers if URL does not match', async ({ g
     },
   });
 
+  const { replayRecordingSnapshots } = await replayRequestPromise;
   expect(getReplayPerformanceSpans(replayRecordingSnapshots).filter(span => span.op === 'resource.fetch')).toEqual([
     {
       data: {

dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureResponseSize/test.ts

@@ -43,7 +43,7 @@ sentryTest('captures response size from Content-Length header if available', asy
   const url = await getLocalTestPath({ testDir: __dirname });
   await page.goto(url);
 
-  const [, request, { replayRecordingSnapshots }] = await Promise.all([
+  const [, request ] = await Promise.all([
     page.evaluate(() => {
       /* eslint-disable */
       fetch('http://localhost:7654/foo').then(() => {
@@ -53,7 +53,6 @@ sentryTest('captures response size from Content-Length header if available', asy
       /* eslint-enable */
     }),
     requestPromise,
-    replayRequestPromise,
   ]);
 
   const eventData = envelopeRequestParser(request);
@@ -73,6 +72,7 @@ sentryTest('captures response size from Content-Length header if available', asy
     },
   });
 
+  const { replayRecordingSnapshots } = await replayRequestPromise;
   expect(getReplayPerformanceSpans(replayRecordingSnapshots).filter(span => span.op === 'resource.fetch')).toEqual([
     {
       data: {
@@ -135,7 +135,7 @@ sentryTest('captures response size without Content-Length header', async ({ getL
   const url = await getLocalTestPath({ testDir: __dirname });
   await page.goto(url);
 
-  const [, request, { replayRecordingSnapshots }] = await Promise.all([
+  const [, request] = await Promise.all([
     page.evaluate(() => {
       /* eslint-disable */
       fetch('http://localhost:7654/foo').then(() => {
@@ -145,7 +145,6 @@ sentryTest('captures response size without Content-Length header', async ({ getL
       /* eslint-enable */
     }),
     requestPromise,
-    replayRequestPromise,
   ]);
 
   const eventData = envelopeRequestParser(request);
@@ -163,8 +162,9 @@ sentryTest('captures response size without Content-Length header', async ({ getL
       // NOT set here from body, as this would be async
       url: 'http://localhost:7654/foo',
     },
-  });
+  })
 
+  const { replayRecordingSnapshots } = await replayRequestPromise;
   expect(getReplayPerformanceSpans(replayRecordingSnapshots).filter(span => span.op === 'resource.fetch')).toEqual([
     {
       data: {