Skip to content

Commit 9f522c9

Browse files
authored
fix(remix): Pass transaction name as route to RequestData. (#6276)
1 parent e97ae86 commit 9f522c9

File tree

1 file changed

+23
-5
lines changed

1 file changed

+23
-5
lines changed

packages/remix/src/utils/instrumentServer.ts

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,20 @@ async function captureRemixServerException(err: Error, name: string, request: Re
9696
const normalizedRequest = normalizeRemixRequest(request as unknown as any);
9797

9898
captureException(isResponse(err) ? await extractResponseError(err) : err, scope => {
99-
scope.setSDKProcessingMetadata({ request: normalizedRequest });
99+
const activeTransactionName = getActiveTransaction()?.name;
100+
101+
scope.setSDKProcessingMetadata({
102+
request: {
103+
...normalizedRequest,
104+
// When `route` is not defined, `RequestData` integration uses the full URL
105+
route: activeTransactionName
106+
? {
107+
path: activeTransactionName,
108+
}
109+
: undefined,
110+
},
111+
});
112+
100113
scope.addEventProcessor(event => {
101114
addExceptionMechanism(event, {
102115
type: 'instrument',
@@ -378,19 +391,24 @@ function wrapRequestHandler(origRequestHandler: RequestHandler, build: ServerBui
378391

379392
const normalizedRequest = normalizeRemixRequest(request);
380393

394+
const url = new URL(request.url);
395+
const [name, source] = getTransactionName(routes, url, pkg);
396+
381397
if (scope) {
382398
scope.setSDKProcessingMetadata({
383-
request: normalizedRequest,
399+
request: {
400+
...normalizedRequest,
401+
route: {
402+
path: name,
403+
},
404+
},
384405
});
385406
}
386407

387408
if (!options || !hasTracingEnabled(options)) {
388409
return origRequestHandler.call(this, request, loadContext);
389410
}
390411

391-
const url = new URL(request.url);
392-
const [name, source] = getTransactionName(routes, url, pkg);
393-
394412
const transaction = startRequestHandlerTransaction(hub, name, source, {
395413
headers: {
396414
'sentry-trace': request.headers.get('sentry-trace') || '',

0 commit comments

Comments
 (0)