ref(core): Cleanup todos & internal types

These are small changes, cleaning up outdated (I believe?) TODOs, and some internal type stuff.

Author: mydea

packages/browser-utils/src/metrics/inp.ts

@@ -127,9 +127,8 @@ function _trackINP(): () => void {
 
 /**
  * Register a listener to cache route information for INP interactions.
- * TODO(v9): `latestRoute` no longer needs to be passed in and will be removed in v9.
  */
-export function registerInpInteractionListener(_latestRoute?: unknown): void {
+export function registerInpInteractionListener(): void {
   const handleEntries = ({ entries }: { entries: PerformanceEntry[] }): void => {
     const activeSpan = getActiveSpan();
     const activeRootSpan = activeSpan && getRootSpan(activeSpan);

packages/browser/src/sdk.ts

@@ -198,9 +198,7 @@ export function init(browserOptions: BrowserOptions = {}): Client | undefined {
  * All properties the report dialog supports
  */
 export interface ReportDialogOptions {
-  // TODO(v9): Change this to  [key: string]: unknkown;
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  [key: string]: any;
+  [key: string]: unknown;
   eventId?: string;
   dsn?: DsnLike;
   user?: {

packages/browser/src/transports/fetch.ts

@@ -1,6 +1,6 @@
 import { clearCachedImplementation, getNativeImplementation } from '@sentry-internal/browser-utils';
 import type { Transport, TransportMakeRequestResponse, TransportRequest } from '@sentry/core';
-import { createTransport, rejectedSyncPromise } from '@sentry/core';
+import { createTransport, rejectedSyncPromise, suppressTracing } from '@sentry/core';
 import type { WINDOW } from '../helpers';
 import type { BrowserTransportOptions } from './types';
 
@@ -45,18 +45,19 @@ export function makeFetchTransport(
     }
 
     try {
-      // TODO: This may need a `suppressTracing` call in the future when we switch the browser SDK to OTEL
-      return nativeFetch(options.url, requestOptions).then(response => {
-        pendingBodySize -= requestSize;
-        pendingCount--;
-        return {
-          statusCode: response.status,
-          headers: {
-            'x-sentry-rate-limits': response.headers.get('X-Sentry-Rate-Limits'),
-            'retry-after': response.headers.get('Retry-After'),
-          },
-        };
-      });
+      return suppressTracing(() =>
+        nativeFetch(options.url, requestOptions).then(response => {
+          pendingBodySize -= requestSize;
+          pendingCount--;
+          return {
+            statusCode: response.status,
+            headers: {
+              'x-sentry-rate-limits': response.headers.get('X-Sentry-Rate-Limits'),
+              'retry-after': response.headers.get('Retry-After'),
+            },
+          };
+        }),
+      );
     } catch (e) {
       clearCachedImplementation('fetch');
       pendingBodySize -= requestSize;

packages/core/src/api.ts

@@ -47,9 +47,7 @@ export function getEnvelopeEndpointWithUrlEncodedAuth(dsn: DsnComponents, tunnel
 export function getReportDialogEndpoint(
   dsnLike: DsnLike,
   dialogOptions: {
-    // TODO(v9): Change this to  [key: string]: unknown;
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    [key: string]: any;
+    [key: string]: unknown;
     user?: { name?: string; email?: string };
   },
 ): string {

packages/core/src/integrations/inboundfilters.ts

@@ -131,7 +131,6 @@ function _isIgnoredTransaction(event: Event, ignoreTransactions?: Array<string |
 }
 
 function _isDeniedUrl(event: Event, denyUrls?: Array<string | RegExp>): boolean {
-  // TODO: Use Glob instead?
   if (!denyUrls || !denyUrls.length) {
     return false;
   }
@@ -140,7 +139,6 @@ function _isDeniedUrl(event: Event, denyUrls?: Array<string | RegExp>): boolean
 }
 
 function _isAllowedUrl(event: Event, allowUrls?: Array<string | RegExp>): boolean {
-  // TODO: Use Glob instead?
   if (!allowUrls || !allowUrls.length) {
     return true;
   }

packages/core/src/types-hoist/wrappedfunction.ts

@@ -3,8 +3,6 @@
  */
 // eslint-disable-next-line @typescript-eslint/ban-types
 export type WrappedFunction<T extends Function = Function> = T & {
-  // TODO(v9): Remove this
-  [key: string]: any;
   __sentry_wrapped__?: WrappedFunction<T>;
   __sentry_original__?: T;
 };

packages/core/src/utils-hoist/time.ts

@@ -19,8 +19,6 @@ interface Performance {
 
 /**
  * Returns a timestamp in seconds since the UNIX epoch using the Date API.
- *
- * TODO(v8): Return type should be rounded.
  */
 export function dateTimestampInSeconds(): number {
   return Date.now() / ONE_SECOND_IN_MS;

packages/opentelemetry/src/utils/contextData.ts

@@ -32,8 +32,7 @@ export function setContextOnScope(scope: Scope, context: Context): void {
 
 /**
  * Get the context related to a scope.
- * TODO v8: Use this for the `trace` functions.
- * */
+ */
 export function getContextFromScope(scope: Scope): Context | undefined {
   return (scope as { [SCOPE_CONTEXT_FIELD]?: Context })[SCOPE_CONTEXT_FIELD];
 }