Skip to content

Commit a2a5b7c

Browse files
committed
Update tsconfigs
1 parent b87c5c9 commit a2a5b7c

File tree

6 files changed

+37
-26
lines changed

6 files changed

+37
-26
lines changed

packages/solidstart/.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
/server
2+
/client
3+
/*.d.ts
4+
/*.d.ts.map

packages/solidstart/package.json

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sentry/solidstart",
3-
"version": "8.12.0",
3+
"version": "8.13.0",
44
"description": "Official Sentry SDK for Solid Start",
55
"repository": "git://github.com/getsentry/sentry-javascript.git",
66
"homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/solidstart",
@@ -60,12 +60,12 @@
6060
}
6161
},
6262
"dependencies": {
63-
"@sentry/core": "8.12.0",
64-
"@sentry/node": "8.12.0",
65-
"@sentry/opentelemetry": "8.12.0",
66-
"@sentry/solid": "8.12.0",
67-
"@sentry/types": "8.12.0",
68-
"@sentry/utils": "8.12.0",
63+
"@sentry/core": "8.13.0",
64+
"@sentry/node": "8.13.0",
65+
"@sentry/opentelemetry": "8.13.0",
66+
"@sentry/solid": "8.13.0",
67+
"@sentry/types": "8.13.0",
68+
"@sentry/utils": "8.13.0",
6969
"@sentry/vite-plugin": "2.19.0"
7070
},
7171
"devDependencies": {
@@ -80,14 +80,16 @@
8080
"build": "run-p build:transpile build:types",
8181
"build:dev": "yarn build",
8282
"build:transpile": "rollup -c rollup.npm.config.mjs",
83-
"build:types": "tsc -p tsconfig.types.json",
83+
"build:types": "run-s build:types:core build:types:solidrouter",
84+
"build:types:core": "tsc -p tsconfig.types.json",
85+
"build:types:solidrouter": "tsc -p tsconfig.solidrouter-types.json",
8486
"build:watch": "run-p build:transpile:watch build:types:watch",
8587
"build:dev:watch": "yarn build:watch",
8688
"build:transpile:watch": "rollup -c rollup.npm.config.mjs --watch",
8789
"build:types:watch": "tsc -p tsconfig.types.json --watch",
88-
"build:tarball": "ts-node ../../scripts/prepack.ts && npm pack ./build",
90+
"build:tarball": "npm pack",
8991
"circularDepCheck": "madge --circular src/index.client.ts && madge --circular src/index.server.ts && madge --circular src/index.types.ts",
90-
"clean": "rimraf build coverage sentry-sveltekit-*.tgz",
92+
"clean": "rimraf build coverage sentry-solidstart-*.tgz ./*.d.ts ./*.d.ts.map ./client ./server",
9193
"fix": "eslint . --format stylish --fix",
9294
"lint": "eslint . --format stylish",
9395
"test": "yarn test:unit",

packages/solidstart/src/server/solidrouter.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
import type { Integration } from '@sentry/types';
2-
import type {
3-
HashRouter,
4-
MemoryRouter,
5-
RouteSectionProps,
6-
Router as BaseRouter,
7-
StaticRouter,
8-
} from '@solidjs/router';
2+
import type { HashRouter, MemoryRouter, RouteSectionProps, Router as BaseRouter, StaticRouter } from '@solidjs/router';
93
import { mergeProps, splitProps } from 'solid-js';
104
import type { Component, JSX, ParentProps } from 'solid-js';
115
import { createComponent } from 'solid-js/web';
@@ -32,11 +26,11 @@ function withSentryRouterRoot(Root: Component<RouteSectionProps>): Component<Rou
3226
*/
3327
export function solidRouterBrowserTracingIntegration(
3428
// eslint-disable-next-line @typescript-eslint/no-unused-vars
35-
options: any
29+
options: any,
3630
): Integration {
3731
return {
3832
name: 'solidRouterBrowserTracingIntegration',
39-
}
33+
};
4034
}
4135

4236
type RouterType = typeof BaseRouter | typeof HashRouter | typeof MemoryRouter | typeof StaticRouter;

packages/solidstart/tsconfig.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33

44
"include": ["src/**/*"],
55

6-
"compilerOptions": {
7-
// package-specific options
8-
}
6+
"compilerOptions": {}
97
}

packages/solidstart/tsconfig.solidrouter-types.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,13 @@
88
"outDir": "./"
99
},
1010

11-
"//": "Tehese types are built separately because it is for a subpath export, which has problems if it is not in the root",
12-
"include": ["src/solidrouter.client.ts", "src/solidrouter.server.ts"],
11+
"//": "This type is built separately because it is for a subpath export, which has problems if it is not in the root",
12+
"include": [
13+
"src/client/solidrouter.ts",
14+
"src/solidrouter.client.ts",
15+
"src/server/solidrouter.ts",
16+
"src/solidrouter.server.ts"
17+
],
1318
"//": "Without this, we cannot output into the root dir",
1419
"exclude": []
1520
}

packages/solidstart/tsconfig.types.json

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@
55
"declaration": true,
66
"declarationMap": true,
77
"emitDeclarationOnly": true,
8-
"outDir": "build"
9-
}
8+
"outDir": "build/types"
9+
},
10+
11+
"//": "This is built separately in tsconfig.solidrouter-types.json",
12+
"exclude": [
13+
"src/client/solidrouter.ts",
14+
"src/solidrouter.client.ts",
15+
"src/server/solidrouter.ts",
16+
"src/solidrouter.server.ts"
17+
]
1018
}

0 commit comments

Comments
 (0)