introduce diff option types

Author: AbhiPrasad

packages/node/src/client.ts

@@ -5,22 +5,22 @@ import { logger, resolvedSyncPromise, stackParserFromOptions } from '@sentry/uti
 
 import { eventFromMessage, eventFromUnknownInput } from './eventbuilder';
 import { IS_DEBUG_BUILD } from './flags';
-import { NodeOptions } from './types';
+import { NodeClientOptions } from './types';
 
 /**
  * The Sentry Node SDK Client.
  *
  * @see NodeOptions for documentation on configuration options.
  * @see SentryClient for usage documentation.
  */
-export class NodeClient extends BaseClient<NodeOptions> {
+export class NodeClient extends BaseClient<NodeClientOptions> {
   protected _sessionFlusher: SessionFlusher | undefined;
 
   /**
    * Creates a new Node SDK instance.
    * @param options Configuration options for this SDK.
    */
-  public constructor(options: NodeOptions, transport: Transport, newTransport?: NewTransport) {
+  public constructor(options: NodeClientOptions, transport: Transport, newTransport?: NewTransport) {
     options._metadata = options._metadata || {};
     options._metadata.sdk = options._metadata.sdk || {
       name: 'sentry.javascript.node',

packages/node/src/transports/setup.ts

@@ -2,7 +2,7 @@ import { getEnvelopeEndpointWithUrlEncodedAuth, initAPIDetails, NewTransport, No
 import { Transport, TransportOptions } from '@sentry/types';
 import { makeDsn } from '@sentry/utils';
 
-import { NodeOptions } from '../types';
+import { NodeClientOptions } from '../types';
 import { HTTPSTransport, HTTPTransport, makeNodeTransport } from '.';
 
 /**
@@ -13,7 +13,7 @@ import { HTTPSTransport, HTTPTransport, makeNodeTransport } from '.';
  * this function will return a ready to use `NewTransport`.
  */
 // TODO(v7): Adjust return value when NewTransport is the default
-export function setupNodeTransport(options: NodeOptions): { transport: Transport; newTransport?: NewTransport } {
+export function setupNodeTransport(options: NodeClientOptions): { transport: Transport; newTransport?: NewTransport } {
   if (!options.dsn) {
     // We return the noop transport here in case there is no Dsn.
     return { transport: new NoopTransport() };

packages/node/src/types.ts

@@ -1,16 +1,9 @@
-import { Options } from '@sentry/types';
+import { ClientOptions, Options } from '@sentry/types';
 
-/**
- * Configuration options for the Sentry Node SDK.
- * @see NodeClient for more information.
- */
-export interface NodeOptions extends Options {
+export interface BaseNodeOptions {
   /** Sets an optional server name (device name) */
   serverName?: string;
 
-  /** Maximum time in milliseconds to wait to drain the request queue, before the process is allowed to exit. */
-  shutdownTimeout?: number;
-
   /** Set a HTTP proxy that should be used for outbound requests. */
   httpProxy?: string;
 
@@ -23,3 +16,11 @@ export interface NodeOptions extends Options {
   /** Callback that is executed when a fatal global error occurs. */
   onFatalError?(error: Error): void;
 }
+
+export interface NodeOptions extends Options, BaseNodeOptions {}
+
+/**
+ * Configuration options for the Sentry Node SDK.
+ * @see NodeClient for more information.
+ */
+export interface NodeClientOptions extends ClientOptions, BaseNodeOptions {}