Rename options type of node transport

Author: Luca Forstner

packages/core/src/transports/base.ts

@@ -67,17 +67,6 @@ export interface BrowserTransportOptions extends BaseTransportOptions {
   sendClientReports?: boolean;
 }
 
-// TODO: Move into Node transport
-export interface NodeTransportOptions extends BaseTransportOptions {
-  headers?: Record<string, string>;
-  // Set a HTTP proxy that should be used for outbound requests.
-  httpProxy?: string;
-  // Set a HTTPS proxy that should be used for outbound requests.
-  httpsProxy?: string;
-  // HTTPS proxy certificates path
-  caCerts?: string;
-}
-
 export interface NewTransport {
   send(request: Envelope): PromiseLike<TransportResponse>;
   flush(timeout?: number): PromiseLike<boolean>;

packages/node/src/transports/index.ts

@@ -1,4 +1,4 @@
 export { BaseTransport } from './base';
 export { HTTPTransport } from './http';
 export { HTTPSTransport } from './https';
-export { makeNewHttpTransport, makeNewHttpsTransport } from './new';
+export { makeNewHttpTransport, makeNewHttpsTransport, NodeTransportOptions } from './new';

packages/node/src/transports/new.ts

@@ -20,7 +20,7 @@ import { HTTPModule } from './base/http-module';
 // OR
 // - Split this file up and leave it in the transports folder
 
-export interface HttpTransportOptions extends BaseTransportOptions {
+export interface NodeTransportOptions extends BaseTransportOptions {
   /** Define custom headers */
   headers?: Record<string, string>;
   /** Set a proxy that should be used for outbound requests. */
@@ -34,7 +34,7 @@ export interface HttpTransportOptions extends BaseTransportOptions {
 /**
  * Creates a Transport that uses http to send events to Sentry.
  */
-export function makeNewHttpTransport(options: HttpTransportOptions): NewTransport {
+export function makeNewHttpTransport(options: NodeTransportOptions): NewTransport {
   // Proxy prioritization: http  => `options.proxy` | `process.env.http_proxy`
   const proxy = applyNoProxyOption(options.url, options.proxy || process.env.http_proxy);
 
@@ -51,7 +51,7 @@ export function makeNewHttpTransport(options: HttpTransportOptions): NewTranspor
 /**
  * Creates a Transport that uses https to send events to Sentry.
  */
-export function makeNewHttpsTransport(options: HttpTransportOptions): NewTransport {
+export function makeNewHttpsTransport(options: NodeTransportOptions): NewTransport {
   // Proxy prioritization: https => `options.proxy` | `process.env.https_proxy` | `process.env.http_proxy`
   const proxy = applyNoProxyOption(options.url, options.proxy || process.env.https_proxy || process.env.http_proxy);
 
@@ -94,7 +94,7 @@ function applyNoProxyOption(transportUrl: string, proxy: string | undefined): st
  * Creates a RequestExecutor to be used with `createTransport`.
  */
 function createRequestExecutor(
-  options: HttpTransportOptions,
+  options: NodeTransportOptions,
   httpModule: HTTPModule,
   agent: http.Agent,
 ): TransportRequestExecutor {