Skip to content

Commit a4419c2

Browse files
committed
account for bundles
1 parent 3988ea8 commit a4419c2

File tree

2 files changed

+14
-5
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/request

2 files changed

+14
-5
lines changed

dev-packages/browser-integration-tests/suites/tracing/request/fetch-with-no-active-span/test.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,16 @@ sentryTest(
2020

2121
await page.goto(url);
2222

23-
// There are 6 requests in the page:
23+
// Here are the requests that should exist:
2424
// 1. HTML page
2525
// 2. Init JS bundle
2626
// 3. Subject JS bundle
27+
// 4 [OPTIONAl] CDN JS bundle
2728
// and then 3 fetch requests
28-
expect(requestCount).toBe(6);
29+
if (process.env.PW_BUNDLE && process.env.PW_BUNDLE.startsWith('bundle_')) {
30+
expect(requestCount).toBe(7);
31+
} else {
32+
expect(requestCount).toBe(6);
33+
}
2934
},
3035
);

dev-packages/browser-integration-tests/suites/tracing/request/xhr-with-no-active-span/test.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,22 @@ sentryTest(
1414

1515
let requestCount = 0;
1616
page.on('request', request => {
17-
console.log(request.url());
1817
expect(request.url()).not.toContain(url);
1918
requestCount++;
2019
});
2120

2221
await page.goto(url);
2322

24-
// There are 6 requests in the page:
23+
// Here are the requests that should exist:
2524
// 1. HTML page
2625
// 2. Init JS bundle
2726
// 3. Subject JS bundle
27+
// 4 [OPTIONAl] CDN JS bundle
2828
// and then 3 fetch requests
29-
expect(requestCount).toBe(6);
29+
if (process.env.PW_BUNDLE && process.env.PW_BUNDLE.startsWith('bundle_')) {
30+
expect(requestCount).toBe(7);
31+
} else {
32+
expect(requestCount).toBe(6);
33+
}
3034
},
3135
);

0 commit comments

Comments
 (0)