Skip to content

Commit a61eec7

Browse files
authored
fix(feedback): Set optionOverrides to be optional in TS definition (#12125)
These params are optional, to the TS typedef should align with that. **Before:** <img width="1008" alt="SCR-20240520-ltyb" src="https://github.com/getsentry/sentry-javascript/assets/187460/8d242640-f67a-406d-a963-9b40fea1de54"> **After:** <img width="1089" alt="SCR-20240520-ltvg" src="https://github.com/getsentry/sentry-javascript/assets/187460/71d98556-9151-4146-8de9-6504e22d4731"> Related to #12015
1 parent de60306 commit a61eec7

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/feedback/src/core/integration.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ export const buildFeedbackIntegration = ({
5555
getScreenshotIntegration,
5656
}: BuilderOptions): IntegrationFn<
5757
Integration & {
58-
attachTo(el: Element | string, optionOverrides: OverrideFeedbackConfiguration): Unsubscribe;
59-
createForm(optionOverrides: OverrideFeedbackConfiguration): Promise<FeedbackDialog>;
60-
createWidget(optionOverrides: OverrideFeedbackConfiguration): ActorComponent;
58+
attachTo(el: Element | string, optionOverrides?: OverrideFeedbackConfiguration): Unsubscribe;
59+
createForm(optionOverrides?: OverrideFeedbackConfiguration): Promise<FeedbackDialog>;
60+
createWidget(optionOverrides?: OverrideFeedbackConfiguration): ActorComponent;
6161
remove(): void;
6262
}
6363
> => {

0 commit comments

Comments
 (0)