Skip to content

Commit a8faa72

Browse files
committed
update comment, fix test
1 parent e53b283 commit a8faa72

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/feedback/src/util/sendFeedbackRequest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export async function sendFeedbackRequest({
109109
return response;
110110
}
111111

112-
// If the status code is invalid, we want to immediately stop & not retry
112+
// Require valid status codes, otherwise can assume feedback was not sent successfully
113113
if (typeof response.statusCode === 'number' && (response.statusCode < 200 || response.statusCode >= 300)) {
114114
throw new Error('Unable to send Feedback');
115115
}

packages/feedback/test/widget/createWidget.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ describe('createWidget', () => {
177177
});
178178

179179
(sendFeedbackRequest as jest.Mock).mockImplementation(() => {
180-
return false;
180+
throw new Error('Unable to send feedback');
181181
});
182182
widget.actor?.el?.dispatchEvent(new Event('click'));
183183

0 commit comments

Comments
 (0)