Skip to content

Commit a9192a9

Browse files
committed
un-brittle tests hopefully
1 parent 3010ac5 commit a9192a9

File tree

3 files changed

+25
-5
lines changed

3 files changed

+25
-5
lines changed

packages/browser-integration-tests/suites/replay/slowClick/ignore/test.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@ sentryTest('click is ignored on div', async ({ getLocalTestUrl, page }) => {
2323
await page.goto(url);
2424
await reqPromise0;
2525

26-
const reqPromise1 = waitForReplayRequest(page);
26+
const reqPromise1 = waitForReplayRequest(page, (event, res) => {
27+
const { breadcrumbs } = getCustomRecordingEvents(res);
28+
29+
return breadcrumbs.some(breadcrumb => breadcrumb.category === 'ui.click');
30+
});
2731

2832
await page.click('#mutationDiv');
2933

@@ -70,7 +74,11 @@ sentryTest('click is ignored on ignoreSelectors', async ({ getLocalTestUrl, page
7074
await page.goto(url);
7175
await reqPromise0;
7276

73-
const reqPromise1 = waitForReplayRequest(page);
77+
const reqPromise1 = waitForReplayRequest(page, (event, res) => {
78+
const { breadcrumbs } = getCustomRecordingEvents(res);
79+
80+
return breadcrumbs.some(breadcrumb => breadcrumb.category === 'ui.click');
81+
});
7482

7583
await page.click('#mutationIgnoreButton');
7684

packages/browser-integration-tests/suites/replay/slowClick/mutation/test.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,11 @@ sentryTest('immediate mutation does not trigger slow click', async ({ getLocalTe
8181
await page.goto(url);
8282
await reqPromise0;
8383

84-
const reqPromise1 = waitForReplayRequest(page);
84+
const reqPromise1 = waitForReplayRequest(page, (event, res) => {
85+
const { breadcrumbs } = getCustomRecordingEvents(res);
86+
87+
return breadcrumbs.some(breadcrumb => breadcrumb.category === 'ui.click');
88+
});
8589

8690
await page.click('#mutationButtonImmediately');
8791

@@ -128,7 +132,11 @@ sentryTest('inline click handler does not trigger slow click', async ({ getLocal
128132
await page.goto(url);
129133
await reqPromise0;
130134

131-
const reqPromise1 = waitForReplayRequest(page);
135+
const reqPromise1 = waitForReplayRequest(page, (event, res) => {
136+
const { breadcrumbs } = getCustomRecordingEvents(res);
137+
138+
return breadcrumbs.some(breadcrumb => breadcrumb.category === 'ui.click');
139+
});
132140

133141
await page.click('#mutationButtonInline');
134142

packages/browser-integration-tests/suites/replay/slowClick/scroll/test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@ sentryTest('immediate scroll does not trigger slow click', async ({ getLocalTest
2323
await page.goto(url);
2424
await reqPromise0;
2525

26-
const reqPromise1 = waitForReplayRequest(page);
26+
const reqPromise1 = waitForReplayRequest(page, (event, res) => {
27+
const { breadcrumbs } = getCustomRecordingEvents(res);
28+
29+
return breadcrumbs.some(breadcrumb => breadcrumb.category === 'ui.click');
30+
});
2731

2832
await page.click('#scrollButton');
2933

0 commit comments

Comments
 (0)