Skip to content

Commit a9de525

Browse files
committed
integrate with sentry
1 parent 1b06f38 commit a9de525

File tree

5 files changed

+17
-13
lines changed

5 files changed

+17
-13
lines changed

packages/feedback/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
export type { SendFeedbackData } from './types'
2+
export { sendFeedbackRequest } from './util/sendFeedbackRequest'
Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type {Event} from '@sentry/types';
1+
import type { Event, Primitive } from '@sentry/types';
22

33
/**
44
* NOTE: These types are still considered Beta and subject to change.
@@ -8,16 +8,20 @@ export interface FeedbackEvent extends Event {
88
feedback: {
99
contact_email: string;
1010
message: string;
11-
replay_id: string;
11+
replay_id: string | undefined;
1212
url: string;
1313
};
1414
// TODO: Add this event type to Event
1515
// type: 'feedback_event';
1616
}
1717

1818
export interface SendFeedbackData {
19-
message: string,
20-
email: string,
21-
replay_id: string,
22-
url: string,
19+
feedback: {
20+
message: string,
21+
email: string,
22+
replay_id: string | undefined,
23+
name: string,
24+
url: string,
25+
}
26+
tags: { [key: string]: Primitive; } | undefined,
2327
}

packages/feedback/src/util/prepareFeedbackEvent.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export async function prepareFeedbackEvent({
1919
const preparedEvent = (await prepareEvent(
2020
client.getOptions(),
2121
event,
22-
{integrations: []},
22+
{integrations: undefined},
2323
scope
2424
)) as FeedbackEvent | null;
2525

packages/feedback/src/util/sendFeedbackRequest.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@ import { prepareFeedbackEvent } from './prepareFeedbackEvent';
88
* Send feedback using `fetch()`
99
*/
1010
export async function sendFeedbackRequest({
11-
message,
12-
email,
13-
replay_id,
14-
url,
11+
feedback: {message, email, name, replay_id, url},
12+
tags,
1513
}: SendFeedbackData): Promise<Response | null> {
1614
const hub = getCurrentHub();
1715

@@ -31,10 +29,12 @@ export async function sendFeedbackRequest({
3129
const baseEvent = {
3230
feedback: {
3331
contact_email: email,
32+
name,
3433
message,
3534
replay_id,
3635
url,
3736
},
37+
tags,
3838
// type: 'feedback_event',
3939
};
4040

@@ -45,8 +45,6 @@ export async function sendFeedbackRequest({
4545
});
4646

4747
if (!feedbackEvent) {
48-
// Taken from baseclient's `_processEvent` method, where this is handled for errors/transactions
49-
// client.recordDroppedEvent('event_processor', 'feedback', baseEvent);
5048
return null;
5149
}
5250

packages/types/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ export type {
6969
Profile,
7070
} from './profiling';
7171
export type { ReplayEvent, ReplayRecordingData, ReplayRecordingMode } from './replay';
72+
export type { FeedbackEvent } from './feedback';
7273
export type { QueryParams, Request, SanitizedRequestData } from './request';
7374
export type { Runtime } from './runtime';
7475
export type { CaptureContext, Scope, ScopeContext } from './scope';

0 commit comments

Comments
 (0)