fix linting & circular dependency check

Author: mydea

packages/replay/src/coreHandlers/addNetworkBreadcrumb.ts

@@ -0,0 +1,26 @@
+import type { ReplayContainer, ReplayPerformanceEntry } from '../types';
+import { createPerformanceSpans } from '../util/createPerformanceSpans';
+import { shouldFilterRequest } from '../util/shouldFilterRequest';
+
+/** Add a performance entry breadcrumb */
+export function addNetworkBreadcrumb(replay: ReplayContainer, result: ReplayPerformanceEntry | null): void {
+  if (!replay.isEnabled()) {
+    return;
+  }
+
+  if (result === null) {
+    return;
+  }
+
+  if (shouldFilterRequest(replay, result.name)) {
+    return;
+  }
+
+  replay.addUpdate(() => {
+    createPerformanceSpans(replay, [result]);
+    // Returning true will cause `addUpdate` to not flush
+    // We do not want network requests to cause a flush. This will prevent
+    // recurring/polling requests from keeping the replay session alive.
+    return true;
+  });
+}

packages/replay/src/coreHandlers/handleFetch.ts

@@ -1,7 +1,7 @@
 import type { HandlerDataFetch } from '@sentry/types';
 
 import type { ReplayContainer, ReplayPerformanceEntry } from '../types';
-import { addNetworkBreadcrumb } from './handleNetworkBreadcrumbs';
+import { addNetworkBreadcrumb } from './addNetworkBreadcrumb';
 
 /** only exported for tests */
 export function handleFetch(handlerData: HandlerDataFetch): null | ReplayPerformanceEntry {

packages/replay/src/coreHandlers/handleNetworkBreadcrumbs.ts

@@ -5,7 +5,6 @@ import type {
   FetchBreadcrumbData,
   FetchBreadcrumbHint,
   HandlerDataFetch,
-  HandlerDataXhr,
   SentryWrappedXMLHttpRequest,
   TextEncoderInternal,
   XhrBreadcrumbData,
@@ -14,8 +13,7 @@ import type {
 import { addInstrumentationHandler, logger } from '@sentry/utils';
 
 import type { ReplayContainer, ReplayPerformanceEntry } from '../types';
-import { createPerformanceSpans } from '../util/createPerformanceSpans';
-import { shouldFilterRequest } from '../util/shouldFilterRequest';
+import { addNetworkBreadcrumb } from './addNetworkBreadcrumb';
 import { handleFetchSpanListener } from './handleFetch';
 import { handleXhrSpanListener } from './handleXhr';
 
@@ -244,29 +242,6 @@ function getFetchBody(fetchArgs: unknown[] = []): RequestInit['body'] | undefine
   return (fetchArgs[1] as RequestInit).body;
 }
 
-/** Add a performance entry breadcrumb */
-export function addNetworkBreadcrumb(replay: ReplayContainer, result: ReplayPerformanceEntry | null): void {
-  if (!replay.isEnabled()) {
-    return;
-  }
-
-  if (result === null) {
-    return;
-  }
-
-  if (shouldFilterRequest(replay, result.name)) {
-    return;
-  }
-
-  replay.addUpdate(() => {
-    createPerformanceSpans(replay, [result]);
-    // Returning true will cause `addUpdate` to not flush
-    // We do not want network requests to cause a flush. This will prevent
-    // recurring/polling requests from keeping the replay session alive.
-    return true;
-  });
-}
-
 function _isXhrBreadcrumb(breadcrumb: Breadcrumb): breadcrumb is Breadcrumb & { data: XhrBreadcrumbData } {
   return breadcrumb.category === 'xhr';
 }

packages/replay/src/coreHandlers/handleXhr.ts

@@ -1,7 +1,7 @@
 import type { HandlerDataXhr } from '@sentry/types';
 
 import type { ReplayContainer, ReplayPerformanceEntry } from '../types';
-import { addNetworkBreadcrumb } from './handleNetworkBreadcrumbs';
+import { addNetworkBreadcrumb } from './addNetworkBreadcrumb';
 
 /** only exported for tests */
 export function handleXhr(handlerData: HandlerDataXhr): ReplayPerformanceEntry | null {

packages/replay/test/unit/coreHandlers/handleNetworkBreadcrumbs.test.ts

@@ -1,22 +1,21 @@
+import type {
+  Breadcrumb,
+  BreadcrumbHint,
+  FetchBreadcrumbHint,
+  TextEncoderInternal,
+  XhrBreadcrumbHint,
+} from '@sentry/types';
 import { TextEncoder } from 'util';
 
+import { BASE_TIMESTAMP } from '../..';
 import {
   getBodySize,
-  parseContentSizeHeader,
   handleNetworkBreadcrumb,
+  parseContentSizeHeader,
 } from '../../../src/coreHandlers/handleNetworkBreadcrumbs';
-import {
-  Breadcrumb,
-  BreadcrumbHint,
-  TextEncoderInternal,
-  XhrBreadcrumbData,
-  XhrBreadcrumbHint,
-  FetchBreadcrumbHint,
-} from '@sentry/types';
+import type { EventBufferArray } from '../../../src/eventBuffer/EventBufferArray';
+import type { ReplayContainer } from '../../../src/types';
 import { setupReplayContainer } from '../../utils/setupReplayContainer';
-import { ReplayContainer } from '../../../src/types';
-import { EventBufferArray } from '../../../src/eventBuffer/EventBufferArray';
-import { BASE_TIMESTAMP } from '../..';
 
 jest.useFakeTimers();