Skip to content

Commit af6c24f

Browse files
authored
fix(ci): Exclude config/types.ts in @sentry/nextjs from circular dependency check (#4598)
The library we use to detect circular dependencies, `madge`, has a bug wherein local files whose names match node modules cause false positives. (For more details, see pahen/madge#306.) In our case, it was triggered by #4597, which added an export from file (`config/types.ts`) which depends on the node module `webpack` and which is depended upon by the local file `config/webpack.ts`. To solve this for the moment, this excludes the problematic file from the check.
1 parent 3e481e4 commit af6c24f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/nextjs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"build:dev:watch": "run-s build:watch",
4949
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
5050
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
51-
"circularDepCheck": "madge --circular src/index.client.ts && madge --circular src/index.server.ts",
51+
"circularDepCheck": "madge --circular src/index.client.ts && madge --circular --exclude 'config/types\\.ts' src/index.server.ts # see https://github.com/pahen/madge/issues/306",
5252
"clean": "rimraf dist esm coverage *.js *.js.map *.d.ts",
5353
"fix": "run-s fix:eslint fix:prettier",
5454
"fix:eslint": "eslint . --format stylish --fix",

0 commit comments

Comments
 (0)