feat(node): Add http.method to node http spans

Author: AbhiPrasad

packages/node/src/integrations/http.ts

@@ -189,7 +189,7 @@ function _createWrappedRequestMethodFactory(
 
       const requestSpanData: SanitizedRequestData = {
         url: requestUrl,
-        method: requestOptions.method || 'GET',
+        'http.method': requestOptions.method || 'GET',
       };
       if (requestOptions.hash) {
         // strip leading "#"

packages/node/src/integrations/undici/index.ts

@@ -111,18 +111,20 @@ export class Undici implements Integration {
         const shouldCreateSpan = this._options.shouldCreateSpanForRequest(stringUrl);
 
         if (shouldCreateSpan) {
-          const data: Record<string, unknown> = {};
+          const method = request.method || 'GET';
+          const data: Record<string, unknown> = {
+            'http.method': method,
+          };
           const params = url.searchParams.toString();
           if (params) {
             data['http.query'] = `?${params}`;
           }
           if (url.hash) {
             data['http.fragment'] = url.hash;
           }
-
           const span = activeSpan.startChild({
             op: 'http.client',
-            description: `${request.method || 'GET'} ${stripUrlQueryAndFragment(stringUrl)}`,
+            description: `${method} ${stripUrlQueryAndFragment(stringUrl)}`,
             data,
           });
           request.__sentry__ = span;

packages/node/test/integrations/http.test.ts

@@ -208,7 +208,7 @@ describe('tracing', () => {
     // our span is at index 1 because the transaction itself is at index 0
     expect(spans[1].description).toEqual('GET http://dogs.are.great/spaniel');
     expect(spans[1].op).toEqual('http.client');
-    expect(spans[1].data.method).toEqual('GET');
+    expect(spans[1].data['http.method']).toEqual('GET');
     expect(spans[1].data.url).toEqual('http://dogs.are.great/spaniel');
     expect(spans[1].data['http.query']).toEqual('tail=wag&cute=true');
     expect(spans[1].data['http.fragment']).toEqual('learn-more');

packages/node/test/integrations/undici.test.ts

@@ -56,6 +56,9 @@ conditionalTest({ min: 16 })('Undici integration', () => {
       {
         description: 'GET http://localhost:18099/',
         op: 'http.client',
+        data: {
+          'http.method': 'GET',
+        },
       },
     ],
     [
@@ -66,6 +69,7 @@ conditionalTest({ min: 16 })('Undici integration', () => {
         description: 'GET http://localhost:18099/',
         op: 'http.client',
         data: {
+          'http.method': 'GET',
           'http.query': '?foo=bar',
         },
       },
@@ -76,6 +80,9 @@ conditionalTest({ min: 16 })('Undici integration', () => {
       { method: 'POST' },
       {
         description: 'POST http://localhost:18099/',
+        data: {
+          'http.method': 'POST',
+        },
       },
     ],
     [
@@ -84,6 +91,9 @@ conditionalTest({ min: 16 })('Undici integration', () => {
       { method: 'POST' },
       {
         description: 'POST http://localhost:18099/',
+        data: {
+          'http.method': 'POST',
+        },
       },
     ],
     [

packages/types/src/request.ts

@@ -18,7 +18,7 @@ export type QueryParams = string | { [key: string]: string } | Array<[string, st
  */
 export type SanitizedRequestData = {
   url: string;
-  method: string;
+  'http.method': string;
   'http.fragment'?: string;
   'http.query'?: string;
 };