build(eslint): Create eslint-config-sentry-sdks (#2807)

* feat: Create packages for sentry eslint config

* all packages use eslint

* Pin typescript versions

* use sentry-sdks instead of @sentry

Author: AbhiPrasad

.eslintignore

@@ -23,6 +23,8 @@
     "packages/browser",
     "packages/core",
     "packages/ember",
+    "packages/eslint-config-sentry-sdks",
+    "packages/eslint-plugin-sentry-sdks",
     "packages/gatsby",
     "packages/hub",
     "packages/integrations",
@@ -43,26 +45,16 @@
     "@types/mocha": "^5.2.0",
     "@types/node": "^11.13.7",
     "@types/sinon": "^7.0.11",
-    "@typescript-eslint/eslint-plugin": "^3.9.0",
-    "@typescript-eslint/parser": "^3.9.0",
     "chai": "^4.1.2",
     "codecov": "^3.6.5",
     "danger": "^7.1.3",
-    "eslint": "^7.5.0",
-    "eslint-config-prettier": "^6.11.0",
-    "eslint-plugin-deprecation": "^1.1.0",
-    "eslint-plugin-import": "^2.22.0",
-    "eslint-plugin-jsdoc": "^30.0.3",
-    "eslint-plugin-sentry-sdks": "file:./eslint-plugin-sentry-sdks",
-    "eslint-plugin-simple-import-sort": "^5.0.3",
     "jest": "^24.7.1",
     "karma-browserstack-launcher": "^1.5.1",
     "karma-firefox-launcher": "^1.1.0",
     "lerna": "3.13.4",
     "mocha": "^6.1.4",
     "npm-run-all": "^4.1.2",
-    "prettier": "^1.17.0",
-    "prettier-check": "^2.0.0",
+    "prettier": "1.17.0",
     "replace-in-file": "^4.0.0",
     "rimraf": "^2.6.3",
     "sinon": "^7.3.2",

eslint-plugin-sentry-sdks/package.json

@@ -7,7 +7,7 @@ module.exports = {
   parserOptions: {
     ecmaVersion: 2018,
   },
-  extends: ['../../.eslintrc.js'],
+  extends: ['sentry-sdks'],
   ignorePatterns: ['build/**/*', 'dist/**/*', 'esm/**/*', 'examples/**/*', 'scripts/**/*'],
   overrides: [
     {

package.json

@@ -26,11 +26,12 @@
     "tslib": "^1.9.3"
   },
   "devDependencies": {
+    "eslint-config-sentry-sdks": "5.20.1",
+    "eslint": "7.6.0",
     "npm-run-all": "^4.1.2",
-    "prettier": "^1.17.0",
-    "prettier-check": "^2.0.0",
+    "prettier": "1.17.0",
     "rimraf": "^2.6.3",
-    "typescript": "^3.5.1"
+    "typescript": "3.4.5"
   },
   "scripts": {
     "build": "run-p build:es5 build:esm",
@@ -42,7 +43,7 @@
     "clean": "rimraf dist coverage build esm",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
-    "lint:prettier": "prettier-check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",

packages/angular/.eslintrc.js

@@ -6,7 +6,7 @@ module.exports = {
   parserOptions: {
     ecmaVersion: 2018,
   },
-  extends: ['../../.eslintrc.js'],
+  extends: ['sentry-sdks'],
   ignorePatterns: ['build/**/*', 'dist/**/*', 'esm/**/*', 'examples/**/*', 'scripts/**/*'],
   overrides: [
     {

packages/angular/package.json

@@ -24,11 +24,12 @@
     "tslib": "^1.9.3"
   },
   "devDependencies": {
+    "eslint-config-sentry-sdks": "5.20.1",
     "@types/express": "^4.17.1",
+    "eslint": "7.6.0",
     "jest": "^24.7.1",
     "npm-run-all": "^4.1.2",
-    "prettier": "^1.17.0",
-    "prettier-check": "^2.0.0",
+    "prettier": "1.17.0",
     "rimraf": "^2.6.3",
     "rollup": "^1.10.1",
     "rollup-plugin-commonjs": "^9.3.4",
@@ -50,7 +51,7 @@
     "clean": "rimraf dist coverage build esm",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
-    "lint:prettier": "prettier-check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",

packages/apm/.eslintrc.js

@@ -506,7 +506,9 @@ export class Tracing implements Integration {
       if (Tracing._heartbeatCounter >= 3) {
         if (Tracing._activeTransaction) {
           Tracing._log(
-            `[Tracing] Transaction: ${SpanStatus.Cancelled} -> Heartbeat safeguard kicked in since content hasn't changed for 3 beats`,
+            `[Tracing] Transaction: ${
+              SpanStatus.Cancelled
+            } -> Heartbeat safeguard kicked in since content hasn't changed for 3 beats`,
           );
           Tracing._activeTransaction.setStatus(SpanStatus.DeadlineExceeded);
           Tracing._activeTransaction.setTag('heartbeat', 'failed');

packages/apm/package.json

@@ -7,7 +7,7 @@ module.exports = {
   parserOptions: {
     ecmaVersion: 2018,
   },
-  extends: ['../../.eslintrc.js'],
+  extends: ['sentry-sdks'],
   ignorePatterns: ['build/**/*', 'dist/**/*', 'esm/**/*', 'examples/**/*', 'scripts/**/*', 'src/loader.js'],
   overrides: [
     {

packages/apm/src/integrations/tracing.ts

@@ -24,6 +24,8 @@
   "devDependencies": {
     "@types/eslint": "^7.2.0",
     "@types/md5": "2.1.33",
+    "eslint-config-sentry-sdks": "5.20.1",
+    "eslint": "7.6.0",
     "btoa": "^1.2.1",
     "chai": "^4.1.2",
     "chokidar": "^3.0.2",
@@ -40,8 +42,7 @@
     "karma-typescript-es6-transform": "^4.0.0",
     "node-fetch": "^2.6.0",
     "npm-run-all": "^4.1.2",
-    "prettier": "^1.17.0",
-    "prettier-check": "^2.0.0",
+    "prettier": "1.17.0",
     "rimraf": "^2.6.3",
     "rollup": "^1.10.1",
     "rollup-plugin-commonjs": "^9.3.4",
@@ -65,7 +66,7 @@
     "clean": "rimraf dist coverage .rpt2_cache build esm",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
-    "lint:prettier": "prettier-check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",

packages/browser/.eslintrc.js

@@ -6,7 +6,7 @@ module.exports = {
   parserOptions: {
     ecmaVersion: 2018,
   },
-  extends: ['../../.eslintrc.js'],
+  extends: ['sentry-sdks'],
   ignorePatterns: ['build/**/*', 'dist/**/*', 'esm/**/*', 'examples/**/*', 'scripts/**/*'],
   overrides: [
     {

packages/browser/package.json

@@ -23,10 +23,11 @@
     "tslib": "^1.9.3"
   },
   "devDependencies": {
+    "eslint-config-sentry-sdks": "5.20.1",
+    "eslint": "7.6.0",
     "jest": "^24.7.1",
     "npm-run-all": "^4.1.2",
-    "prettier": "^1.17.0",
-    "prettier-check": "^2.0.0",
+    "prettier": "1.17.0",
     "rimraf": "^2.6.3",
     "typescript": "3.4.5"
   },
@@ -40,7 +41,7 @@
     "clean": "rimraf dist coverage",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
-    "lint:prettier": "prettier-check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",

packages/core/.eslintrc.js

@@ -7,24 +7,23 @@ module.exports = {
     ecmaVersion: 2018,
     sourceType: 'module',
     ecmaFeatures: {
-      legacyDecorators: true
-    }
+      legacyDecorators: true,
+    },
   },
-  plugins: [
-    'ember'
-  ],
-  extends: [
-    'eslint:recommended',
-    'plugin:ember/recommended'
-  ],
+  plugins: ['ember'],
+  extends: ['eslint:recommended', 'plugin:ember/recommended'],
   env: {
-    browser: true
+    browser: true,
   },
   globals: {
-    "QUnit": true
+    QUnit: true,
   },
   rules: {},
   overrides: [
+    {
+      files: ['addon/**/*'],
+      plugins: ['sentry-sdks'],
+    },
     // node files
     {
       files: [
@@ -35,23 +34,18 @@ module.exports = {
         'testem.js',
         'blueprints/*/index.js',
         'config/**/*.js',
-        'tests/dummy/config/**/*.js'
-      ],
-      excludedFiles: [
-        'addon/**',
-        'addon-test-support/**',
-        'app/**',
-        'tests/dummy/app/**'
+        'tests/dummy/config/**/*.js',
       ],
+      excludedFiles: ['addon/**', 'addon-test-support/**', 'app/**', 'tests/dummy/app/**'],
       parserOptions: {
-        sourceType: 'script'
+        sourceType: 'script',
       },
       env: {
         browser: false,
-        node: true
+        node: true,
       },
       plugins: ['node'],
-      extends: ['plugin:node/recommended']
-    }
-  ]
+      extends: ['plugin:node/recommended'],
+    },
+  ],
 };

packages/core/package.json

@@ -39,6 +39,7 @@
     "@ember/optional-features": "^1.3.0",
     "@glimmer/component": "^1.0.0",
     "@glimmer/tracking": "^1.0.0",
+    "eslint-config-sentry-sdks": "5.20.1",
     "@types/ember": "^3.16.0",
     "@types/ember-qunit": "^3.4.9",
     "@types/ember__test-helpers": "^1.7.0",
@@ -64,13 +65,13 @@
     "ember-template-lint": "^2.9.1",
     "ember-test-selectors": "^4.1.0",
     "ember-try": "^1.4.0",
-    "eslint": "^7.5.0",
+    "eslint": "7.6.0",
     "eslint-plugin-ember": "^8.6.0",
     "eslint-plugin-node": "^11.1.0",
     "loader.js": "^4.7.0",
     "npm-run-all": "^4.1.5",
     "qunit-dom": "^1.2.0",
-    "typescript": "^3.9.7"
+    "typescript": "3.4.5"
   },
   "engines": {
     "node": "10.* || >= 12"

packages/ember/.eslintrc.js

@@ -0,0 +1,2 @@
+*
+!/src/**/*

packages/ember/package.json

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2020 Sentry (https://sentry.io/) and individual contributors.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

packages/eslint-config-sentry-sdks/.npmignore

@@ -0,0 +1,41 @@
+<p align="center">
+  <a href="https://sentry.io" target="_blank" align="center">
+    <img src="https://sentry-brand.storage.googleapis.com/sentry-logo-black.png" width="280">
+  </a>
+  <br />
+</p>
+
+# Official Sentry SDK eslint config
+
+[![npm version](https://img.shields.io/npm/v/@sentry/integrations.svg)](https://www.npmjs.com/package/@sentry/integrations)
+[![npm dm](https://img.shields.io/npm/dm/@sentry/integrations.svg)](https://www.npmjs.com/package/@sentry/integrations)
+[![npm dt](https://img.shields.io/npm/dt/@sentry/integrations.svg)](https://www.npmjs.com/package/@sentry/integrations)
+[![typedoc](https://img.shields.io/badge/docs-typedoc-blue.svg)](http://getsentry.github.io/sentry-javascript/)
+
+## Links
+
+- [Official SDK Docs](https://docs.sentry.io/quickstart/)
+- [TypeDoc](http://getsentry.github.io/sentry-javascript/)
+
+## General
+
+Install with `yarn add -D eslint-config-sentry-sdks`
+
+## Configuration
+
+Use `sentry-sdks` for base rules. Make sure to specify your tsconfig under `parserOptions.project` so that you can
+correctly use the typescript rules. This configuration comes with
+
+```json
+{
+  "extends": ["@sentry"],
+  "overrides": [
+    {
+      "files": ["*.ts", "*.tsx", "*.d.ts"],
+      "parserOptions": {
+        "project": "./tsconfig.json"
+      }
+    }
+  ]
+}
+```