add first test

Author: Lms24

packages/browser/src/transports/index.ts

@@ -3,3 +3,4 @@ export { FetchTransport } from './fetch';
 export { XHRTransport } from './xhr';
 
 export { makeNewFetchTransport } from './new-fetch';
+export { makeNewXHRTransport } from './new-xhr';

packages/browser/src/transports/new-xhr.ts

@@ -8,7 +8,9 @@ import {
 import { SyncPromise } from '@sentry/utils';
 
 export interface XHRTransportOptions extends BaseTransportOptions {
+  // TODO choose whatever is preferred here (I like record more for easier readability)
   headers?: { [key: string]: string };
+  // headers?: Record<string, string>;
 }
 
 /**
@@ -21,17 +23,17 @@ export function makeNewXHRTransport(options: XHRTransportOptions): NewTransport
 
       xhr.onreadystatechange = (): void => {
         if (xhr.readyState === 4) {
-          const headers = {
-            'x-sentry-rate-limits': xhr.getResponseHeader('X-Sentry-Rate-Limits'),
-            'retry-after': xhr.getResponseHeader('Retry-After'),
-          };
           const response = {
             body: xhr.response,
-            headers,
+            headers: {
+              'x-sentry-rate-limits': xhr.getResponseHeader('X-Sentry-Rate-Limits'),
+              'retry-after': xhr.getResponseHeader('Retry-After'),
+            },
             reason: xhr.statusText,
             statusCode: xhr.status,
           };
 
+          // TODO when to reject? is it necessary at all, given that createTransport handles rejections?
           resolve(response);
         }
       };

packages/browser/test/unit/transports/new-xhr.test.ts

@@ -0,0 +1,65 @@
+import { EventEnvelope, EventItem } from '@sentry/types';
+import { createEnvelope, serializeEnvelope } from '@sentry/utils';
+import { makeNewXHRTransport, XHRTransportOptions } from '../../../src/transports/new-xhr';
+
+const DEFAULT_XHR_TRANSPORT_OPTIONS: XHRTransportOptions = {
+  url: 'https://sentry.io/api/42/store/?sentry_key=123&sentry_version=7',
+};
+
+const ERROR_ENVELOPE = createEnvelope<EventEnvelope>({ event_id: 'aa3ff046696b4bc6b609ce6d28fde9e2', sent_at: '123' }, [
+  [{ type: 'event' }, { event_id: 'aa3ff046696b4bc6b609ce6d28fde9e2' }] as EventItem,
+]);
+
+function createXHRMock() {
+  const retryAfterSeconds = 10;
+
+  const xhrMock: Partial<XMLHttpRequest> = {
+    open: jest.fn(),
+    send: jest.fn(),
+    setRequestHeader: jest.fn(),
+    readyState: 4,
+    status: 200,
+    response: 'Hello World!',
+    onreadystatechange: () => {},
+    getResponseHeader: (header: string) => {
+      switch (header) {
+        case 'Retry-After':
+          return '10';
+        case `${retryAfterSeconds}`:
+          return;
+        default:
+          return `${retryAfterSeconds}:error:scope`;
+      }
+    },
+  };
+
+  //@ts-ignore
+  jest.spyOn(window, 'XMLHttpRequest').mockImplementation(() => xhrMock as XMLHttpRequest);
+
+  return xhrMock;
+}
+
+describe('NewXHRTransport', () => {
+  it('makes an XHR request to the given URL', done => {
+    const xhrMock: Partial<XMLHttpRequest> = createXHRMock();
+
+    const transport = makeNewXHRTransport(DEFAULT_XHR_TRANSPORT_OPTIONS);
+    expect(xhrMock.open).toHaveBeenCalledTimes(0);
+    expect(xhrMock.setRequestHeader).toHaveBeenCalledTimes(0);
+    expect(xhrMock.send).toHaveBeenCalledTimes(0);
+
+    transport.send(ERROR_ENVELOPE).then(res => {
+      expect(xhrMock.open).toHaveBeenCalledTimes(1);
+      expect(xhrMock.open).toHaveBeenCalledWith('POST', DEFAULT_XHR_TRANSPORT_OPTIONS.url);
+      expect(xhrMock.send).toBeCalledWith(serializeEnvelope(ERROR_ENVELOPE));
+
+      expect(res).toBeTruthy;
+      expect(res.status).toEqual('success');
+
+      done();
+    });
+
+    //@ts-ignore
+    xhrMock.onreadystatechange();
+  });
+});