build: Switch hub to using eslint

Author: AbhiPrasad

.eslintignore

@@ -4,7 +4,6 @@
 packages/apm/**/*
 packages/ember/**/*
 packages/gatsby/**/*
-packages/hub/**/*
 packages/integrations/**/*
 packages/minimal/**/*
 packages/node/**/*

.eslintrc.js

@@ -125,5 +125,8 @@ module.exports = {
 
     // Limit maximum file size to reduce complexity. Turned off in tests.
     'max-lines': 'error',
+
+    // We should require a whitespace beginning a comment
+    'spaced-comment': 'error',
   },
 };

packages/hub/.eslintrc.js

@@ -0,0 +1,26 @@
+module.exports = {
+  root: true,
+  env: {
+    es6: true,
+  },
+  parserOptions: {
+    ecmaVersion: 2018,
+  },
+  extends: ['../../.eslintrc.js'],
+  ignorePatterns: ['build/**/*', 'dist/**/*', 'esm/**/*', 'examples/**/*', 'scripts/**/*'],
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx', '*.d.ts'],
+      parserOptions: {
+        project: './tsconfig.json',
+      },
+    },
+    {
+      files: ['test/**/*'],
+      rules: {
+        '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/no-non-null-assertion': 'off',
+      },
+    },
+  ],
+};

packages/hub/package.json

@@ -26,7 +26,6 @@
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
     "rimraf": "^2.6.3",
-    "tslint": "5.16.0",
     "typescript": "3.4.5"
   },
   "scripts": {
@@ -38,13 +37,13 @@
     "build:watch:esm": "tsc -p tsconfig.esm.json -w --preserveWatchOutput",
     "clean": "rimraf dist coverage",
     "link:yarn": "yarn link",
-    "lint": "run-s lint:prettier lint:tslint",
+    "lint": "run-s lint:prettier lint:eslint",
     "lint:prettier": "prettier-check \"{src,test}/**/*.ts\"",
-    "lint:tslint": "tslint -t stylish -p .",
-    "lint:tslint:json": "tslint --format json -p . | tee lint-results.json",
-    "fix": "run-s fix:tslint fix:prettier",
+    "lint:eslint": "eslint . --format stylish",
+    "lint:eslint:json": "eslint . --format json | tee lint-results.json",
+    "fix": "run-s fix:eslint fix:prettier",
     "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
-    "fix:tslint": "tslint --fix -t stylish -p .",
+    "fix:eslint": "lint:eslint --fix",
     "test": "jest",
     "test:watch": "jest --watch"
   },

packages/hub/src/hub.ts

@@ -1,3 +1,4 @@
+/* eslint-disable max-lines */
 import {
   Breadcrumb,
   BreadcrumbHint,
@@ -66,19 +67,6 @@ export class Hub implements HubInterface {
     this.bindClient(client);
   }
 
-  /**
-   * Internal helper function to call a method on the top client if it exists.
-   *
-   * @param method The method to call on the client.
-   * @param args Arguments to pass to the client function.
-   */
-  private _invokeClient<M extends keyof Client>(method: M, ...args: any[]): void {
-    const top = this.getStackTop();
-    if (top && top.client && top.client[method]) {
-      (top.client as any)[method](...args, top.scope);
-    }
-  }
-
   /**
    * @inheritDoc
    */
@@ -156,6 +144,7 @@ export class Hub implements HubInterface {
   /**
    * @inheritDoc
    */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
   public captureException(exception: any, hint?: EventHint): string {
     const eventId = (this._lastEventId = uuid4());
     let finalHint = hint;
@@ -244,6 +233,7 @@ export class Hub implements HubInterface {
       return;
     }
 
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     const { beforeBreadcrumb = null, maxBreadcrumbs = DEFAULT_BREADCRUMBS } =
       (top.client.getOptions && top.client.getOptions()) || {};
 
@@ -322,7 +312,7 @@ export class Hub implements HubInterface {
   /**
    * @inheritDoc
    */
-  public setContext(name: string, context: { [key: string]: any } | null): void {
+  public setContext(name: string, context: { [key: string]: unknown } | null): void {
     const top = this.getStackTop();
     if (!top.scope) {
       return;
@@ -389,14 +379,29 @@ export class Hub implements HubInterface {
     return this._callExtensionMethod<{ [key: string]: string }>('traceHeaders');
   }
 
+  /**
+   * Internal helper function to call a method on the top client if it exists.
+   *
+   * @param method The method to call on the client.
+   * @param args Arguments to pass to the client function.
+   */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  private _invokeClient<M extends keyof Client>(method: M, ...args: any[]): void {
+    const top = this.getStackTop();
+    if (top && top.client && top.client[method]) {
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      (top.client as any)[method](...args, top.scope);
+    }
+  }
+
   /**
    * Calls global extension method and binding current instance to the function call
    */
-  // @ts-ignore
+  // @ts-ignore Function lacks ending return statement and return type does not include 'undefined'. ts(2366)
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private _callExtensionMethod<T>(method: string, ...args: any[]): T {
     const carrier = getMainCarrier();
     const sentry = carrier.__SENTRY__;
-    // tslint:disable-next-line: strict-type-predicates
     if (sentry && sentry.extensions && typeof sentry.extensions[method] === 'function') {
       return sentry.extensions[method].apply(this, args);
     }
@@ -459,10 +464,10 @@ function getHubFromActiveDomain(registry: Carrier): Hub {
     const property = 'domain';
     const carrier = getMainCarrier();
     const sentry = carrier.__SENTRY__;
-    // tslint:disable-next-line: strict-type-predicates
     if (!sentry || !sentry.extensions || !sentry.extensions[property]) {
       return getHubFromCarrier(registry);
     }
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const domain = sentry.extensions[property] as any;
     const activeDomain = domain.active;
 

packages/hub/src/interfaces.ts

@@ -22,6 +22,7 @@ export interface Carrier {
     /**
      * These are extension methods for the hub, the current instance of the hub will be bound to it
      */
+    // eslint-disable-next-line @typescript-eslint/ban-types
     extensions?: { [key: string]: Function };
   };
 }