fix(profiling): continuous profile chunks should be in seconds

Author: JonasBa

packages/profiling-node/bindings/cpu_profiler.cc

@@ -759,7 +759,7 @@ static napi_value TranslateMeasurementsDouble(
     } else if (format == ProfileFormat::kFormatChunk) {
       napi_value ts;
       napi_create_double(
-          env, profile_start_timestamp_ms + (timestamps_ns[i] * 1e-6), &ts);
+          env, profile_start_timestamp_ms + (timestamps_ns[i] * 1e-9), &ts);
       napi_set_named_property(env, entry, "timestamp", ts);
     }
 
@@ -818,7 +818,7 @@ TranslateMeasurements(const napi_env &env, const enum ProfileFormat format,
     case ProfileFormat::kFormatChunk: {
       napi_value ts;
       napi_create_double(
-          env, profile_start_timestamp_ms + (timestamps_ns[i] * 1e-6), &ts);
+          env, profile_start_timestamp_ms + (timestamps_ns[i] * 1e-9), &ts);
       napi_set_named_property(env, entry, "timestamp", ts);
     } break;
     default:

packages/profiling-node/src/integration.ts

@@ -146,7 +146,6 @@ function setupAutomatedSpanProfiling(client: NodeClient): void {
 interface ChunkData {
   id: string;
   timer: NodeJS.Timeout | undefined;
-  startTimestampMS: number;
   startTraceID: string;
 }
 class ContinuousProfiler {
@@ -212,7 +211,7 @@ class ContinuousProfiler {
       return;
     }
     const profile = CpuProfilerBindings.stopProfiling(this._chunkData.id, ProfileFormat.CHUNK);
-    if (!profile || !this._chunkData.startTimestampMS) {
+    if (!profile) {
       DEBUG_BUILD && logger.log(`[Profiling] _chunkiledStartTraceID to collect profile for: ${this._chunkData.id}`);
       return;
     }
@@ -222,7 +221,6 @@ class ContinuousProfiler {
 
     DEBUG_BUILD && logger.log(`[Profiling] Profile chunk ${this._chunkData.id} sent to Sentry.`);
     const chunk = createProfilingChunkEvent(
-      this._chunkData.startTimestampMS,
       this._client,
       this._client.getOptions(),
       profile,
@@ -300,7 +298,6 @@ class ContinuousProfiler {
     this._chunkData = {
       id: uuid4(),
       startTraceID: traceId,
-      startTimestampMS: timestampInSeconds(),
       timer: undefined,
     };
   }

packages/profiling-node/src/utils.ts

@@ -191,14 +191,12 @@ function createProfileChunkPayload(
   {
     release,
     environment,
-    start_timestamp,
     trace_id,
     profiler_id,
     chunk_id,
   }: {
     release: string;
     environment: string;
-    start_timestamp: number;
     trace_id: string | undefined;
     chunk_id: string;
     profiler_id: string;
@@ -216,7 +214,6 @@ function createProfileChunkPayload(
   const profile: ProfileChunk = {
     chunk_id: chunk_id,
     profiler_id: profiler_id,
-    timestamp: new Date(start_timestamp).toISOString(),
     platform: 'node',
     version: CONTINUOUS_FORMAT_VERSION,
     release: release,
@@ -235,7 +232,6 @@ function createProfileChunkPayload(
  * Creates a profiling chunk envelope item, if the profile does not pass validation, returns null.
  */
 export function createProfilingChunkEvent(
-  start_timestamp: number,
   client: Client,
   options: { release?: string; environment?: string },
   profile: RawChunkCpuProfile,
@@ -248,7 +244,6 @@ export function createProfilingChunkEvent(
   return createProfileChunkPayload(client, profile, {
     release: options.release ?? '',
     environment: options.environment ?? '',
-    start_timestamp: start_timestamp,
     trace_id: identifiers.trace_id ?? '',
     chunk_id: identifiers.chunk_id,
     profiler_id: identifiers.profiler_id,

packages/types/src/profiling.ts

@@ -50,7 +50,6 @@ export interface ContinuousThreadCpuProfile {
 }
 
 interface BaseProfile<T> {
-  timestamp: string;
   version: string;
   release: string;
   environment: string;