add plugins for import

Author: AbhiPrasad

.eslintrc.js

@@ -3,8 +3,8 @@ module.exports = {
   env: {
     node: true,
   },
-  extends: ['prettier', 'eslint:recommended'],
-  plugins: ['sentry-sdk', 'jsdoc', 'deprecation'],
+  extends: ['prettier', 'eslint:recommended', 'plugin:import/errors', 'plugin:import/warnings'],
+  plugins: ['sentry-sdk', 'simple-import-sort'],
   ignorePatterns: ['eslint-plugin-sentry-sdk'],
   overrides: [
     {
@@ -17,8 +17,8 @@ module.exports = {
     {
       // Configuration for typescript files
       files: ['*.ts', '*.tsx', '*.d.ts'],
-      extends: ['plugin:@typescript-eslint/recommended', 'prettier/@typescript-eslint'],
-      plugins: ['@typescript-eslint'],
+      extends: ['plugin:@typescript-eslint/recommended', 'prettier/@typescript-eslint', 'plugin:import/typescript'],
+      plugins: ['@typescript-eslint', 'jsdoc', 'deprecation'],
       parser: '@typescript-eslint/parser',
       parserOptions: {
         project: './tsconfig.json',
@@ -82,6 +82,11 @@ module.exports = {
 
         // Do not use deprecated methods
         'deprecation/deprecation': 'error',
+
+        // sort imports
+        'simple-import-sort/sort': 'error',
+        'sort-imports': 'off',
+        'import/order': 'off',
       },
     },
     {
@@ -153,5 +158,11 @@ module.exports = {
 
     // Make sure all expressions are used. Turn off on tests.
     'no-unused-expressions': 'error',
+
+    // We shouldn't make assumptions about imports/exports being dereferenced.
+    'import/namespace': 'off',
+
+    // imports should be ordered.
+    'import/order': ['error', { 'newlines-between': 'always' }],
   },
 };

dangerfile.ts

@@ -1,7 +1,8 @@
 import { exec } from 'child_process';
-import { danger, fail, message, schedule, warn } from 'danger';
 import { promisify } from 'util';
 import { resolve } from 'path';
+
+import { danger, fail, message, schedule, warn } from 'danger';
 import tslint from 'danger-plugin-tslint';
 import { prettyResults } from 'danger-plugin-tslint/dist/prettyResults';
 import { CLIEngine } from 'eslint';

package.json

@@ -54,8 +54,10 @@
     "eslint": "^7.5.0",
     "eslint-config-prettier": "^6.11.0",
     "eslint-plugin-deprecation": "^1.1.0",
+    "eslint-plugin-import": "^2.22.0",
     "eslint-plugin-jsdoc": "^30.0.3",
     "eslint-plugin-sentry-sdk": "file:./eslint-plugin-sentry-sdk",
+    "eslint-plugin-simple-import-sort": "^5.0.3",
     "jest": "^24.7.1",
     "karma-browserstack-launcher": "^1.5.1",
     "karma-firefox-launcher": "^1.1.0",

packages/angular/src/tracing.ts

@@ -1,5 +1,3 @@
-// tslint:disable:max-classes-per-file
-
 import { AfterViewInit, Directive, Injectable, Input, OnInit } from '@angular/core';
 import { Event, NavigationEnd, NavigationStart, Router } from '@angular/router';
 import { getCurrentHub } from '@sentry/browser';

packages/apm/src/integrations/tracing.ts

@@ -15,7 +15,6 @@ import {
 import { Span as SpanClass } from '../span';
 import { SpanStatus } from '../spanstatus';
 import { Transaction } from '../transaction';
-
 import { Location } from './types';
 
 /**

packages/apm/src/spanstatus.ts

@@ -1,4 +1,5 @@
 /** The status of an Span. */
+// eslint-disable-next-line import/export
 export enum SpanStatus {
   /** The operation completed successfully. */
   Ok = 'ok',
@@ -36,7 +37,7 @@ export enum SpanStatus {
   DataLoss = 'data_loss',
 }
 
-// eslint-disable-next-line @typescript-eslint/no-namespace
+// eslint-disable-next-line @typescript-eslint/no-namespace, import/export
 export namespace SpanStatus {
   /**
    * Converts a HTTP status code into a {@link SpanStatus}.

packages/browser/test/integration/run.js

@@ -1,9 +1,10 @@
 #!/usr/bin/env node
 
 const fs = require("fs");
+const path = require("path");
+
 const rimraf = require("rimraf");
 const karma = require("karma");
-const path = require("path");
 const chokidar = require("chokidar");
 
 const isDebugMode = process.argv.some(x => x === "--debug");

packages/browser/test/package/npm-build.js

@@ -1,5 +1,6 @@
 const fs = require('fs');
 const path = require('path');
+
 const webpack = require('webpack');
 const { JSDOM } = require('jsdom');
 

packages/browser/test/unit/index.test.ts

@@ -16,7 +16,6 @@ import {
   Scope,
   wrap,
 } from '../../src';
-
 import { SimpleTransport } from './mocks/simpletransport';
 
 const dsn = 'https://[email protected]/4291';

packages/browser/test/unit/tracekit/original.test.ts

@@ -1,7 +1,6 @@
 import { expect } from 'chai';
 
 import { computeStackTrace } from '../../../src/tracekit';
-
 import {
   ANDROID_REACT_NATIVE,
   ANDROID_REACT_NATIVE_HERMES,
@@ -11,13 +10,13 @@ import {
   CHROME_48_BLOB,
   CHROME_48_EVAL,
   CHROME_XX_WEBPACK,
-  FIREFOX_14,
   FIREFOX_3,
+  FIREFOX_7,
+  FIREFOX_14,
   FIREFOX_31,
   FIREFOX_43_EVAL,
   FIREFOX_44_NS_EXCEPTION,
   FIREFOX_50_RESOURCE_URL,
-  FIREFOX_7,
   IE_10,
   IE_11,
   IE_11_EVAL,

packages/core/test/lib/sdk.test.ts

@@ -1,4 +1,4 @@
-import { Integration, Client } from '@sentry/types';
+import { Client, Integration } from '@sentry/types';
 
 import { installedIntegrations } from '../../src/integration';
 import { initAndBind } from '../../src/sdk';

packages/core/test/mocks/client.ts

@@ -1,6 +1,5 @@
 import { BaseClient } from '../../src/baseclient';
 import { initAndBind } from '../../src/sdk';
-
 import { TestBackend, TestOptions } from './backend';
 
 export class TestClient extends BaseClient<TestBackend, TestOptions> {

packages/types/src/severity.ts

@@ -1,4 +1,5 @@
 /** JSDoc */
+// eslint-disable-next-line import/export
 export enum Severity {
   /** JSDoc */
   Fatal = 'fatal',
@@ -16,7 +17,7 @@ export enum Severity {
   Critical = 'critical',
 }
 
-// eslint-disable-next-line @typescript-eslint/no-namespace
+// eslint-disable-next-line @typescript-eslint/no-namespace, import/export
 export namespace Severity {
   /**
    * Converts a string-based level into a {@link Severity}.

packages/types/src/status.ts

@@ -1,4 +1,5 @@
 /** The status of an event. */
+// eslint-disable-next-line import/export
 export enum Status {
   /** The status could not be determined. */
   Unknown = 'unknown',
@@ -14,7 +15,7 @@ export enum Status {
   Failed = 'failed',
 }
 
-// eslint-disable-next-line @typescript-eslint/no-namespace
+// eslint-disable-next-line @typescript-eslint/no-namespace, import/export
 export namespace Status {
   /**
    * Converts a HTTP status code into a {@link Status}.