File tree Expand file tree Collapse file tree 2 files changed +9
-1
lines changed Expand file tree Collapse file tree 2 files changed +9
-1
lines changed Original file line number Diff line number Diff line change @@ -46,7 +46,7 @@ export namespace SpanStatus {
46
46
* @returns The span status or {@link SpanStatus.UnknownError}.
47
47
*/
48
48
export function fromHttpCode ( httpStatus : number ) : SpanStatus {
49
- if ( httpStatus < 400 ) {
49
+ if ( httpStatus < 400 && httpStatus >= 100 ) {
50
50
return SpanStatus . Ok ;
51
51
}
52
52
Original file line number Diff line number Diff line change @@ -90,6 +90,14 @@ describe('Span', () => {
90
90
expect ( span . isSuccess ( ) ) . toBe ( true ) ;
91
91
span . setStatus ( SpanStatus . PermissionDenied ) ;
92
92
expect ( span . isSuccess ( ) ) . toBe ( false ) ;
93
+ span . setHttpStatus ( 0 ) ;
94
+ expect ( span . isSuccess ( ) ) . toBe ( false ) ;
95
+ span . setHttpStatus ( - 1 ) ;
96
+ expect ( span . isSuccess ( ) ) . toBe ( false ) ;
97
+ span . setHttpStatus ( 99 ) ;
98
+ expect ( span . isSuccess ( ) ) . toBe ( false ) ;
99
+ span . setHttpStatus ( 100 ) ;
100
+ expect ( span . isSuccess ( ) ) . toBe ( true ) ;
93
101
} ) ;
94
102
} ) ;
95
103
You can’t perform that action at this time.
0 commit comments